Skip to content

Commit f06a2e4

Browse files
committed
Using standard property clause for placeholders in XML include
1 parent 463a4a5 commit f06a2e4

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

src/main/java/org/apache/ibatis/builder/xml/mybatis-3-mapper.dtd

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -238,17 +238,11 @@ lang CDATA #IMPLIED
238238

239239
<!-- Dynamic -->
240240

241-
<!ELEMENT include (placeholder+)?>
241+
<!ELEMENT include (property+)?>
242242
<!ATTLIST include
243243
refid CDATA #REQUIRED
244244
>
245245

246-
<!ELEMENT placeholder EMPTY>
247-
<!ATTLIST placeholder
248-
name CDATA #REQUIRED
249-
value CDATA #REQUIRED
250-
>
251-
252246
<!ELEMENT bind EMPTY>
253247
<!ATTLIST bind
254248
name CDATA #REQUIRED

src/test/java/org/apache/ibatis/builder/PostMapper.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@
103103
</if>
104104
<trim prefix="AND">
105105
<include refid="byBlogId">
106-
<placeholder name="prefix" value="blog"/>
106+
<property name="prefix" value="blog"/>
107107
</include>
108108
</trim>
109109
</otherwise>

src/test/java/org/apache/ibatis/submitted/includes/Mapper.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@
3232

3333
<select id="select" resultType="map">
3434
<include refid="someinclude">
35-
<placeholder name="include_target" value="org.apache.ibatis.submitted.includes.fragments.select"/>
35+
<property name="include_target" value="org.apache.ibatis.submitted.includes.fragments.select"/>
3636
</include>
3737
field1, field2, field3
3838
from
3939
<include refid="someinclude">
40-
<placeholder name="prefix" value="Some"/>
41-
<placeholder name="include_target" value="sometable"/>
40+
<property name="prefix" value="Some"/>
41+
<property name="include_target" value="sometable"/>
4242
</include>
4343
</select>
4444

@@ -49,7 +49,7 @@
4949
<update id="update" parameterType="map">
5050
<include refid="org.apache.ibatis.submitted.includes.fragments.update"/>
5151
<include refid="org.apache.ibatis.submitted.includes.mapper.sometable">
52-
<placeholder name="prefix" value="Some"/>
52+
<property name="prefix" value="Some"/>
5353
</include>
5454
set Field2 = #{field2,jdbcType=INTEGER},
5555
Field3 = #{field3,jdbcType=VARCHAR},

0 commit comments

Comments
 (0)