Less object creation in GenericTokenParser.

Author: harawata

src/main/java/org/apache/ibatis/parsing/GenericTokenParser.java

@@ -31,50 +31,58 @@ public GenericTokenParser(String openToken, String closeToken, TokenHandler hand
   }
 
   public String parse(String text) {
+    if (text == null || text.isEmpty()) {
+      return "";
+    }
+    char[] src = text.toCharArray();
+    int offset = 0;
+    // search open token
+    int start = text.indexOf(openToken, offset);
+    if (start == -1) {
+      return text;
+    }
     final StringBuilder builder = new StringBuilder();
-    final StringBuilder expression = new StringBuilder();
-    if (text != null && text.length() > 0) {
-      char[] src = text.toCharArray();
-      int offset = 0;
-      // search open token
-      int start = text.indexOf(openToken, offset);
-      while (start > -1) {
-        if (start > 0 && src[start - 1] == '\\') {
-          // this open token is escaped. remove the backslash and continue.
-          builder.append(src, offset, start - offset - 1).append(openToken);
-          offset = start + openToken.length();
+    StringBuilder expression = null;
+    while (start > -1) {
+      if (start > 0 && src[start - 1] == '\\') {
+        // this open token is escaped. remove the backslash and continue.
+        builder.append(src, offset, start - offset - 1).append(openToken);
+        offset = start + openToken.length();
+      } else {
+        // found open token. let's search close token.
+        if (expression == null) {
+          expression = new StringBuilder();
         } else {
-          // found open token. let's search close token.
           expression.setLength(0);
-          builder.append(src, offset, start - offset);
-          offset = start + openToken.length();
-          int end = text.indexOf(closeToken, offset);
-          while (end > -1) {
-            if (end > offset && src[end - 1] == '\\') {
-              // this close token is escaped. remove the backslash and continue.
-              expression.append(src, offset, end - offset - 1).append(closeToken);
-              offset = end + closeToken.length();
-              end = text.indexOf(closeToken, offset);
-            } else {
-              expression.append(src, offset, end - offset);
-              offset = end + closeToken.length();
-              break;
-            }
-          }
-          if (end == -1) {
-            // close token was not found.
-            builder.append(src, start, src.length - start);
-            offset = src.length;
+        }
+        builder.append(src, offset, start - offset);
+        offset = start + openToken.length();
+        int end = text.indexOf(closeToken, offset);
+        while (end > -1) {
+          if (end > offset && src[end - 1] == '\\') {
+            // this close token is escaped. remove the backslash and continue.
+            expression.append(src, offset, end - offset - 1).append(closeToken);
+            offset = end + closeToken.length();
+            end = text.indexOf(closeToken, offset);
           } else {
-            builder.append(handler.handleToken(expression.toString()));
+            expression.append(src, offset, end - offset);
             offset = end + closeToken.length();
+            break;
           }
         }
-        start = text.indexOf(openToken, offset);
-      }
-      if (offset < src.length) {
-        builder.append(src, offset, src.length - offset);
+        if (end == -1) {
+          // close token was not found.
+          builder.append(src, start, src.length - start);
+          offset = src.length;
+        } else {
+          builder.append(handler.handleToken(expression.toString()));
+          offset = end + closeToken.length();
+        }
       }
+      start = text.indexOf(openToken, offset);
+    }
+    if (offset < src.length) {
+      builder.append(src, offset, src.length - offset);
     }
     return builder.toString();
   }