Inlined nodeHandlers() method. refs #1149

Author: harawata

src/main/java/org/apache/ibatis/scripting/xmltags/XMLScriptBuilder.java

@@ -51,16 +51,16 @@ public XMLScriptBuilder(Configuration configuration, XNode context, Class<?> par
   }
 
 
-  private void initNodeHandlerMap(){
-      nodeHandlerMap.put("trim", new TrimHandler());
-      nodeHandlerMap.put("where", new WhereHandler());
-      nodeHandlerMap.put("set", new SetHandler());
-      nodeHandlerMap.put("foreach", new ForEachHandler());
-      nodeHandlerMap.put("if", new IfHandler());
-      nodeHandlerMap.put("choose", new ChooseHandler());
-      nodeHandlerMap.put("when", new IfHandler());
-      nodeHandlerMap.put("otherwise", new OtherwiseHandler());
-      nodeHandlerMap.put("bind", new BindHandler());
+  private void initNodeHandlerMap() {
+    nodeHandlerMap.put("trim", new TrimHandler());
+    nodeHandlerMap.put("where", new WhereHandler());
+    nodeHandlerMap.put("set", new SetHandler());
+    nodeHandlerMap.put("foreach", new ForEachHandler());
+    nodeHandlerMap.put("if", new IfHandler());
+    nodeHandlerMap.put("choose", new ChooseHandler());
+    nodeHandlerMap.put("when", new IfHandler());
+    nodeHandlerMap.put("otherwise", new OtherwiseHandler());
+    nodeHandlerMap.put("bind", new BindHandler());
   }
 
   public SqlSource parseScriptNode() {
@@ -91,7 +91,7 @@ List<SqlNode> parseDynamicTags(XNode node) {
         }
       } else if (child.getNode().getNodeType() == Node.ELEMENT_NODE) { // issue #628
         String nodeName = child.getNode().getNodeName();
-        NodeHandler handler = nodeHandlers(nodeName);
+        NodeHandler handler = nodeHandlerMap.get(nodeName);
         if (handler == null) {
           throw new BuilderException("Unknown element <" + nodeName + "> in SQL statement.");
         }
@@ -102,10 +102,6 @@ List<SqlNode> parseDynamicTags(XNode node) {
     return contents;
   }
 
-  NodeHandler nodeHandlers(String nodeName) {
-    return nodeHandlerMap.get(nodeName);
-  }
-
   private interface NodeHandler {
     void handleNode(XNode nodeToHandle, List<SqlNode> targetContents);
   }
@@ -237,7 +233,7 @@ private void handleWhenOtherwiseNodes(XNode chooseSqlNode, List<SqlNode> ifSqlNo
       List<XNode> children = chooseSqlNode.getChildren();
       for (XNode child : children) {
         String nodeName = child.getNode().getNodeName();
-        NodeHandler handler = nodeHandlers(nodeName);
+        NodeHandler handler = nodeHandlerMap.get(nodeName);
         if (handler instanceof IfHandler) {
           handler.handleNode(child, ifSqlNodes);
         } else if (handler instanceof OtherwiseHandler) {