Skip to content

Commit 4ccd77f

Browse files
authored
Merge pull request #134 from jeffgbutler/master
Change the update pattern to updateAll and updateSelective
2 parents 8222fb2 + 0fdb8d9 commit 4ccd77f

File tree

7 files changed

+16
-16
lines changed

7 files changed

+16
-16
lines changed

src/main/java/org/mybatis/dynamic/sql/update/UpdateDSLCompleter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
* the following method would set all fields of a record based on whether or not the values are null:
6363
*
6464
* <pre>
65-
* static UpdateDSL&lt;UpdateModel&gt; setSelective(PersonRecord record,
65+
* static UpdateDSL&lt;UpdateModel&gt; updateSelective(PersonRecord record,
6666
* UpdateDSL&lt;UpdateModel&gt; dsl) {
6767
* return dsl.set(id).equalToWhenPresent(record::getId)
6868
* .set(firstName).equalToWhenPresent(record::getFirstName)
@@ -77,7 +77,7 @@
7777
*
7878
* <pre>
7979
* rows = mapper.update(c -&gt;
80-
* PersonMapper.setSelective(record, c)
80+
* PersonMapper.updateSelective(record, c)
8181
* .where(id, isLessThan(100)));
8282
* </pre>
8383
*

src/site/markdown/docs/kotlin.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ val rows = mapper.update {
340340
It is also possible to write a utility method that will set values. For example:
341341

342342
```kotlin
343-
fun UpdateDSL<UpdateModel>.setSelective(record: PersonRecord) =
343+
fun UpdateDSL<UpdateModel>.updateSelective(record: PersonRecord) =
344344
apply {
345345
set(id).equalToWhenPresent(record::id)
346346
set(firstName).equalToWhenPresent(record::firstName)
@@ -356,7 +356,7 @@ This method will selectively set values if corresponding fields in a record are
356356

357357
```kotlin
358358
val rows = mapper.update {
359-
setSelective(updateRecord)
359+
updateSelective(updateRecord)
360360
where(id, isEqualTo(100))
361361
}
362362
```

src/site/markdown/docs/mybatis3.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ int rows = mapper.update(c ->
244244
It is also possible to write a utility method that will set values. For example:
245245

246246
```java
247-
static UpdateDSL<UpdateModel> setSelective(PersonRecord record,
247+
static UpdateDSL<UpdateModel> updateSelective(PersonRecord record,
248248
UpdateDSL<UpdateModel> dsl) {
249249
return dsl.set(id).equalToWhenPresent(record::getId)
250250
.set(firstName).equalToWhenPresent(record::getFirstName)
@@ -259,7 +259,7 @@ This method will selectively set values if corresponding fields in a record are
259259

260260
```java
261261
rows = mapper.update(h ->
262-
setSelective(updateRecord, h)
262+
updateSelective(updateRecord, h)
263263
.where(id, isEqualTo(100)));
264264
```
265265

src/test/java/examples/simple/PersonMapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ default int update(UpdateDSLCompleter completer) {
166166
return MyBatis3Utils.update(this::update, person, completer);
167167
}
168168

169-
static UpdateDSL<UpdateModel> setAll(PersonRecord record,
169+
static UpdateDSL<UpdateModel> updateAll(PersonRecord record,
170170
UpdateDSL<UpdateModel> dsl) {
171171
return dsl.set(id).equalTo(record::getId)
172172
.set(firstName).equalTo(record::getFirstName)
@@ -177,7 +177,7 @@ static UpdateDSL<UpdateModel> setAll(PersonRecord record,
177177
.set(addressId).equalTo(record::getAddressId);
178178
}
179179

180-
static UpdateDSL<UpdateModel> setSelective(PersonRecord record,
180+
static UpdateDSL<UpdateModel> updateSelective(PersonRecord record,
181181
UpdateDSL<UpdateModel> dsl) {
182182
return dsl.set(id).equalToWhenPresent(record::getId)
183183
.set(firstName).equalToWhenPresent(record::getFirstName)

src/test/java/examples/simple/PersonMapperTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ public void testUpdate() {
335335
record.setOccupation("Programmer");
336336

337337
rows = mapper.update(c ->
338-
PersonMapper.setAll(record, c)
338+
PersonMapper.updateAll(record, c)
339339
.where(id, isEqualTo(100))
340340
.and(firstName, isEqualTo("Joe")));
341341

@@ -394,7 +394,7 @@ public void testUpdateAll() {
394394
PersonRecord updateRecord = new PersonRecord();
395395
updateRecord.setOccupation("Programmer");
396396
rows = mapper.update(c ->
397-
PersonMapper.setSelective(updateRecord, c));
397+
PersonMapper.updateSelective(updateRecord, c));
398398

399399
assertThat(rows).isEqualTo(7);
400400

@@ -423,7 +423,7 @@ public void testUpdateSelective() {
423423
PersonRecord updateRecord = new PersonRecord();
424424
updateRecord.setOccupation("Programmer");
425425
rows = mapper.update(c ->
426-
PersonMapper.setSelective(updateRecord, c)
426+
PersonMapper.updateSelective(updateRecord, c)
427427
.where(id, isEqualTo(100)));
428428

429429
assertThat(rows).isEqualTo(1);

src/test/kotlin/examples/kotlin/canonical/PersonMapperExtensions.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ fun PersonMapper.selectByPrimaryKey(id_: Int) =
9797
fun PersonMapper.update(completer: UpdateCompleter) =
9898
MyBatis3Utils.update(this::update, Person, completer)
9999

100-
fun UpdateDSL<UpdateModel>.setAll(record: PersonRecord) =
100+
fun UpdateDSL<UpdateModel>.updateAll(record: PersonRecord) =
101101
apply {
102102
set(id).equalTo(record::id)
103103
set(firstName).equalTo(record::firstName)
@@ -108,7 +108,7 @@ fun UpdateDSL<UpdateModel>.setAll(record: PersonRecord) =
108108
set(addressId).equalTo(record::addressId)
109109
}
110110

111-
fun UpdateDSL<UpdateModel>.setSelective(record: PersonRecord) =
111+
fun UpdateDSL<UpdateModel>.updateSelective(record: PersonRecord) =
112112
apply {
113113
set(id).equalToWhenPresent(record::id)
114114
set(firstName).equalToWhenPresent(record::firstName)

src/test/kotlin/examples/kotlin/canonical/PersonMapperTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ class PersonMapperTest {
275275
record.occupation = "Programmer"
276276

277277
rows = mapper.update {
278-
setAll(record)
278+
updateAll(record)
279279
where(id, isEqualTo(100))
280280
and(firstName, isEqualTo("Joe"))
281281
}
@@ -322,7 +322,7 @@ class PersonMapperTest {
322322
val updateRecord = PersonRecord(occupation = "Programmer")
323323

324324
rows = mapper.update {
325-
setSelective(updateRecord)
325+
updateSelective(updateRecord)
326326
}
327327

328328
assertThat(rows).isEqualTo(7)
@@ -345,7 +345,7 @@ class PersonMapperTest {
345345
val updateRecord = PersonRecord(occupation = "Programmer")
346346

347347
rows = mapper.update {
348-
setSelective(updateRecord)
348+
updateSelective(updateRecord)
349349
where(id, isEqualTo(100))
350350
}
351351

0 commit comments

Comments
 (0)