Skip to content

Commit a828741

Browse files
authored
Merge pull request #988 from jeffgbutler/flakey-tests
Fix a few more potentially flakey tests
2 parents 1901835 + 02fce4b commit a828741

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

src/test/java/examples/simple/PersonMapperTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -957,6 +957,6 @@ void gh737() {
957957
"where id = #{parameters.p2,jdbcType=INTEGER}";
958958

959959
assertThat(updateStatement.getUpdateStatement()).isEqualTo(expected);
960-
assertThat(updateStatement.getParameters()).containsExactly(entry("p1", 4), entry("p2", 5));
960+
assertThat(updateStatement.getParameters()).containsOnly(entry("p1", 4), entry("p2", 5));
961961
}
962962
}

src/test/java/examples/type_conversion/TypeConversionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ void testFunctionInSelect() {
9393
.render(RenderingStrategies.MYBATIS3);
9494

9595
Map<String, Object> row = mapper.selectOneMappedRow(selectStatement);
96-
assertThat(row).containsExactly(entry("FILE_ID", 1), entry("FILE_CONTENTS", randomBlob));
96+
assertThat(row).containsOnly(entry("FILE_ID", 1), entry("FILE_CONTENTS", randomBlob));
9797

9898
selectStatement = select(fileId, toBase64(fileContents).as("checksum"))
9999
.from(myfiles)

src/test/java/org/mybatis/dynamic/sql/util/FragmentCollectorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,6 @@ void testWhereFragmentCollectorMerge() {
4141
fc1.merge(fc2);
4242

4343
assertThat(fc1.collectFragments(Collectors.joining(","))).isEqualTo(":p1,:p2");
44-
assertThat(fc1.parameters()).containsExactly(entry("p1", 1), entry("p2", 2));
44+
assertThat(fc1.parameters()).containsOnly(entry("p1", 1), entry("p2", 2));
4545
}
4646
}

src/test/java/org/mybatis/dynamic/sql/where/render/OptionalCriterionRenderTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ void testOverrideFirstConnector() {
143143
.render(RenderingStrategies.SPRING_NAMED_PARAMETER);
144144

145145
assertThat(whereClause).hasValueSatisfying(wc -> {
146-
assertThat(wc.getParameters()).containsExactly(entry("p1", "fred"), entry("p2", "flintstone"));
146+
assertThat(wc.getParameters()).containsOnly(entry("p1", "fred"), entry("p2", "flintstone"));
147147
assertThat(wc.getWhereClause()).isEqualTo("where first_name = :p1 or last_name = :p2");
148148
});
149149
}
@@ -185,7 +185,7 @@ void testWhereExistsOr() {
185185
"or exists (select * from person where id = :p2)";
186186

187187
assertThat(whereClause).hasValueSatisfying(wc -> {
188-
assertThat(wc.getParameters()).containsExactly(entry("p1", 3), entry("p2", 4));
188+
assertThat(wc.getParameters()).containsOnly(entry("p1", 3), entry("p2", 4));
189189
assertThat(wc.getWhereClause()).isEqualTo(expected);
190190
});
191191
}
@@ -217,7 +217,7 @@ void testWhereExistsOrOr() {
217217
"or exists (select * from person where id = :p3))";
218218

219219
assertThat(whereClause).hasValueSatisfying(wc -> {
220-
assertThat(wc.getParameters()).containsExactly(entry("p1", 3), entry("p2", 4), entry("p3", 5));
220+
assertThat(wc.getParameters()).containsOnly(entry("p1", 3), entry("p2", 4), entry("p3", 5));
221221
assertThat(wc.getWhereClause()).isEqualTo(expected);
222222
});
223223
}
@@ -242,7 +242,7 @@ void testWhereExistsAnd() {
242242
"and exists (select * from person where id = :p2)";
243243

244244
assertThat(whereClause).hasValueSatisfying(wc -> {
245-
assertThat(wc.getParameters()).containsExactly(entry("p1", 3), entry("p2", 4));
245+
assertThat(wc.getParameters()).containsOnly(entry("p1", 3), entry("p2", 4));
246246
assertThat(wc.getWhereClause()).isEqualTo(expected);
247247
});
248248
}
@@ -274,7 +274,7 @@ void testWhereExistsAndAnd() {
274274
"and exists (select * from person where id = :p3))";
275275

276276
assertThat(whereClause).hasValueSatisfying(wc -> {
277-
assertThat(wc.getParameters()).containsExactly(entry("p1", 3), entry("p2", 4), entry("p3", 5));
277+
assertThat(wc.getParameters()).containsOnly(entry("p1", 3), entry("p2", 4), entry("p3", 5));
278278
assertThat(wc.getWhereClause()).isEqualTo(expected);
279279
});
280280
}
@@ -315,7 +315,7 @@ void testCollapsingCriteriaGroup3() {
315315
String expected = "where first_name = :p1 or first_name = :p2";
316316

317317
assertThat(whereClause).hasValueSatisfying(wc -> {
318-
assertThat(wc.getParameters()).containsExactly(entry("p1", "Fred"), entry("p2", "Betty"));
318+
assertThat(wc.getParameters()).containsOnly(entry("p1", "Fred"), entry("p2", "Betty"));
319319
assertThat(wc.getWhereClause()).isEqualTo(expected);
320320
});
321321
}

src/test/kotlin/examples/kotlin/spring/canonical/KotlinElementsTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -672,6 +672,6 @@ open class KotlinElementsTest {
672672
assertThat(updateStatement.updateStatement).isEqualTo(
673673
"update Person set address_id = (address_id + :p1) where id = :p2"
674674
)
675-
assertThat(updateStatement.parameters).containsExactly(entry("p1", 4), entry("p2", 5))
675+
assertThat(updateStatement.parameters).containsOnly(entry("p1", 4), entry("p2", 5))
676676
}
677677
}

0 commit comments

Comments
 (0)