Skip to content

Commit ada5f03

Browse files
committed
Only the finishers are buildable
1 parent 99703ff commit ada5f03

File tree

2 files changed

+7
-19
lines changed

2 files changed

+7
-19
lines changed

src/main/java/org/mybatis/dynamic/sql/select/HavingDSL.java

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919
import org.mybatis.dynamic.sql.CriteriaGroup;
2020
import org.mybatis.dynamic.sql.util.Buildable;
2121

22-
public class HavingDSL extends AbstractHavingStarter <HavingDSL.StandaloneHavingFinisher>
23-
implements Buildable<HavingModel> {
22+
public class HavingDSL extends AbstractHavingStarter <HavingDSL.StandaloneHavingFinisher> {
2423
private StandaloneHavingFinisher havingFinisher;
2524

2625
@Override
@@ -32,15 +31,11 @@ protected StandaloneHavingFinisher having() {
3231
return havingFinisher;
3332
}
3433

35-
@NotNull
36-
@Override
37-
public HavingModel build() {
38-
return havingFinisher.buildModel();
39-
}
40-
41-
public class StandaloneHavingFinisher extends AbstractHavingFinisher<StandaloneHavingFinisher>
34+
public static class StandaloneHavingFinisher extends AbstractHavingFinisher<StandaloneHavingFinisher>
4235
implements Buildable<HavingModel> {
4336

37+
private StandaloneHavingFinisher() {}
38+
4439
@Override
4540
protected StandaloneHavingFinisher getThis() {
4641
return this;
@@ -49,7 +44,7 @@ protected StandaloneHavingFinisher getThis() {
4944
@NotNull
5045
@Override
5146
public HavingModel build() {
52-
return HavingDSL.this.build();
47+
return buildModel();
5348
}
5449

5550
public HavingApplier toHavingApplier() {

src/main/java/org/mybatis/dynamic/sql/where/WhereDSL.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222
import org.mybatis.dynamic.sql.configuration.StatementConfiguration;
2323
import org.mybatis.dynamic.sql.util.Buildable;
2424

25-
public class WhereDSL extends AbstractWhereStarter<WhereDSL.StandaloneWhereFinisher, WhereDSL>
26-
implements Buildable<WhereModel> {
25+
public class WhereDSL extends AbstractWhereStarter<WhereDSL.StandaloneWhereFinisher, WhereDSL> {
2726
private StandaloneWhereFinisher whereBuilder;
2827
private final StatementConfiguration statementConfiguration = new StatementConfiguration();
2928

@@ -37,12 +36,6 @@ public StandaloneWhereFinisher where() {
3736
return whereBuilder;
3837
}
3938

40-
@NotNull
41-
@Override
42-
public WhereModel build() {
43-
return whereBuilder.buildModel();
44-
}
45-
4639
@Override
4740
public WhereDSL configureStatement(Consumer<StatementConfiguration> consumer) {
4841
consumer.accept(statementConfiguration);
@@ -63,7 +56,7 @@ protected StandaloneWhereFinisher getThis() {
6356
@NotNull
6457
@Override
6558
public WhereModel build() {
66-
return WhereDSL.this.build();
59+
return buildModel();
6760
}
6861

6962
public WhereApplier toWhereApplier() {

0 commit comments

Comments
 (0)