Merge pull request #283 from jeffgbutler/sonar-updates

Updates from Sonar Suggestions

Author: jeffgbutler

pom.xml

@@ -230,6 +230,12 @@
       <version>${junit.jupiter.version}</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter-params</artifactId>
+      <version>${junit.jupiter.version}</version>
+      <scope>test</scope>
+    </dependency>
     <dependency>
       <groupId>org.junit.platform</groupId>
       <artifactId>junit-platform-launcher</artifactId>

src/main/java/org/mybatis/dynamic/sql/insert/render/AbstractMultiRowValuePhraseVisitor.java

@@ -28,7 +28,7 @@ public abstract class AbstractMultiRowValuePhraseVisitor extends MultiRowInsertM
     protected final RenderingStrategy renderingStrategy;
     protected final String prefix;
 
-    public AbstractMultiRowValuePhraseVisitor(RenderingStrategy renderingStrategy, String prefix) {
+    protected AbstractMultiRowValuePhraseVisitor(RenderingStrategy renderingStrategy, String prefix) {
         this.renderingStrategy = renderingStrategy;
         this.prefix = prefix;
     }

src/main/java/org/mybatis/dynamic/sql/select/join/JoinCondition.java

@@ -20,7 +20,7 @@
 public abstract class JoinCondition {
     private final BasicColumn rightColumn;
 
-    public JoinCondition(BasicColumn rightColumn) {
+    protected JoinCondition(BasicColumn rightColumn) {
         this.rightColumn = rightColumn;
     }
 

src/main/kotlin/org/mybatis/dynamic/sql/util/kotlin/KotlinInsertHelpers.kt

@@ -33,4 +33,5 @@ typealias MultiRowInsertCompleter<T> = @MyBatisDslMarker MultiRowInsertDSL<T>.()
 
 typealias BatchInsertCompleter<T> = @MyBatisDslMarker BatchInsertDSL<T>.() -> Buildable<BatchInsertModel<T>>
 
-typealias InsertSelectCompleter = @MyBatisDslMarker KotlinInsertSelectSubQueryBuilder.() -> KotlinInsertSelectSubQueryBuilder
+typealias InsertSelectCompleter =
+        @MyBatisDslMarker KotlinInsertSelectSubQueryBuilder.() -> KotlinInsertSelectSubQueryBuilder