Skip to content

Commit ca7d55b

Browse files
committed
Remove Buildable from the base class
We'll want to use this class for the union builder, but we won't implement builder in that class
1 parent aba2e6e commit ca7d55b

File tree

5 files changed

+6
-7
lines changed

5 files changed

+6
-7
lines changed

src/main/kotlin/org/mybatis/dynamic/sql/util/kotlin/KotlinBaseBuilders.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,9 @@ import org.mybatis.dynamic.sql.SqlTable
2020
import org.mybatis.dynamic.sql.VisitableCondition
2121
import org.mybatis.dynamic.sql.select.AbstractQueryExpressionDSL
2222
import org.mybatis.dynamic.sql.select.SelectModel
23-
import org.mybatis.dynamic.sql.util.Buildable
2423
import org.mybatis.dynamic.sql.where.AbstractWhereDSL
2524

26-
abstract class KotlinBaseBuilder<M, W : AbstractWhereDSL<W>, B : KotlinBaseBuilder<M, W, B>> : Buildable<M> {
25+
abstract class KotlinBaseBuilder<W : AbstractWhereDSL<W>, B : KotlinBaseBuilder<W, B>> {
2726
fun <T> where(column: BindableColumn<T>, condition: VisitableCondition<T>): B =
2827
applySelf {
2928
getWhere().where(column, condition)
@@ -69,7 +68,7 @@ abstract class KotlinBaseBuilder<M, W : AbstractWhereDSL<W>, B : KotlinBaseBuild
6968

7069
abstract class KotlinBaseJoiningBuilder<T : AbstractQueryExpressionDSL<T, SelectModel>, W : AbstractWhereDSL<W>, B : KotlinBaseJoiningBuilder<T, W, B>>(
7170
private val dsl: AbstractQueryExpressionDSL<T, SelectModel>
72-
) : KotlinBaseBuilder<SelectModel, W, B>() {
71+
) : KotlinBaseBuilder<W, B>() {
7372

7473
fun join(table: SqlTable, receiver: JoinReceiver): B =
7574
applySelf {

src/main/kotlin/org/mybatis/dynamic/sql/util/kotlin/KotlinCountBuilder.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import org.mybatis.dynamic.sql.util.Buildable
2222
typealias CountCompleter = KotlinCountBuilder.() -> Buildable<SelectModel>
2323

2424
class KotlinCountBuilder(private val dsl: CountDSL<SelectModel>) :
25-
KotlinBaseJoiningBuilder<CountDSL<SelectModel>, CountDSL<SelectModel>.CountWhereBuilder, KotlinCountBuilder>(dsl) {
25+
KotlinBaseJoiningBuilder<CountDSL<SelectModel>, CountDSL<SelectModel>.CountWhereBuilder, KotlinCountBuilder>(dsl), Buildable<SelectModel> {
2626

2727
fun allRows() = this
2828

src/main/kotlin/org/mybatis/dynamic/sql/util/kotlin/KotlinDeleteBuilder.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import org.mybatis.dynamic.sql.util.Buildable
2222
typealias DeleteCompleter = KotlinDeleteBuilder.() -> Buildable<DeleteModel>
2323

2424
class KotlinDeleteBuilder(private val dsl: DeleteDSL<DeleteModel>) :
25-
KotlinBaseBuilder<DeleteModel, DeleteDSL<DeleteModel>.DeleteWhereBuilder, KotlinDeleteBuilder>() {
25+
KotlinBaseBuilder<DeleteDSL<DeleteModel>.DeleteWhereBuilder, KotlinDeleteBuilder>(), Buildable<DeleteModel> {
2626

2727
fun allRows() = this
2828

src/main/kotlin/org/mybatis/dynamic/sql/util/kotlin/KotlinQueryBuilder.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import org.mybatis.dynamic.sql.util.Buildable
2424
typealias SelectCompleter = KotlinQueryBuilder.() -> Buildable<SelectModel>
2525

2626
class KotlinQueryBuilder(private val dsl: QueryExpressionDSL<SelectModel>) :
27-
KotlinBaseJoiningBuilder<QueryExpressionDSL<SelectModel>, QueryExpressionDSL<SelectModel>.QueryExpressionWhereBuilder, KotlinQueryBuilder>(dsl) {
27+
KotlinBaseJoiningBuilder<QueryExpressionDSL<SelectModel>, QueryExpressionDSL<SelectModel>.QueryExpressionWhereBuilder, KotlinQueryBuilder>(dsl), Buildable<SelectModel> {
2828

2929
fun groupBy(vararg columns: BasicColumn) =
3030
apply {

src/main/kotlin/org/mybatis/dynamic/sql/util/kotlin/KotlinUpdateBuilder.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ typealias MultiRowInsertCompleter<T> = MultiRowInsertDSL<T>.() -> MultiRowInsert
3333
typealias UpdateCompleter = KotlinUpdateBuilder.() -> Buildable<UpdateModel>
3434

3535
class KotlinUpdateBuilder(private val dsl: UpdateDSL<UpdateModel>) :
36-
KotlinBaseBuilder<UpdateModel, UpdateDSL<UpdateModel>.UpdateWhereBuilder, KotlinUpdateBuilder>() {
36+
KotlinBaseBuilder<UpdateDSL<UpdateModel>.UpdateWhereBuilder, KotlinUpdateBuilder>(), Buildable<UpdateModel> {
3737

3838
fun <T> set(column: SqlColumn<T>): UpdateDSL<UpdateModel>.SetClauseFinisher<T> = dsl.set(column)
3939

0 commit comments

Comments
 (0)