Skip to content

Commit f948c86

Browse files
committed
Use a built-in utility rather than our custom one
1 parent a645046 commit f948c86

File tree

5 files changed

+5
-14
lines changed

5 files changed

+5
-14
lines changed

src/main/java/org/mybatis/dynamic/sql/delete/DeleteDSL.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import org.mybatis.dynamic.sql.common.OrderByModel;
2828
import org.mybatis.dynamic.sql.configuration.StatementConfiguration;
2929
import org.mybatis.dynamic.sql.util.Buildable;
30-
import org.mybatis.dynamic.sql.util.Utilities;
3130
import org.mybatis.dynamic.sql.where.AbstractWhereFinisher;
3231
import org.mybatis.dynamic.sql.where.AbstractWhereStarter;
3332
import org.mybatis.dynamic.sql.where.EmbeddedWhereModel;
@@ -51,7 +50,7 @@ private DeleteDSL(SqlTable table, @Nullable String tableAlias, Function<DeleteMo
5150

5251
@Override
5352
public DeleteWhereBuilder where() {
54-
whereBuilder = Utilities.buildIfNecessary(whereBuilder, DeleteWhereBuilder::new);
53+
whereBuilder = Objects.requireNonNullElseGet(whereBuilder, DeleteWhereBuilder::new);
5554
return whereBuilder;
5655
}
5756

src/main/java/org/mybatis/dynamic/sql/select/CountDSL.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import org.mybatis.dynamic.sql.SqlTable;
2626
import org.mybatis.dynamic.sql.configuration.StatementConfiguration;
2727
import org.mybatis.dynamic.sql.util.Buildable;
28-
import org.mybatis.dynamic.sql.util.Utilities;
2928
import org.mybatis.dynamic.sql.where.AbstractWhereFinisher;
3029
import org.mybatis.dynamic.sql.where.EmbeddedWhereModel;
3130

@@ -54,7 +53,7 @@ private CountDSL(BasicColumn countColumn, SqlTable table, Function<SelectModel,
5453

5554
@Override
5655
public CountWhereBuilder where() {
57-
whereBuilder = Utilities.buildIfNecessary(whereBuilder, CountWhereBuilder::new);
56+
whereBuilder = Objects.requireNonNullElseGet(whereBuilder, CountWhereBuilder::new);
5857
return whereBuilder;
5958
}
6059

src/main/java/org/mybatis/dynamic/sql/select/QueryExpressionDSL.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
import org.mybatis.dynamic.sql.select.join.JoinSpecification;
3838
import org.mybatis.dynamic.sql.select.join.JoinType;
3939
import org.mybatis.dynamic.sql.util.Buildable;
40-
import org.mybatis.dynamic.sql.util.Utilities;
4140
import org.mybatis.dynamic.sql.where.AbstractWhereFinisher;
4241
import org.mybatis.dynamic.sql.where.AbstractWhereStarter;
4342
import org.mybatis.dynamic.sql.where.EmbeddedWhereModel;
@@ -70,7 +69,7 @@ protected QueryExpressionDSL(FromGatherer<R> fromGatherer, SqlTable table, Strin
7069

7170
@Override
7271
public QueryExpressionWhereBuilder where() {
73-
whereBuilder = Utilities.buildIfNecessary(whereBuilder, QueryExpressionWhereBuilder::new);
72+
whereBuilder = Objects.requireNonNullElseGet(whereBuilder, QueryExpressionWhereBuilder::new);
7473
return whereBuilder;
7574
}
7675

@@ -86,7 +85,7 @@ public QueryExpressionDSL<R> configureStatement(Consumer<StatementConfiguration>
8685
* @return The having builder
8786
*/
8887
protected QueryExpressionHavingBuilder having() {
89-
havingBuilder = Utilities.buildIfNecessary(havingBuilder, QueryExpressionHavingBuilder::new);
88+
havingBuilder = Objects.requireNonNullElseGet(havingBuilder, QueryExpressionHavingBuilder::new);
9089
return havingBuilder;
9190
}
9291

src/main/java/org/mybatis/dynamic/sql/update/UpdateDSL.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import org.mybatis.dynamic.sql.util.NullMapping;
4040
import org.mybatis.dynamic.sql.util.SelectMapping;
4141
import org.mybatis.dynamic.sql.util.StringConstantMapping;
42-
import org.mybatis.dynamic.sql.util.Utilities;
4342
import org.mybatis.dynamic.sql.util.ValueMapping;
4443
import org.mybatis.dynamic.sql.util.ValueOrNullMapping;
4544
import org.mybatis.dynamic.sql.util.ValueWhenPresentMapping;
@@ -71,7 +70,7 @@ public <T> SetClauseFinisher<T> set(SqlColumn<T> column) {
7170

7271
@Override
7372
public UpdateWhereBuilder where() {
74-
whereBuilder = Utilities.buildIfNecessary(whereBuilder, UpdateWhereBuilder::new);
73+
whereBuilder = Objects.requireNonNullElseGet(whereBuilder, UpdateWhereBuilder::new);
7574
return whereBuilder;
7675
}
7776

src/main/java/org/mybatis/dynamic/sql/util/Utilities.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,12 @@
1717

1818
import java.util.Collection;
1919
import java.util.Objects;
20-
import java.util.function.Supplier;
2120
import java.util.stream.Stream;
2221

2322
import org.jspecify.annotations.NonNull;
2423
import org.jspecify.annotations.Nullable;
2524

2625
public interface Utilities {
27-
static <T> T buildIfNecessary(@Nullable T current, @NonNull Supplier<T> builder) {
28-
return current == null ? builder.get() : current;
29-
}
30-
3126
static long safelyUnbox(@Nullable Long l) {
3227
return l == null ? 0 : l;
3328
}

0 commit comments

Comments
 (0)