Failing test for order by collections

Author: jeffgbutler

src/test/java/examples/simple/PersonMapperTest.java

@@ -25,6 +25,7 @@
 import org.apache.ibatis.transaction.jdbc.JdbcTransactionFactory;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.mybatis.dynamic.sql.SortSpecification;
 import org.mybatis.dynamic.sql.delete.DeleteDSLCompleter;
 import org.mybatis.dynamic.sql.delete.render.DeleteStatementProvider;
 import org.mybatis.dynamic.sql.insert.render.GeneralInsertStatementProvider;
@@ -38,6 +39,7 @@
 import java.sql.Connection;
 import java.sql.DriverManager;
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.Date;
 import java.util.List;
 import java.util.Objects;
@@ -251,6 +253,25 @@ void testFirstNameIn() {
         }
     }
 
+    @Test
+    void testOrderByCollection() {
+        Collection<SortSpecification> orderByColumns = new ArrayList<>();
+        orderByColumns.add(firstName);
+
+        try (SqlSession session = sqlSessionFactory.openSession()) {
+            PersonMapper mapper = session.getMapper(PersonMapper.class);
+
+            List<PersonRecord> rows = mapper.select(c -> c
+                    .where(firstName, isIn("Fred", "Barney"))
+                    .orderBy(orderByColumns)
+            );
+
+            assertThat(rows).hasSize(2);
+            assertThat(rows.get(0).getLastName().getName()).isEqualTo("Flintstone");
+            assertThat(rows.get(1).getLastName().getName()).isEqualTo("Rubble");
+        }
+    }
+
     @Test
     void testDelete() {
         try (SqlSession session = sqlSessionFactory.openSession()) {

src/test/java/org/mybatis/dynamic/sql/select/SelectStatementTest.java

@@ -194,8 +194,6 @@ void testOrderByMultipleColumnsWithCollection() {
                 + "from foo a "
                 + "order by column2 DESC, column1";
 
-        Map<String, Object> parameters = selectStatement.getParameters();
-
         assertThat(selectStatement.getSelectStatement()).isEqualTo(expectedFullStatement);
     }