Skip to content

Commit bf8c422

Browse files
authored
Merge pull request #163 from kazuki43zoo/defensive-null
Add null-check for configurationProperty on SqlSessionFactoryBean
2 parents 3c17c64 + 621b793 commit bf8c422

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/main/java/org/mybatis/spring/SqlSessionFactoryBean.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,9 @@ protected SqlSessionFactory buildSqlSessionFactory() throws IOException {
410410
LOGGER.debug("Property `configuration` or 'configLocation' not specified, using default MyBatis Configuration");
411411
}
412412
configuration = new Configuration();
413-
configuration.setVariables(this.configurationProperties);
413+
if (this.configurationProperties != null) {
414+
configuration.setVariables(this.configurationProperties);
415+
}
414416
}
415417

416418
if (this.objectFactory != null) {

src/test/java/org/mybatis/spring/SqlSessionFactoryBeanTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,7 @@ public void testAddCache() {
406406
private void assertDefaultConfig(SqlSessionFactory factory) {
407407
assertConfig(factory, SqlSessionFactoryBean.class.getSimpleName(),
408408
org.mybatis.spring.transaction.SpringManagedTransactionFactory.class);
409+
assertEquals(0, factory.getConfiguration().getVariables().size());
409410
}
410411

411412
private void assertConfig(SqlSessionFactory factory, Class<? extends TransactionFactory> transactionFactoryClass) {

0 commit comments

Comments
 (0)