Fix spl_object_hash collision by segmenting hash db with class name
#200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an issue today at work with DeepCopy 1.11.1 which seems to be related to #180. It took me quite a good amount of time to figure this out but I hit the same problem.
There will probably never be two hashes similar for the same class but evidence from my environment shows there CAN be similar hashes across different classes.
The solution is simple, segment the hash database in memory with a class name and the problem goes away. Simple and efficient.
I did not add tests as there is not easy way to reproduce this and the hash provider we use is not a dependency we can inject.