Merge pull request saltstack-formulas#150 from eole/bugfix/libtofs-crash-on-files_switch-lookup-list

Bugfix/libtofs crash on files switch lookup list

Author: myii

kitchen.yml

@@ -124,8 +124,10 @@ provisioner:
       base:
         '*':
           - template
+          - define_roles
   pillars_from_files:
     template.sls: pillar.example
+    define_roles.sls: test/salt/pillar/define_roles.sls
 
 verifier:
   # https://www.inspec.io/

pillar.example

@@ -33,6 +33,7 @@ template:
     files_switch:
       - any/path/can/be/used/here
       - id
+      - roles
       - osfinger
       - os
       - os_family

template/libtofs.jinja

@@ -83,18 +83,25 @@
     {%- for fs in fsl %}
       {%- for src_file in src_files %}
         {%- if fs %}
-          {%- set fs_dir = salt['config.get'](fs, fs) %}
+          {%- set fs_dirs = salt['config.get'](fs, fs) %}
         {%- else %}
-          {%- set fs_dir = salt['config.get'](tplroot ~ ':tofs:dirs:default', 'default') %}
+          {%- set fs_dirs = salt['config.get'](tplroot ~ ':tofs:dirs:default', 'default') %}
         {%- endif %}
-        {%- set url = [
-            '- salt:/',
-            path_prefix_inc_ext.strip('/'),
-            files_dir.strip('/'),
-            fs_dir.strip('/'),
-            src_file.strip('/'),
-        ] | select | join('/') %}
+        {#- Force the `config.get` lookup result as a list where necessary #}
+        {#- since we need to also handle grains that are lists #}
+        {%- if fs_dirs is string %}
+          {%- set fs_dirs = [fs_dirs] %}
+        {%- endif %}
+        {%- for fs_dir in fs_dirs %}
+          {%- set url = [
+              '- salt:/',
+              path_prefix_inc_ext.strip('/'),
+              files_dir.strip('/'),
+              fs_dir.strip('/'),
+              src_file.strip('/'),
+          ] | select | join('/') %}
 {{ url | indent(indent_width, true) }}
+        {%- endfor %}
       {%- endfor %}
     {%- endfor %}
   {%- endfor %}

test/integration/default/controls/config_spec.rb

@@ -14,7 +14,7 @@
     its('content') { should include '"lookup": {"added_in_lookup": "lookup_value",' }
     its('content') { should include '"pkg": {"name": "' }
     its('content') { should include '"service": {"name": "' }
-    its('content') { should include '"tofs": {"files_switch": ["any/path/can/be/used/here", "id", "osfinger", "os", "os_family"], "source_files": {"template-config-file-file-managed": ["example.tmpl.jinja"]}' }
+    its('content') { should include '"tofs": {"files_switch": ["any/path/can/be/used/here", "id", "roles", "osfinger", "os", "os_family"], "source_files": {"template-config-file-file-managed": ["example.tmpl.jinja"]}' }
     its('content') { should include '"winner": "pillar"}' }
     its('content') { should include 'winner of the merge: pillar' }
   end

test/salt/pillar/define_roles.sls

@@ -0,0 +1,4 @@
+# libtofs.jinja must work with tofs.files_switch looked up list
+roles:
+  - foo
+  - bar