Skip to content

Commit 2e4dd14

Browse files
authored
Merge pull request #33 from tryflux/token_reuse
Allow refresh token reuse
2 parents 7358cf2 + 3aa2731 commit 2e4dd14

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

oauth2-server-core/src/main/java/nl/myndocs/oauth2/Oauth2TokenService.kt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,7 @@ class Oauth2TokenService(
143143
refreshToken.username,
144144
refreshToken.clientId,
145145
refreshToken.scopes,
146-
refreshTokenConverter.convertToToken(
147-
refreshToken.username,
148-
refreshToken.clientId,
149-
refreshToken.scopes
150-
)
146+
refreshTokenConverter.convertToToken(refreshToken)
151147
)
152148

153149
tokenStore.storeAccessToken(accessToken)

oauth2-server-core/src/main/java/nl/myndocs/oauth2/token/converter/RefreshTokenConverter.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@ package nl.myndocs.oauth2.token.converter
33
import nl.myndocs.oauth2.token.RefreshToken
44

55
interface RefreshTokenConverter {
6+
fun convertToToken(refreshToken: RefreshToken): RefreshToken = convertToToken(refreshToken.username, refreshToken.clientId, refreshToken.scopes)
67
fun convertToToken(username: String, clientId: String, requestedScopes: Set<String>): RefreshToken
78
}

oauth2-server-core/src/test/java/nl/myndocs/oauth2/RefreshTokenGrantTokenServiceTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ internal class RefreshTokenGrantTokenServiceTest {
6969
every { clientService.validClient(client, clientSecret) } returns true
7070
every { tokenStore.refreshToken(refreshToken) } returns token
7171
every { identityService.identityOf(client, username) } returns identity
72-
every { refreshTokenConverter.convertToToken(username, clientId, scopes) } returns newRefreshToken
72+
every { refreshTokenConverter.convertToToken(token) } returns newRefreshToken
7373
every { accessTokenConverter.convertToToken(username, clientId, scopes, newRefreshToken) } returns accessToken
7474

7575
tokenService.refresh(refreshTokenRequest)

0 commit comments

Comments
 (0)