Skip to content

Commit 8b84bdc

Browse files
committed
Remove not used interface
1 parent 131990f commit 8b84bdc

File tree

6 files changed

+23
-21
lines changed

6 files changed

+23
-21
lines changed

kotlin-oauth2-server-core/src/main/java/nl/myndocs/oauth2/TokenService.kt

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,14 @@ import nl.myndocs.oauth2.token.CodeToken
1414
import nl.myndocs.oauth2.token.TokenStore
1515
import nl.myndocs.oauth2.token.converter.AccessTokenConverter
1616
import nl.myndocs.oauth2.token.converter.CodeTokenConverter
17+
import nl.myndocs.oauth2.token.converter.RefreshTokenConverter
1718

1819
class TokenService(
1920
private val identityService: IdentityService,
2021
private val clientService: ClientService,
2122
private val tokenStore: TokenStore,
2223
private val accessTokenConverter: AccessTokenConverter,
24+
private val refreshTokenConverter: RefreshTokenConverter,
2325
private val codeTokenConverter: CodeTokenConverter
2426
) {
2527
/**
@@ -57,7 +59,12 @@ class TokenService(
5759
val accessToken = accessTokenConverter.convertToToken(
5860
requestedIdentity.username,
5961
requestedClient.clientId,
60-
requestedScopes
62+
requestedScopes,
63+
refreshTokenConverter.convertToToken(
64+
requestedIdentity.username,
65+
requestedClient.clientId,
66+
requestedScopes
67+
)
6168
)
6269

6370
tokenStore.storeAccessToken(accessToken)
@@ -79,7 +86,12 @@ class TokenService(
7986
val accessToken = accessTokenConverter.convertToToken(
8087
consumeCodeToken.username,
8188
consumeCodeToken.clientId,
82-
consumeCodeToken.scopes
89+
consumeCodeToken.scopes,
90+
refreshTokenConverter.convertToToken(
91+
consumeCodeToken.username,
92+
consumeCodeToken.clientId,
93+
consumeCodeToken.scopes
94+
)
8395
)
8496

8597
tokenStore.storeAccessToken(accessToken)

kotlin-oauth2-server-core/src/main/java/nl/myndocs/oauth2/token/converter/AccessTokenConverter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ package nl.myndocs.oauth2.token.converter
33
import nl.myndocs.oauth2.token.AccessToken
44
import nl.myndocs.oauth2.token.RefreshToken
55

6-
interface AccessTokenConverter : TokenConverter<AccessToken> {
6+
interface AccessTokenConverter {
77
fun convertToToken(username: String, clientId: String, requestedScopes: Set<String>, refreshToken: RefreshToken?): AccessToken
88
}

kotlin-oauth2-server-core/src/main/java/nl/myndocs/oauth2/token/converter/RefreshTokenConverter.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,6 @@ package nl.myndocs.oauth2.token.converter
22

33
import nl.myndocs.oauth2.token.RefreshToken
44

5-
interface RefreshTokenConverter : TokenConverter<RefreshToken>
5+
interface RefreshTokenConverter {
6+
fun convertToToken(username: String, clientId: String, requestedScopes: Set<String>): RefreshToken
7+
}

kotlin-oauth2-server-core/src/main/java/nl/myndocs/oauth2/token/converter/TokenConverter.kt

Lines changed: 0 additions & 5 deletions
This file was deleted.

kotlin-oauth2-server-core/src/main/java/nl/myndocs/oauth2/token/converter/UUIDAccessTokenConverter.kt

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,8 @@ import java.time.Instant
66
import java.util.*
77

88
class UUIDAccessTokenConverter(
9-
private val accessTokenExpireInSeconds: Int = 3600,
10-
private val refreshTokenConverter: TokenConverter<RefreshToken>? = null
9+
private val accessTokenExpireInSeconds: Int = 3600
1110
) : AccessTokenConverter {
12-
override fun convertToToken(username: String, clientId: String, requestedScopes: Set<String>): AccessToken {
13-
var refreshToken: RefreshToken? = null
14-
15-
if (refreshTokenConverter != null) {
16-
refreshToken = refreshTokenConverter.convertToToken(username, clientId, requestedScopes)
17-
}
18-
19-
return convertToToken(username, clientId, requestedScopes, refreshToken)
20-
}
2111

2212
override fun convertToToken(username: String, clientId: String, requestedScopes: Set<String>, refreshToken: RefreshToken?): AccessToken {
2313
return AccessToken(

kotlin-oauth2-server-ktor/src/main/java/nl/myndocs/oauth2/ktor/feature/Oauth2ServerFeature.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,14 @@ class Oauth2ServerFeature(configuration: Configuration) {
1818
val identityService = configuration.identityService!!
1919
val tokenStore = configuration.tokenStore!!
2020
val accessTokenConverter = configuration.accessTokenConverter
21+
val refreshTokenConverter = configuration.refreshTokenConverter
2122
val codeTokenConverter = configuration.codeTokenConverter
2223
val tokenService = TokenService(
2324
identityService,
2425
clientService,
2526
tokenStore,
2627
accessTokenConverter,
28+
refreshTokenConverter,
2729
codeTokenConverter
2830
)
2931

@@ -33,7 +35,8 @@ class Oauth2ServerFeature(configuration: Configuration) {
3335
var clientService: ClientService? = null
3436
var identityService: IdentityService? = null
3537
var tokenStore: TokenStore? = null
36-
var accessTokenConverter: AccessTokenConverter = UUIDAccessTokenConverter(refreshTokenConverter = UUIDRefreshTokenConverter())
38+
var accessTokenConverter: AccessTokenConverter = UUIDAccessTokenConverter()
39+
val refreshTokenConverter = UUIDRefreshTokenConverter()
3740
var codeTokenConverter: CodeTokenConverter = UUIDCodeTokenConverter()
3841
}
3942

0 commit comments

Comments
 (0)