Resolved various compiler warnings

This should make Jenkins happy.

Author: fallberg

libraries/Bounce2/Bounce2.cpp

@@ -18,7 +18,7 @@ Bounce::Bounce() {
 void Bounce::attach(int pin) {
  this->pin = pin;
  debouncedState = unstableState = digitalRead(pin);
- #ifdef BOUNCE_LOCK-OUT
+ #ifdef BOUNCE_LOCK_OUT
  previous_millis = 0;
  #else
  previous_millis = millis();
@@ -37,7 +37,7 @@ void Bounce::interval(unsigned long interval_millis)
 bool Bounce::update()
 {
 
-#ifdef BOUNCE_LOCK-OUT
+#ifdef BOUNCE_LOCK_OUT
     stateChanged = false;
 	// Ignore everything if we are locked out
 	if (millis() - previous_millis >= interval_millis) {

libraries/Bounce2/Bounce2.h

@@ -24,7 +24,7 @@
 * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
 
 // Uncomment the following line for "LOCK-OUT" debounce method
-//#define BOUNCE_LOCK-OUT
+//#define BOUNCE_LOCK_OUT
 
 
 #ifndef Bounce2_h

libraries/DHT/DHT.cpp

@@ -142,9 +142,9 @@ void DHT::readSensor()
   // - Then 40 bits: RISING and then a FALLING edge per bit
   // To keep our code simple, we accept any HIGH or LOW reading if it's max 85 usecs long
 
-  word rawHumidity;
-  word rawTemperature;
-  word data;
+  word rawHumidity = 0;
+  word rawTemperature = 0;
+  word data = 0;
 
   for ( int8_t i = -3 ; i < 2 * 40; i++ ) {
     byte age;

libraries/DallasTemperature/DallasTemperature.cpp

@@ -700,6 +700,7 @@ void DallasTemperature::setAlarmHandler(AlarmHandler *handler)
 // The default alarm handler
 void DallasTemperature::defaultAlarmHandler(const uint8_t* deviceAddress)
 {
+    (void)deviceAddress;
 }
 
 #endif

libraries/DigitalIO/SoftI2cMaster.cpp

@@ -50,7 +50,6 @@
  */
 bool I2cMasterBase::transfer(uint8_t addrRW,
                              void *buf, size_t nbytes, uint8_t option) {
-  uint8_t* p = reinterpret_cast<uint8_t*>(buf);
   if (_state != STATE_REP_START) {
     start();
   }

libraries/DigitalIO/SoftI2cMaster.h

@@ -132,7 +132,7 @@ class SoftI2cMaster : public I2cMasterBase {
   //----------------------------------------------------------------------------
   void sclDelay(uint8_t n) {_delay_loop_1(n);}
   //----------------------------------------------------------------------------
-  bool writeScl(bool value) {
+  void writeScl(bool value) {
     uint8_t s = SREG;
     noInterrupts();
     if (value == LOW) {
@@ -145,7 +145,7 @@ class SoftI2cMaster : public I2cMasterBase {
     SREG = s;
   }
   //----------------------------------------------------------------------------
-  bool writeSda(bool value) {
+  void writeSda(bool value) {
     uint8_t s = SREG;
     noInterrupts();
     if (value == LOW) {

libraries/IRLib/IRLib.cpp

@@ -649,7 +649,7 @@ bool IRdecodeRC6::decode(void) {
  * Hopefully this code is unique for each button.
  */
 #define FNV_PRIME_32 16777619
-#define FNV_BASIS_32 2166136261
+#define FNV_BASIS_32 2166136261UL
 // Compare two tick values, returning 0 if newval is shorter,
 // 1 if newval is equal, and 2 if newval is longer
 int IRdecodeHash::compare(unsigned int oldval, unsigned int newval) {
@@ -730,12 +730,12 @@ void IRrecvBase::resume() {
 bool IRrecvLoop::GetResults(IRdecodeBase *decoder) {
   bool Finished=false;
   byte OldState=HIGH;byte NewState;
-  unsigned long StartTime, DeltaTime, EndTime;
+  unsigned long StartTime, DeltaTime=0, EndTime=0;
   StartTime=micros();
   while(irparams.rawlen<RAWBUF) {  //While the buffer not overflowing
     while(OldState==(NewState=digitalRead(irparams.recvpin))) { //While the pin hasn't changed
       if( (DeltaTime = (EndTime=micros()) - StartTime) > 10000) { //If it's a very long wait
-        if(Finished=irparams.rawlen) break; //finished unless it's the opening gap
+        if((Finished=irparams.rawlen)) break; //finished unless it's the opening gap
       }
     }
     if(Finished) break;
@@ -798,6 +798,9 @@ void IRrecvPCI_Handler(){
     case STATE_IDLE:
        if(digitalRead(irparams.recvpin)) return; else irparams.rcvstate=STATE_RUNNING;
        break;
+    default:
+       // what of STATE_UNKNOWN, STATE_MARK and STATE_SPACE?
+       break;
   };
   irparams.rawbuf[irparams.rawlen]=DeltaTime;
   irparams.timer=ChangeTime;
@@ -982,6 +985,9 @@ ISR(TIMER_INTR_NAME)
       irparams.timer = 0;
     }
     break;
+  default:
+    // what of STATE_UNKNOWN and STATE_RUNNING?
+    break;
   }
   do_Blink();
 }

libraries/IRLib/IRLib.h

@@ -48,7 +48,7 @@
 
 #define RAWBUF 100 // Length of raw duration buffer (cannot exceed 255)
 
-typedef char IRTYPES; //formerly was an enum
+typedef unsigned char IRTYPES; //formerly was an enum
 #define UNKNOWN 0
 #define NEC 1
 #define SONY 2

libraries/LiquidCrystal/LCD.h

@@ -90,6 +90,8 @@ inline static void waitUsec ( uint16_t uSec )
 {
 #ifndef FAST_MODE
    delayMicroseconds ( uSec );
+#else
+   (void)uSec;
 #endif // FAST_MODE
 }
 
@@ -481,7 +483,7 @@ class LCD : public Print
     @param      value: pin associated to backlight control.
     @param      pol: backlight polarity control (POSITIVE, NEGATIVE)
     */
-   virtual void setBacklightPin ( uint8_t value, t_backlighPol pol ) { };
+   virtual void setBacklightPin ( uint8_t /*value*/, t_backlighPol /*pol*/ ) { };
 
    /*!
     @function
@@ -500,7 +502,7 @@ class LCD : public Print
     BACKLIGHT_OFF will be interpreted as off and BACKLIGHT_ON will drive the
     backlight on.
     */
-   virtual void setBacklight ( uint8_t value ) { };
+   virtual void setBacklight ( uint8_t /*value*/ ) { };
 
    /*!
     @function
@@ -514,9 +516,9 @@ class LCD : public Print
     @param      value[in] Value to write to the LCD.
     */
 #if (ARDUINO <  100)
-   virtual void write(uint8_t value);
+   virtual void write(uint8_t /*value*/);
 #else
-   virtual size_t write(uint8_t value);
+   virtual size_t write(uint8_t /*value*/);
 #endif
 
 #if (ARDUINO <  100)
@@ -566,9 +568,9 @@ class LCD : public Print
     the LCD.
     */
 #if (ARDUINO <  100)
-   virtual void send(uint8_t value, uint8_t mode) { };
+   virtual void send(uint8_t /*value*/, uint8_t /*mode*/) { };
 #else
-   virtual void send(uint8_t value, uint8_t mode) = 0;
+   virtual void send(uint8_t /*value*/, uint8_t /*mode*/) = 0;
 #endif
 
 };

libraries/LiquidCrystal/LiquidCrystal_I2C_ByVac.cpp

@@ -38,7 +38,7 @@
 LiquidCrystal_I2C_ByVac::LiquidCrystal_I2C_ByVac( uint8_t lcd_Addr )
 {
    _Addr = lcd_Addr;
-   _polarity == NEGATIVE;
+   _polarity = NEGATIVE;
 }
 
 // PUBLIC METHODS