Remove unnecessary MY_IP_RENEWAL_INTERVAL* (#1429)

* Remove unnecessary MY_IP_RENEWAL_INTERVAL*

Ethernet.maintain already checks when we need to renew, based on
the lease time given by the DHCP server.

https://www.arduino.cc/en/Reference/EthernetMaintain recommends
"just call it on every loop() invocation" so there is no
need for us to keep a separate timer.

* Remove call to _w5100_spi_en

This function doesn't enable SPI, so it should not
disable it either. Let calling functions handle SPI
enable/disable.

Author: mfalkvidd

MyConfig.h

@@ -1582,14 +1582,6 @@
  */
 //#define MY_USE_UDP
 
-/**
- * @def MY_IP_RENEWAL_INTERVAL_MS
- * @brief DHCP, default renewal setting in milliseconds.
- */
-#ifndef MY_IP_RENEWAL_INTERVAL_MS
-#define MY_IP_RENEWAL_INTERVAL_MS (60*1000ul)
-#endif
-
 /**
  * @def MY_MAC_ADDRESS
  * @brief Ethernet MAC address.

core/MyGatewayTransportEthernet.cpp

@@ -150,19 +150,9 @@ void gatewayTransportRenewIP(void)
 	 3 - rebind failed
 	 4 - rebind success
 	 */
-	static uint32_t _nextIPRenewal = hwMillis() + MY_IP_RENEWAL_INTERVAL_MS;
-	const uint32_t now = hwMillis();
-
-	// http://playground.arduino.cc/Code/TimingRollover
-	if ((int32_t)(now - _nextIPRenewal) < 0) {
-		return;
-	}
 	if (Ethernet.maintain() & ~(0x06)) {
 		GATEWAY_DEBUG(PSTR("!GWT:TRC:IP RENEW FAIL\n"));
-		return;
 	}
-	_w5100_spi_en(false);
-	_nextIPRenewal = now + MY_IP_RENEWAL_INTERVAL_MS;
 }
 #endif
 

examples/GatewayW5100/GatewayW5100.ino

@@ -84,9 +84,6 @@
 //#define MY_IP_GATEWAY_ADDRESS 192,168,178,1
 //#define MY_IP_SUBNET_ADDRESS 255,255,255,0
 
-// Renewal period if using DHCP
-//#define MY_IP_RENEWAL_INTERVAL 60000
-
 // The port to keep open on node server mode / or port to contact in client mode
 #define MY_PORT 5003
 

keywords.txt

@@ -271,8 +271,6 @@ MY_GATEWAY_MAX_RECEIVE_LENGTH	LITERAL1
 MY_GATEWAY_MAX_SEND_LENGTH	LITERAL1
 MY_IP_ADDRESS	LITERAL1
 MY_IP_GATEWAY_ADDRESS	LITERAL1
-MY_IP_RENEWAL_INTERVAL	LITERAL1
-MY_IP_RENEWAL_INTERVAL_MS	LITERAL1
 MY_IP_SUBNET_ADDRESS	LITERAL1
 MY_MAC_ADDRESS	LITERAL1
 MY_PORT	LITERAL1