You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Butler is a more polite and helpful replacement to the
grumpy old Gitler.
The Butler will do his utmost to assist new (and old)
contributors to the MySensors cause.
config.pr.setBuildStatus(config, 'FAILURE', 'Toll gate (Gitler)', 'This pull request targets master. That is not permitted for '+env.CHANGE_AUTHOR, '')
12
+
config.pr.setBuildStatus(config, 'FAILURE', 'Toll gate (Butler)', 'Sir, This pull request targets master. I am afraid that is not permitted for '+env.CHANGE_AUTHOR, '')
13
13
error "This pull request targets master. That is not permitted!"
if (fileExists(config.repository_root+'restyling.patch')) {
121
121
emailext (
122
-
subject: "Job '${env.JOB_NAME} #${env.BUILD_NUMBER} [PR#${env.CHANGE_ID}]' failed due to bad code styling",
123
-
body: """<p>Job '${env.JOB_NAME} [<a href="${env.CHANGE_URL}">PR#${env.CHANGE_ID}</a> - ${env.CHANGE_TITLE}]' failed because code style does not follow the standards.</p>
124
-
A patch to rectify the errors is attached. You apply the patch using:<br>
122
+
subject: "PR#${env.CHANGE_ID} - ${env.CHANGE_TITLE} has unfortunate code styling",
123
+
body: """<p>Greetings Sir!<p>
124
+
I am afraid your pull request does not follow the MySensors standards with respect to coding style.</p>
125
+
That is ok, you are perhaps a first time committer to this repository. Please read the <a href="https://www.mysensors.org/download/contributing">code contribution guidelines</a> for help on how to format your code.<p>
126
+
To assist you, I have prepared a patch for you that will reformat the code according to the coding style required.<br>
127
+
The patch is attached. You may apply the patch using:<br>
125
128
git apply restyling.patch<p>
126
-
If you disagree to this, please discuss it <a href="${env.CHANGE_URL}">here</a>.<p>
127
-
Yours sincerely, Gitler, on behalf of Jenkins""",
128
-
mimeType: 'text/html', to: '${env.CHANGE_AUTHOR_EMAIL}',
129
+
If you disagree with me, please discuss it <a href="${env.CHANGE_URL}">here</a>.<p>
130
+
--<br>
131
+
Yours sincerely, The Butler, serving the MySensors community""",
132
+
mimeType: 'text/html', to: env.CHANGE_AUTHOR_EMAIL,
reportFiles: 'butler.html', reportName: 'The Butler report', reportTitles: ''])
135
139
if (ret ==1) {
136
-
config.pr.setBuildStatus(config, 'FAILURE', 'Toll gate (Gitler)', 'Commit(s) does not meet coding standards', '${BUILD_URL}Gitler_report/gitler.html')
140
+
config.pr.setBuildStatus(config, 'FAILURE', 'Toll gate (Butler)', 'I am afraid the commit(s) needs some touchup, please check the details...', '${BUILD_URL}The_20Butler_20report/butler.html')
137
141
currentBuild.currentResult =='FAILURE'
138
-
echo "Termiated due to Gitler assert"// For BFA
139
-
echo "You can read the detailed error report here: "+env.BUILD_URL+"Gitler_report/"
140
-
error 'Termiated due to Gitler assert'
142
+
echo "Terminated due to Butler assert"// For BFA
143
+
echo "You can read the detailed error report here: "+env.BUILD_URL+"The_20Butler_20report/"
echo"<b>I am afraid there are some issues with your commit messages and/or use of keywords.</b><br>">> butler.html
64
+
echo"I highly recommend reading <a href="http://chris.beams.io/posts/git-commit">this guide</a> for tips on how to write a good commit message.<br>">> butler.html
65
+
echo"More specifically, MySensors have some <a href="https://www.mysensors.org/download/contributing">code contribution guidelines</a> that I am afraid all contributers need to follow.<br>">> butler.html
66
+
echo"<br>">> butler.html
67
+
echo"I can help guide you in how to change the commit message for a single-commit pull request:<br>">> butler.html
echo"<b>This commit is not meeting the coding standards, a mail with a patch has been sent to you that if applied to your PR, will make it meet the coding standards.</b><br>">>gitler.html
76
-
echo"You apply the patch using:<br>">>gitler.html
77
-
echo"git apply restyling.patch<br>">>gitler.html
78
-
echo"<br>">>gitler.html
84
+
echo"I am afraid your coding style is not entirely in line with the MySensors preffered style.<b><br>A mail with a patch has been sent to you that, if applied to your PR, will make it follow the MySensors coding standards.</b><br>">>butler.html
85
+
echo"You can apply the patch using:<br>">>butler.html
86
+
echo"git apply restyling.patch<br>">>butler.html
87
+
echo"<br>">>butler.html
79
88
result=1
80
89
else
81
-
echo"This commit is meeting the coding standards, congratulations!<br>">>gitler.html
82
-
echo"<br>">>gitler.html
90
+
echo"This commit is meeting the coding standards, well done Sir!<br>">>butler.html
91
+
echo"<br>">>butler.html
83
92
rm restyling.patch
84
93
fi
85
94
86
-
# Evaluate if there exists booleans in the code tree (not counting this file)
echo"<b>This repository currently contain the boolean keyword. This should be avoided.</b><br>">> gitler.html
90
-
echo"<br>">> gitler.html
91
-
result=1
92
-
else
93
-
echo"This repository does not contain any boolean keywords. This is good.<br>">> gitler.html
94
-
echo"<br>">> gitler.html
95
-
fi
96
-
97
95
if [ $result-ne 0 ];then
98
-
echo"<b>If you disagree to this, please discuss it in the GitHub pull request thread.</b><br>">> gitler.html
99
-
echo"<br>">> gitler.html
96
+
echo"If you have any questions, please first read the <a href="https://www.mysensors.org/download/contributing">code contribution guidelines</a>.</b><br>">> butler.html
97
+
echo"<b>If you disagree to this, please discuss it in the GitHub pull request thread.</b><br>">> butler.html
98
+
echo"<br>">> butler.html
100
99
fi
101
-
echo"Yours sincerely, Gitler, on behalf of Jenkins<br>">>gitler.html
102
-
printf"%s""</html>">>gitler.html
100
+
echo"Yours sincerely, The Butler, serving the MySensors community<br>">>butler.html
0 commit comments