Skip to content

Commit 0f2eb4f

Browse files
authored
Fixed analog reference compilation error with ATmega1284 (#496)
1 parent bb6efad commit 0f2eb4f

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

nodemanager/Constants.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ Chip type
8585
#if defined (__AVR_ATtiny25__) || defined(__AVR_ATtiny45__) || defined(__AVR_ATtiny85__)
8686
#define CHIP_TINYX5
8787
#endif
88-
#if defined(__AVR_ATmega32U4__) || defined(__AVR_ATmega1280__) || defined(__AVR_ATmega2560__)
88+
#if defined(__AVR_ATmega32U4__) || defined(__AVR_ATmega1280__) || defined(__AVR_ATmega2560__) || defined(__AVR_ATmega1284__) || defined(__AVR_ATmega1284P__) || defined(__AVR_ATmega644__) || defined(__AVR_ATmega644A__) || defined(__AVR_ATmega644P__) || defined(__AVR_ATmega644PA__)
8989
#define CHIP_MEGA
9090
#endif
9191
#if defined(ARDUINO_ARCH_STM32F0) || defined(ARDUINO_ARCH_STM32F1) || defined(ARDUINO_ARCH_STM32F3) || defined(ARDUINO_ARCH_STM32F4) || defined(ARDUINO_ARCH_STM32L4)

sensors/SensorBattery.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,10 @@ class SensorBattery: public Sensor {
8787
if (_battery_internal_vcc || _battery_pin == -1) volt = (float)hwCPUVoltage()/1000;
8888
else {
8989
// when measuring the battery from a pin, analog reference must be internal
90-
#ifdef CHIP_AVR
91-
nodeManager.setAnalogReference(INTERNAL);
92-
#endif
93-
#ifdef CHIP_MEGA
90+
#if defined(CHIP_MEGA)
9491
nodeManager.setAnalogReference(INTERNAL1V1);
92+
#elif defined(CHIP_AVR)
93+
nodeManager.setAnalogReference(INTERNAL);
9594
#endif
9695
volt = analogRead(_battery_pin) * _battery_volts_per_bit;
9796
}

0 commit comments

Comments
 (0)