Skip to content

Commit c757c35

Browse files
committed
Merge skippable-fact into master.
2 parents 2c3b04d + 56d9dee commit c757c35

File tree

5 files changed

+1657
-1661
lines changed

5 files changed

+1657
-1661
lines changed

src/AdoNet.Specification.Tests/AdoNet.Specification.Tests.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<ItemGroup>
3131
<PackageReference Include="xunit" Version="2.4.2" />
3232
<PackageReference Include="xunit.extensibility.execution" Version="2.4.2" />
33+
<PackageReference Include="Xunit.SkippableFact" Version="1.4.13" />
3334
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
3435
</ItemGroup>
3536

src/AdoNet.Specification.Tests/DbProviderFactoryTestBase.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,11 @@ protected DbProviderFactoryTestBase(TFixture fixture)
4444
public virtual void DbProviderFactory_CanCreateDataSourceEnumerator_is_accurate() => Assert.Equal(Fixture.Factory.CanCreateDataSourceEnumerator, Fixture.Factory.CreateDataSourceEnumerator() is object);
4545

4646
#if NETSTANDARD2_0
47-
[Fact]
48-
public virtual void DbProviderFactory_CanCreateCommandBuilder_is_true() => throw new SkipException("Not supported on this TargetFramework");
47+
[SkippableFact]
48+
public virtual void DbProviderFactory_CanCreateCommandBuilder_is_true() => throw new Xunit.SkipException("Not supported on this TargetFramework");
4949

50-
[Fact]
51-
public virtual void DbProviderFactory_CanCreateDataAdapter_is_true() => throw new SkipException("Not supported on this TargetFramework");
50+
[SkippableFact]
51+
public virtual void DbProviderFactory_CanCreateDataAdapter_is_true() => throw new Xunit.SkipException("Not supported on this TargetFramework");
5252
#else
5353
[Fact]
5454
public virtual void DbProviderFactory_CanCreateCommandBuilder_is_true() => Assert.True(Fixture.Factory.CanCreateCommandBuilder);

src/AdoNet.Specification.Tests/GetValueConversionTestBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ await DoTestAsync(dbType, kind, async reader =>
7272
protected virtual void DoTest(DbType dbType, ValueKind kind, Action<DbDataReader> action)
7373
{
7474
if (!Fixture.SupportedDbTypes.Contains(dbType))
75-
throw new SkipException("Database doesn't support this data type");
75+
throw new Xunit.SkipException("Database doesn't support this data type");
7676

7777
using var connection = CreateOpenConnection();
7878
using var command = connection.CreateCommand();
@@ -85,7 +85,7 @@ protected virtual void DoTest(DbType dbType, ValueKind kind, Action<DbDataReader
8585
protected virtual async Task DoTestAsync(DbType dbType, ValueKind kind, Func<DbDataReader, Task> action)
8686
{
8787
if (!Fixture.SupportedDbTypes.Contains(dbType))
88-
throw new SkipException("Database doesn't support this data type");
88+
throw new Xunit.SkipException("Database doesn't support this data type");
8989

9090
using var connection = CreateOpenConnection();
9191
using var command = connection.CreateCommand();

0 commit comments

Comments
 (0)