Suppress some LGTM warnings.

Author: bgrainger

src/MySqlConnector/Core/CommandExecutor.cs

@@ -53,7 +53,7 @@ public static async Task<DbDataReader> ExecuteReaderAsync(IReadOnlyList<IMySqlCo
 			cancellationToken.ThrowIfCancellationRequested();
 
 			using var payload = writer.ToPayloadData();
-			using var registration = command.CancellableCommand.RegisterCancel(cancellationToken);
+			using var registration = command.CancellableCommand.RegisterCancel(cancellationToken); // lgtm[cs/useless-assignment-to-local]
 			connection.Session.StartQuerying(command.CancellableCommand);
 			command.SetLastInsertedId(-1);
 			try

src/MySqlConnector/Core/ResultSet.cs

@@ -210,7 +210,7 @@ public async Task<bool> ReadAsync(IOBehavior ioBehavior, CancellationToken cance
 			if (BufferState == ResultSetState.HasMoreData || BufferState == ResultSetState.NoMoreData || BufferState == ResultSetState.None)
 				return new ValueTask<Row?>(default(Row?));
 
-			using var registration = Command.CancellableCommand.RegisterCancel(cancellationToken);
+			using var registration = Command.CancellableCommand.RegisterCancel(cancellationToken); // lgtm[cs/useless-assignment-to-local]
 			var payloadValueTask = Session.ReceiveReplyAsync(ioBehavior, CancellationToken.None);
 			return payloadValueTask.IsCompletedSuccessfully
 				? new ValueTask<Row?>(ScanRowAsyncRemainder(this, payloadValueTask.Result, row))

src/MySqlConnector/Core/SingleCommandPayloadCreator.cs

@@ -152,7 +152,7 @@ private static bool WriteStoredProcedure(IMySqlCommand command, IDictionary<stri
 					inParameters.Add(inParam);
 					if (param.Direction == ParameterDirection.InputOutput)
 					{
-						inOutSetParameters += $"SET {outName}={inName}; ";
+						inOutSetParameters += $"SET {outName}={inName}; "; // lgtm[cs/string-concatenation-in-loop]
 						goto case ParameterDirection.Output;
 					}
 					argParameterNames.Add(inName);

src/MySqlConnector/Core/SqlParser.cs

@@ -336,7 +336,7 @@ protected enum FinalParseStates
 
 		private static bool IsWhitespace(char ch) => ch == ' ' || ch == '\t' || ch == '\r' || ch == '\n';
 
-		private static bool IsVariableName(char ch) => (ch >= 'a' && ch <= 'z') || (ch >= 'A' && ch <= 'Z') || (ch >= '0' && ch <= '9') || ch == '.' || ch == '_' || ch == '$' || (ch >= 0x0080 && ch <= 0xFFFF);
+		private static bool IsVariableName(char ch) => (ch >= 'a' && ch <= 'z') || (ch >= 'A' && ch <= 'Z') || (ch >= '0' && ch <= '9') || ch == '.' || ch == '_' || ch == '$' || (ch >= 0x0080 && ch <= 0xFFFF); // lgtm[cs/constant-comparison]
 
 		private enum State
 		{

src/MySqlConnector/Protocol/Payloads/InitialHandshakePayload.cs

@@ -26,12 +26,12 @@ public static InitialHandshakePayload Create(ReadOnlySpan<byte> span)
 			var protocolCapabilities = (ProtocolCapabilities) reader.ReadUInt16();
 			if (reader.BytesRemaining > 0)
 			{
-				var charSet = (CharacterSet) reader.ReadByte();
-				var status = (ServerStatus) reader.ReadInt16();
+				var charSet = (CharacterSet) reader.ReadByte(); // lgtm[cs/useless-assignment-to-local]
+				var status = (ServerStatus) reader.ReadInt16(); // lgtm[cs/useless-assignment-to-local]
 				var capabilityFlagsHigh = reader.ReadUInt16();
 				protocolCapabilities |= (ProtocolCapabilities) ((ulong) capabilityFlagsHigh << 16);
 				var authPluginDataLength = reader.ReadByte();
-				var unused = reader.ReadByteString(6);
+				reader.Offset += 6;
 
 				long extendedCapabilites = reader.ReadInt32();
 				if ((protocolCapabilities & ProtocolCapabilities.LongPassword) == 0)

src/MySqlConnector/Protocol/Payloads/StatementPrepareResponsePayload.cs

@@ -17,7 +17,7 @@ public static StatementPrepareResponsePayload Create(ReadOnlySpan<byte> span)
 			var columnCount = (int) reader.ReadUInt16();
 			var parameterCount = (int) reader.ReadUInt16();
 			reader.ReadByte(0);
-			var warningCount = (int) reader.ReadInt16();
+			var warningCount = (int) reader.ReadInt16(); // lgtm[cs/useless-assignment-to-local]
 
 			return new StatementPrepareResponsePayload(statementId, columnCount, parameterCount);
 		}