Skip to content

Commit 01ef5e7

Browse files
bgraingerbgrainger
committed
Suppress LGTM warnings about undisposed DataColumn.
1 parent cb129d0 commit 01ef5e7

File tree

1 file changed

+47
-47
lines changed

1 file changed

+47
-47
lines changed

‎src/MySqlConnector/Core/SchemaProvider.cs

Lines changed: 47 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ public DataTable GetSchema(string collectionName)
3838
private void FillMetadataCollections(DataTable dataTable)
3939
{
4040
dataTable.Columns.AddRange(new[] {
41-
new DataColumn("CollectionName", typeof(string)),
42-
new DataColumn("NumberOfRestrictions", typeof(int)),
43-
new DataColumn("NumberOfIdentifierParts", typeof(int))
41+
new DataColumn("CollectionName", typeof(string)), // lgtm[cs/local-not-disposed]
42+
new DataColumn("NumberOfRestrictions", typeof(int)), // lgtm[cs/local-not-disposed]
43+
new DataColumn("NumberOfIdentifierParts", typeof(int)) // lgtm[cs/local-not-disposed]
4444
});
4545

4646
foreach (var collectionName in m_schemaCollections.Keys)
@@ -51,29 +51,29 @@ private void FillDataTypes(DataTable dataTable)
5151
{
5252
dataTable.Columns.AddRange(new[]
5353
{
54-
new DataColumn("TypeName", typeof(string)),
55-
new DataColumn("ProviderDbType", typeof(int)),
56-
new DataColumn("ColumnSize", typeof(long)),
57-
new DataColumn("CreateFormat", typeof(string)),
58-
new DataColumn("CreateParameters", typeof(string)),
59-
new DataColumn("DataType", typeof(string)),
60-
new DataColumn("IsAutoIncrementable", typeof(bool)),
61-
new DataColumn("IsBestMatch", typeof(bool)),
62-
new DataColumn("IsCaseSensitive", typeof(bool)),
63-
new DataColumn("IsFixedLength", typeof(bool)),
64-
new DataColumn("IsFixedPrecisionScale", typeof(bool)),
65-
new DataColumn("IsLong", typeof(bool)),
66-
new DataColumn("IsNullable", typeof(bool)),
67-
new DataColumn("IsSearchable", typeof(bool)),
68-
new DataColumn("IsSearchableWithLike", typeof(bool)),
69-
new DataColumn("IsUnsigned", typeof(bool)),
70-
new DataColumn("MaximumScale", typeof(short)),
71-
new DataColumn("MinimumScale", typeof(short)),
72-
new DataColumn("IsConcurrencyType", typeof(bool)),
73-
new DataColumn("IsLiteralSupported", typeof(bool)),
74-
new DataColumn("LiteralPrefix", typeof(string)),
75-
new DataColumn("LiteralSuffix", typeof(string)),
76-
new DataColumn("NativeDataType", typeof(string)),
54+
new DataColumn("TypeName", typeof(string)), // lgtm[cs/local-not-disposed]
55+
new DataColumn("ProviderDbType", typeof(int)), // lgtm[cs/local-not-disposed]
56+
new DataColumn("ColumnSize", typeof(long)), // lgtm[cs/local-not-disposed]
57+
new DataColumn("CreateFormat", typeof(string)), // lgtm[cs/local-not-disposed]
58+
new DataColumn("CreateParameters", typeof(string)), // lgtm[cs/local-not-disposed]
59+
new DataColumn("DataType", typeof(string)), // lgtm[cs/local-not-disposed]
60+
new DataColumn("IsAutoIncrementable", typeof(bool)), // lgtm[cs/local-not-disposed]
61+
new DataColumn("IsBestMatch", typeof(bool)), // lgtm[cs/local-not-disposed]
62+
new DataColumn("IsCaseSensitive", typeof(bool)), // lgtm[cs/local-not-disposed]
63+
new DataColumn("IsFixedLength", typeof(bool)), // lgtm[cs/local-not-disposed]
64+
new DataColumn("IsFixedPrecisionScale", typeof(bool)), // lgtm[cs/local-not-disposed]
65+
new DataColumn("IsLong", typeof(bool)), // lgtm[cs/local-not-disposed]
66+
new DataColumn("IsNullable", typeof(bool)), // lgtm[cs/local-not-disposed]
67+
new DataColumn("IsSearchable", typeof(bool)), // lgtm[cs/local-not-disposed]
68+
new DataColumn("IsSearchableWithLike", typeof(bool)), // lgtm[cs/local-not-disposed]
69+
new DataColumn("IsUnsigned", typeof(bool)), // lgtm[cs/local-not-disposed]
70+
new DataColumn("MaximumScale", typeof(short)), // lgtm[cs/local-not-disposed]
71+
new DataColumn("MinimumScale", typeof(short)), // lgtm[cs/local-not-disposed]
72+
new DataColumn("IsConcurrencyType", typeof(bool)), // lgtm[cs/local-not-disposed]
73+
new DataColumn("IsLiteralSupported", typeof(bool)), // lgtm[cs/local-not-disposed]
74+
new DataColumn("LiteralPrefix", typeof(string)), // lgtm[cs/local-not-disposed]
75+
new DataColumn("LiteralSuffix", typeof(string)), // lgtm[cs/local-not-disposed]
76+
new DataColumn("NativeDataType", typeof(string)), // lgtm[cs/local-not-disposed]
7777
});
7878

7979
var clrTypes = new HashSet<string>();
@@ -135,26 +135,26 @@ private void FillProcedures(DataTable dataTable)
135135
{
136136
dataTable.Columns.AddRange(new[]
137137
{
138-
new DataColumn("SPECIFIC_NAME", typeof(string)),
139-
new DataColumn("ROUTINE_CATALOG", typeof(string)),
140-
new DataColumn("ROUTINE_SCHEMA", typeof(string)),
141-
new DataColumn("ROUTINE_NAME", typeof(string)),
142-
new DataColumn("ROUTINE_TYPE", typeof(string)),
143-
new DataColumn("DTD_IDENTIFIER", typeof(string)),
144-
new DataColumn("ROUTINE_BODY", typeof(string)),
145-
new DataColumn("ROUTINE_DEFINITION", typeof(string)),
146-
new DataColumn("EXTERNAL_NAME", typeof(string)),
147-
new DataColumn("EXTERNAL_LANGUAGE", typeof(string)),
148-
new DataColumn("PARAMETER_STYLE", typeof(string)),
149-
new DataColumn("IS_DETERMINISTIC", typeof(string)),
150-
new DataColumn("SQL_DATA_ACCESS", typeof(string)),
151-
new DataColumn("SQL_PATH", typeof(string)),
152-
new DataColumn("SECURITY_TYPE", typeof(string)),
153-
new DataColumn("CREATED", typeof(DateTime)),
154-
new DataColumn("LAST_ALTERED", typeof(DateTime)),
155-
new DataColumn("SQL_MODE", typeof(string)),
156-
new DataColumn("ROUTINE_COMMENT", typeof(string)),
157-
new DataColumn("DEFINER", typeof(string)),
138+
new DataColumn("SPECIFIC_NAME", typeof(string)), // lgtm[cs/local-not-disposed]
139+
new DataColumn("ROUTINE_CATALOG", typeof(string)), // lgtm[cs/local-not-disposed]
140+
new DataColumn("ROUTINE_SCHEMA", typeof(string)), // lgtm[cs/local-not-disposed]
141+
new DataColumn("ROUTINE_NAME", typeof(string)), // lgtm[cs/local-not-disposed]
142+
new DataColumn("ROUTINE_TYPE", typeof(string)), // lgtm[cs/local-not-disposed]
143+
new DataColumn("DTD_IDENTIFIER", typeof(string)), // lgtm[cs/local-not-disposed]
144+
new DataColumn("ROUTINE_BODY", typeof(string)), // lgtm[cs/local-not-disposed]
145+
new DataColumn("ROUTINE_DEFINITION", typeof(string)), // lgtm[cs/local-not-disposed]
146+
new DataColumn("EXTERNAL_NAME", typeof(string)), // lgtm[cs/local-not-disposed]
147+
new DataColumn("EXTERNAL_LANGUAGE", typeof(string)), // lgtm[cs/local-not-disposed]
148+
new DataColumn("PARAMETER_STYLE", typeof(string)), // lgtm[cs/local-not-disposed]
149+
new DataColumn("IS_DETERMINISTIC", typeof(string)), // lgtm[cs/local-not-disposed]
150+
new DataColumn("SQL_DATA_ACCESS", typeof(string)), // lgtm[cs/local-not-disposed]
151+
new DataColumn("SQL_PATH", typeof(string)), // lgtm[cs/local-not-disposed]
152+
new DataColumn("SECURITY_TYPE", typeof(string)), // lgtm[cs/local-not-disposed]
153+
new DataColumn("CREATED", typeof(DateTime)), // lgtm[cs/local-not-disposed]
154+
new DataColumn("LAST_ALTERED", typeof(DateTime)), // lgtm[cs/local-not-disposed]
155+
new DataColumn("SQL_MODE", typeof(string)), // lgtm[cs/local-not-disposed]
156+
new DataColumn("ROUTINE_COMMENT", typeof(string)), // lgtm[cs/local-not-disposed]
157+
new DataColumn("DEFINER", typeof(string)), // lgtm[cs/local-not-disposed]
158158
});
159159

160160
Action? close = null;
@@ -183,7 +183,7 @@ private void FillProcedures(DataTable dataTable)
183183

184184
private void FillReservedWords(DataTable dataTable)
185185
{
186-
dataTable.Columns.Add(new DataColumn("ReservedWord", typeof(string)));
186+
dataTable.Columns.Add(new DataColumn("ReservedWord", typeof(string))); // lgtm[cs/local-not-disposed]
187187

188188
// Note:
189189
// For MySQL 8.0, the INFORMATION_SCHEMA.KEYWORDS table could be used to load the list at runtime,

0 commit comments

Comments
 (0)