Set UseAffectedRows=false by default. Fixes #600

Author: bgrainger

.ci/config/config.json

@@ -1,6 +1,6 @@
 {
     "Data": {
-      "ConnectionString": "server=127.0.0.1;user id=mysqltest;password='test;key=\"val';port=3306;database=mysqltest;ssl mode=none;Use Affected Rows=true;DefaultCommandTimeout=3600",
+      "ConnectionString": "server=127.0.0.1;user id=mysqltest;password='test;key=\"val';port=3306;database=mysqltest;ssl mode=none;DefaultCommandTimeout=3600",
       "PasswordlessUser": "no_password",
       "SecondaryDatabase": "testdb2",
       "UnsupportedFeatures": "RsaEncryption,CachingSha2Password,Tls12,UuidToBin",

docs/content/connection-options.md

@@ -340,8 +340,8 @@ These are the other options that MySqlConnector supports. They are set to sensib
   </tr>
   <tr>
     <td>Use Affected Rows, UseAffectedRows</td>
-    <td>true</td>
-    <td>When false, the connection reports found rows instead of changed (affected) rows.</td>
+    <td>false</td>
+    <td>When <code>false</code> (default), the connection reports found rows instead of changed (affected) rows. Set to <code>true</code> to report only the number of rows actually changed by <code>UPDATE</code> or <code>INSERT … ON DUPLICATE KEY UPDATE</code> statements.</td>
   </tr>
   <tr>
     <td>Use XA Transactions, UseXaTransactions</td>

docs/content/tutorials/migrating-from-connector-net.md

@@ -53,12 +53,6 @@ MySqlConnector has some different default connection string options:
     <td>(not configurable)</td>
     <td>Specify a file containing the server’s RSA public key to allow <code>sha256_password</code> authentication over an insecure connection.</td>
   </tr>
-  <tr>
-    <td><code>UseAffectedRows</code></td>
-    <td>Default is <code>true</code></td>
-    <td>Default is <code>false</code></td>
-    <td>This also affects the behavior of the <code>ROW_COUNT</code> function. <code>UseAffectedRows=true</code> is the default in most other languages (C++, PHP, others)</td>
-  </tr>
 </table>
 
 Some connection string options that are supported in Connector/NET are not supported in MySqlConnector. For a full list of options that are

src/MySqlConnector/MySql.Data.MySqlClient/MySqlConnectionStringBuilder.cs

@@ -589,7 +589,7 @@ static MySqlConnectionStringOption()
 
 			AddOption(UseAffectedRows = new MySqlConnectionStringOption<bool>(
 				keys: new[] { "Use Affected Rows", "UseAffectedRows" },
-				defaultValue: true));
+				defaultValue: false));
 
 			AddOption(UseCompression = new MySqlConnectionStringOption<bool>(
 				keys: new[] { "Compress", "Use Compression", "UseCompression" },

tests/MySqlConnector.Tests/MySqlConnectionStringBuilderTests.cs

@@ -63,11 +63,7 @@ public void Defaults()
 			Assert.True(csb.TreatTinyAsBoolean);
 			Assert.False(csb.UseCompression);
 			Assert.Equal("", csb.UserID);
-#if BASELINE
 			Assert.False(csb.UseAffectedRows);
-#else
-			Assert.True(csb.UseAffectedRows);
-#endif
 #if !BASELINE
 			Assert.True(csb.UseXaTransactions);
 #endif
@@ -126,7 +122,7 @@ public void ParseConnectionString()
 					"Treat Tiny As Boolean=false;" +
 					"ssl mode=verifyca;" +
 					"Uid=username;" +
-					"useaffectedrows=false"
+					"useaffectedrows=true"
 			};
 			Assert.True(csb.AllowPublicKeyRetrieval);
 			Assert.True(csb.AllowUserVariables);
@@ -174,7 +170,7 @@ public void ParseConnectionString()
 			Assert.Equal("db-server", csb.Server);
 			Assert.False(csb.TreatTinyAsBoolean);
 			Assert.Equal(MySqlSslMode.VerifyCA, csb.SslMode);
-			Assert.False(csb.UseAffectedRows);
+			Assert.True(csb.UseAffectedRows);
 			Assert.True(csb.UseCompression);
 			Assert.Equal("username", csb.UserID);
 		}

tests/SideBySide/UpdateTests.cs

@@ -23,7 +23,7 @@ public void Dispose()
 		[InlineData(1, 2)]
 		[InlineData(2, 1)]
 		[InlineData(3, 0)]
-		[InlineData(4, 0)]
+		[InlineData(4, 1)]
 		public async Task UpdateRowsExecuteReader(int oldValue, int expectedRowsUpdated)
 		{
 			using (var cmd = m_database.Connection.CreateCommand())
@@ -60,7 +60,7 @@ public async Task UpdateRowsExecuteReader(int oldValue, int expectedRowsUpdated)
 		[InlineData(1, 2)]
 		[InlineData(2, 1)]
 		[InlineData(3, 0)]
-		[InlineData(4, 0)]
+		[InlineData(4, 1)]
 		public async Task UpdateRowsExecuteNonQuery(int oldValue, int expectedRowsUpdated)
 		{
 			using (var cmd = m_database.Connection.CreateCommand())
@@ -93,7 +93,7 @@ public async Task UpdateRowsExecuteNonQuery(int oldValue, int expectedRowsUpdate
 		[InlineData(1, 2)]
 		[InlineData(2, 1)]
 		[InlineData(3, 0)]
-		[InlineData(4, 0)]
+		[InlineData(4, 1)]
 		public void UpdateRowsDapper(int oldValue, int expectedRowsUpdated)
 		{
 			using (var cmd = m_database.Connection.CreateCommand())