Allow all decimals to be converted to ints. Fixes #832

Author: bgrainger

src/MySqlConnector/Core/Row.cs

@@ -213,20 +213,23 @@ public int GetInt32(int ordinal)
 				throw new InvalidCastException();
 
 			var columnDefinition = ResultSet.ColumnDefinitions[ordinal];
-			if (columnDefinition.ColumnType != ColumnType.Tiny &&
+			if (columnDefinition.ColumnType == ColumnType.Decimal || columnDefinition.ColumnType == ColumnType.NewDecimal)
+			{
+				return (int) (decimal) GetValue(ordinal);
+			}
+			else if (columnDefinition.ColumnType != ColumnType.Tiny &&
 				columnDefinition.ColumnType != ColumnType.Short &&
 				columnDefinition.ColumnType != ColumnType.Int24 &&
 				columnDefinition.ColumnType != ColumnType.Long &&
 				columnDefinition.ColumnType != ColumnType.Longlong &&
 				columnDefinition.ColumnType != ColumnType.Bit &&
-				columnDefinition.ColumnType != ColumnType.Year &&
-				columnDefinition.ColumnType != ColumnType.Decimal &&
-				columnDefinition.ColumnType != ColumnType.NewDecimal)
+				columnDefinition.ColumnType != ColumnType.Year)
 			{
 				throw new InvalidCastException("Can't convert {0} to Int32".FormatInvariant(ResultSet.ColumnTypes![ordinal]));
 			}
 
 			var data = m_data.Slice(m_dataOffsets[ordinal], m_dataLengths[ordinal]).Span;
+			System.Console.WriteLine(System.Text.Encoding.UTF8.GetString(data));
 
 			if (columnDefinition.ColumnType == ColumnType.Bit)
 				return checked((int) ReadBit(data, columnDefinition));

tests/SideBySide/QueryTests.cs

@@ -633,6 +633,34 @@ public void SumInts(bool prepareCommand)
 			Assert.Equal(4294967296L, reader.GetInt64(0));
 		}
 
+		[Theory]
+		[InlineData(false)]
+		[InlineData(true)]
+		public void DivideInts(bool prepareCommand)
+		{
+			var csb = AppConfig.CreateConnectionStringBuilder();
+			csb.IgnorePrepare = !prepareCommand;
+			using var connection = new MySqlConnection(csb.ConnectionString);
+			connection.Open();
+
+			using var cmd = new MySqlCommand("select 2 / 1;", connection);
+			cmd.Prepare();
+			using var reader = cmd.ExecuteReader();
+			Assert.True(reader.Read());
+			Assert.Equal(2.000m, reader.GetValue(0));
+			Assert.Equal(2.000m, reader.GetDecimal(0));
+#if !BASELINE
+			Assert.Equal((byte) 2, reader.GetByte(0));
+			Assert.Equal((sbyte) 2, reader.GetSByte(0));
+#endif
+			Assert.Equal((short) 2, reader.GetInt16(0));
+			Assert.Equal((ushort) 2, reader.GetUInt16(0));
+			Assert.Equal(2, reader.GetInt32(0));
+			Assert.Equal(2u, reader.GetUInt32(0));
+			Assert.Equal(2L, reader.GetInt64(0));
+			Assert.Equal(2ul, reader.GetUInt64(0));
+		}
+
 		[Fact]
 		public void UseReaderWithoutDisposing()
 		{