Only call SetSuccess if successful.

Remove an unnecessary guard in SetSuccess; the method assumes it will only be called appropriately.

Author: bgrainger

src/MySqlConnector/MySqlDataReader.cs

@@ -481,6 +481,7 @@ internal static async Task<MySqlDataReader> CreateAsync(CommandListPosition comm
 				activity.SetException(ex);
 				activity.Stop();
 			}
+			dataReader.m_creationFailed = true;
 			dataReader.Dispose();
 			throw;
 		}
@@ -622,7 +623,8 @@ internal async Task DisposeAsync(IOBehavior ioBehavior, CancellationToken cancel
 			Command.CancellableCommand.SetTimeout(Constants.InfiniteTimeout);
 			connection.FinishQuerying(m_hasWarnings);
 
-			Activity?.SetSuccess();
+			if (!m_creationFailed)
+				Activity?.SetSuccess();
 			Activity?.Stop();
 
 			if ((m_behavior & CommandBehavior.CloseConnection) != 0)
@@ -682,7 +684,8 @@ private ResultSet GetResultSet()
 	private CommandListPosition m_commandListPosition;
 	private bool m_closed;
 	private bool m_hasWarnings;
-	private ResultSet? m_resultSet;
 	private bool m_hasMoreResults;
+	private bool m_creationFailed;
+	private ResultSet? m_resultSet;
 	private DataTable? m_schemaTable;
 }

src/MySqlConnector/Utilities/ActivitySourceHelper.cs

@@ -41,15 +41,9 @@ internal static class ActivitySourceHelper
 	public static void SetSuccess(this Activity activity)
 	{
 #if NET6_0_OR_GREATER
-		if (activity.Status == ActivityStatusCode.Unset)
-		{
-			activity.SetStatus(ActivityStatusCode.Ok);
-		}
+		activity.SetStatus(ActivityStatusCode.Ok);
 #else
-		if (activity.Duration == TimeSpan.Zero)
-		{
-			activity.SetTag(StatusCodeTagName, "OK");
-		}
+		activity.SetTag(StatusCodeTagName, "OK");
 #endif
 	}