Update integration tests to MySql.Data 8.0.31.

bgrainger · bgrainger · commit 0dd5b62021a6 · 2022-10-12T05:54:42.000-07:00
Signed-off-by: Bradley Grainger &lt;bgrainger@gmail.com&gt;
diff --git a/docs/content/tutorials/migrating-from-connector-net.md b/docs/content/tutorials/migrating-from-connector-net.md
@@ -248,7 +248,7 @@ The following bugs in Connector/NET are fixed by switching to MySqlConnector. (~
 * [#95348](https://bugs.mysql.com/bug.php?id=95348): Inefficient query when executing stored procedures
 * [#95436](https://bugs.mysql.com/bug.php?id=95436): Client doesn't authenticate with PEM certificate
 * ~~[#95984](https://bugs.mysql.com/bug.php?id=95984): “Incorrect arguments to mysqld_stmt_execute” using prepared statement with `MySqlDbType.JSON`~~
-* [#95986](https://bugs.mysql.com/bug.php?id=95986): “Incorrect integer value” using prepared statement with `MySqlDbType.Int24`
+* ~~[#95986](https://bugs.mysql.com/bug.php?id=95986): “Incorrect integer value” using prepared statement with `MySqlDbType.Int24`~~
 * ~~[#96355](https://bugs.mysql.com/bug.php?id=96355), [#96614](https://bugs.mysql.com/bug.php?id=96614): `Could not load file or assembly 'Renci.SshNet'` when opening connection~~
 * ~~[#96498](https://bugs.mysql.com/bug.php?id=96498): `WHERE` clause using `MySqlGeometry` as parameter finds no rows~~
 * ~~[#96499](https://bugs.mysql.com/bug.php?id=96499): `MySqlException` when inserting a `MySqlGeometry` value~~
@@ -277,19 +277,20 @@ The following bugs in Connector/NET are fixed by switching to MySqlConnector. (~
 * [#101507](https://bugs.mysql.com/bug.php?id=101507): `MySqlCommand.Cancel` throws `NullReferenceException` for a closed connection
 * ~~[#101714](https://bugs.mysql.com/bug.php?id=101714): Extremely slow performance reading result sets~~
 * ~~[#102303](https://bugs.mysql.com/bug.php?id=102303): Preparing command with incorrect parameter type puts connection in bad state~~
-* [#102593](https://bugs.mysql.com/bug.php?id=102593): Can't use `MemoryStream` as `MySqlParameter.Value`
+* ~~[#102593](https://bugs.mysql.com/bug.php?id=102593): Can't use `MemoryStream` as `MySqlParameter.Value`~~
 * ~~[#103390](https://bugs.mysql.com/bug.php?id=103390): Can't query `CHAR(36)` column if `MySqlCommand` is prepared~~
 * ~~[#103430](https://bugs.mysql.com/bug.php?id=103430): Can't connect using named pipe on Windows~~
 * ~~[#103801](https://bugs.mysql.com/bug.php?id=103801): `TimeSpan` parameters lose microseconds with prepared statement~~
 * [#103819](https://bugs.mysql.com/bug.php?id=103819): Can't use `StringBuilder` containing non-BMP characters as `MySqlParameter.Value`
 * ~~[#104910](https://bugs.mysql.com/bug.php?id=104910): `MySqlConnectionStringBuilder.TryGetValue` always returns `false`~~
 * ~~[#104913](https://bugs.mysql.com/bug.php?id=104913): Cannot execute stored procedure with backtick in name~~
 * ~~[#105209](https://bugs.mysql.com/bug.php?id=105209): Timespan value of zero can't be read with prepared command~~
-* [#105728](https://bugs.mysql.com/bug.php?id=105728): Named command parameters override query attribute values
+* ~~[#105728](https://bugs.mysql.com/bug.php?id=105728): Named command parameters override query attribute values~~
 * ~~[#105730](https://bugs.mysql.com/bug.php?id=105730): `MySqlCommand.Clone` doesn't clone attributes~~
 * ~~[#105768](https://bugs.mysql.com/bug.php?id=105768): `MySqlCommandBuilder` doesn't support tables with `BIGINT UNSIGNED` primary key~~
 * [#105965](https://bugs.mysql.com/bug.php?id=105965): `MySqlParameterCollection.Add(object)` has quadratic performance
 * ~~[#106242](https://bugs.mysql.com/bug.php?id=106242): `MySqlConnection.Open` throws `AggregateException` instead of `MySqlException`~~
 * ~~[#106243](https://bugs.mysql.com/bug.php?id=106243): `CancellationToken` doesn't cancel `MySqlConnection.OpenAsync`~~
 * ~~[#106244](https://bugs.mysql.com/bug.php?id=106244): `MySqlDataReader.GetFieldValue<Stream>` throws `InvalidCastException`~~
 * [#106247](https://bugs.mysql.com/bug.php?id=106247): Can't use ~~`MySqlDbType.Enum` or~~ `MySqlDbType.Set` with prepared command
+* [#108756](https://bugs.mysql.com/bug.php?id=108756): Can't insert negative number using prepared statement with MySqlDbType.Int24]
diff --git a/tests/IntegrationTests/DataTypes.cs b/tests/IntegrationTests/DataTypes.cs
@@ -270,10 +270,6 @@ public void QueryInt32(string column, string dataTypeName, object[] expected)
 	[InlineData("UInt32", "INT", new object[] { null, default(uint), uint.MinValue, uint.MaxValue, 123456789u })]
 	public void QueryUInt32(string column, string dataTypeName, object[] expected)
 	{
-#if MYSQL_DATA
-		// mysql-connector-net incorrectly returns "INT" for "MEDIUMINT UNSIGNED"
-		dataTypeName = "INT";
-#endif
 		DoQuery("integers", column, dataTypeName, expected, reader => reader.GetUInt32(column));
 	}
 
diff --git a/tests/IntegrationTests/InsertTests.cs b/tests/IntegrationTests/InsertTests.cs
@@ -345,7 +345,7 @@ public void InsertMySqlDateTime()
 		Assert.Equal(new DateTime(2018, 6, 9, 12, 34, 56, 123).AddTicks(4560), datetime);
 	}
 
-	[SkippableTheory(MySqlData = "https://bugs.mysql.com/bug.php?id=102593")]
+	[Theory]
 	[InlineData(false)]
 	[InlineData(true)]
 	public void InsertMemoryStream(bool prepare)
diff --git a/tests/IntegrationTests/IntegrationTests.csproj b/tests/IntegrationTests/IntegrationTests.csproj
@@ -51,7 +51,7 @@
   </ItemGroup>
 
   <ItemGroup Condition=" '$(Configuration)' == 'MySqlData' ">
-    <PackageReference Include="MySql.Data" Version="8.0.30" />
+    <PackageReference Include="MySql.Data" Version="8.0.31" />
     <Using Include="MySql.Data.MySqlClient" />
   </ItemGroup>
 
diff --git a/tests/IntegrationTests/PreparedCommandTests.cs b/tests/IntegrationTests/PreparedCommandTests.cs
@@ -376,7 +376,7 @@ public static IEnumerable<object[]> GetInsertAndQueryData()
 #if !MYSQL_DATA
 			yield return new object[] { isPrepared, "MEDIUMINT", -1234567, MySqlDbType.Int24 };
 #else
-			// https://bugs.mysql.com/bug.php?id=95986
+			// https://bugs.mysql.com/bug.php?id=108756
 			yield return new object[] { isPrepared, "MEDIUMINT", -1234567, MySqlDbType.Int32 };
 #endif
 			yield return new object[] { isPrepared, "MEDIUMINT UNSIGNED", 1234567u, MySqlDbType.UInt24 };
diff --git a/tests/IntegrationTests/QueryTests.cs b/tests/IntegrationTests/QueryTests.cs
@@ -1431,9 +1431,7 @@ public void QueryAttributeWithEmptyName()
 
 	[SkippableTheory(ServerFeatures.QueryAttributes)]
 	[InlineData(false)]
-#if !MYSQL_DATA // https://bugs.mysql.com/bug.php?id=105728
 	[InlineData(true)]
-#endif
 	public void QueryAttributeAndParameter(bool prepare)
 	{
 		using var connection = new MySqlConnection(AppConfig.ConnectionString);
diff --git a/tests/IntegrationTests/app.config b/tests/IntegrationTests/app.config
@@ -3,7 +3,7 @@
   <system.data>
     <DbProviderFactories>
       <add name="MySqlConnector" invariant="MySqlConnector" description="Async MySQL ADO.NET Connector" type="MySqlConnector.MySqlConnectorFactory, MySqlConnector, Culture=neutral, PublicKeyToken=d33d3e53aa5f8c92" />
-      <add name="MySQL Data Provider" invariant="MySql.Data.MySqlClient" description=".Net Framework Data Provider for MySQL" type="MySql.Data.MySqlClient.MySqlClientFactory, MySql.Data, Version=8.0.30.0, Culture=neutral, PublicKeyToken=c5687fc88969c44d" />
+      <add name="MySQL Data Provider" invariant="MySql.Data.MySqlClient" description=".Net Framework Data Provider for MySQL" type="MySql.Data.MySqlClient.MySqlClientFactory, MySql.Data, Version=8.0.31.0, Culture=neutral, PublicKeyToken=c5687fc88969c44d" />
     </DbProviderFactories>
   </system.data>
 </configuration>
diff --git a/tests/MySqlConnector.Tests/MySqlConnector.Tests.csproj b/tests/MySqlConnector.Tests/MySqlConnector.Tests.csproj
@@ -32,7 +32,7 @@
   </ItemGroup>
 
   <ItemGroup Condition=" '$(Configuration)' == 'MySqlData' ">
-    <PackageReference Include="MySql.Data" Version="8.0.30" />
+    <PackageReference Include="MySql.Data" Version="8.0.31" />
     <Compile Remove="ByteBufferWriterTests.cs;CachedProcedureTests.cs;CancellationTests.cs;ConnectionTests.cs;FakeMySqlServer.cs;FakeMySqlServerConnection.cs;LoadBalancerTests.cs;MySqlDecimalTests.cs;MySqlExceptionTests.cs;MySqlParameterCollectionNameToIndexTests.cs;NormalizeTests.cs;ServerVersionTests.cs;StatementPreparerTests.cs;TypeMapperTests.cs;UtilityTests.cs" />
   </ItemGroup>
 

Original file line number	Diff line number	Diff line change
`@@ -270,10 +270,6 @@ public void QueryInt32(string column, string dataTypeName, object[] expected)`
`270`	`270`	`[InlineData("UInt32", "INT", new object[] { null, default(uint), uint.MinValue, uint.MaxValue, 123456789u })]`
`271`	`271`	`public void QueryUInt32(string column, string dataTypeName, object[] expected)`
`272`	`272`	`{`
`273`		`-#if MYSQL_DATA`
`274`		`- // mysql-connector-net incorrectly returns "INT" for "MEDIUMINT UNSIGNED"`
`275`		`- dataTypeName = "INT";`
`276`		`-#endif`
`277`	`273`	`DoQuery("integers", column, dataTypeName, expected, reader => reader.GetUInt32(column));`
`278`	`274`	`}`
`279`	`275`
Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,7 @@ public void InsertMySqlDateTime()`
`345`	`345`	`Assert.Equal(new DateTime(2018, 6, 9, 12, 34, 56, 123).AddTicks(4560), datetime);`
`346`	`346`	`}`
`347`	`347`
`348`		`- [SkippableTheory(MySqlData = "https://bugs.mysql.com/bug.php?id=102593")]`
	`348`	`+ [Theory]`
`349`	`349`	`[InlineData(false)]`
`350`	`350`	`[InlineData(true)]`
`351`	`351`	`public void InsertMemoryStream(bool prepare)`
Original file line number	Diff line number	Diff line change
`@@ -1431,9 +1431,7 @@ public void QueryAttributeWithEmptyName()`
`1431`	`1431`
`1432`	`1432`	`[SkippableTheory(ServerFeatures.QueryAttributes)]`
`1433`	`1433`	`[InlineData(false)]`
`1434`		`-#if !MYSQL_DATA // https://bugs.mysql.com/bug.php?id=105728`
`1435`	`1434`	`[InlineData(true)]`
`1436`		`-#endif`
`1437`	`1435`	`public void QueryAttributeAndParameter(bool prepare)`
`1438`	`1436`	`{`
`1439`	`1437`	`using var connection = new MySqlConnection(AppConfig.ConnectionString);`