Skip to content

Commit 13a312a

Browse files
committed
Fix/suppress Roslyn warnings about non-static methods.
1 parent 30ea715 commit 13a312a

File tree

5 files changed

+9
-3
lines changed

5 files changed

+9
-3
lines changed

src/MySqlConnector/Core/ResultSet.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ int ReadColumnCount(ReadOnlySpan<byte> span)
174174
}
175175
}
176176

177-
private bool IsHostVerified(MySqlConnection connection)
177+
private static bool IsHostVerified(MySqlConnection connection)
178178
{
179179
return connection.SslMode == MySqlSslMode.VerifyCA
180180
|| connection.SslMode == MySqlSslMode.VerifyFull;
@@ -348,7 +348,9 @@ public async Task<bool> ReadAsync(IOBehavior ioBehavior, CancellationToken cance
348348
}
349349
}
350350

351+
#pragma warning disable CA1822 // Mark members as static
351352
public int Depth => 0;
353+
#pragma warning restore CA1822 // Mark members as static
352354

353355
public string GetName(int ordinal)
354356
{

src/MySqlConnector/MySqlBulkLoader.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ private string CreateSql()
284284
return sb.ToString();
285285
}
286286

287-
private Stream CreateFileStream(string fileName)
287+
private static Stream CreateFileStream(string fileName)
288288
{
289289
try
290290
{

src/MySqlConnector/MySqlConnection.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -614,8 +614,10 @@ public override Task<DataTable> GetSchemaAsync(string collectionName, string?[]
614614
/// </summary>
615615
/// <returns></returns>
616616
public MySqlBatchCommand CreateBatchCommand() => CreateDbBatchCommand();
617+
#pragma warning disable CA1822 // Mark members as static
617618
private MySqlBatchCommand CreateDbBatchCommand() => new();
618619
public bool CanCreateBatch => true;
620+
#pragma warning restore CA1822 // Mark members as static
619621

620622
protected override void Dispose(bool disposing)
621623
{

src/MySqlConnector/MySqlConnectorFactory.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ public sealed class MySqlConnectorFactory : DbProviderFactory
6363
#endif
6464
#endif
6565

66+
#pragma warning disable CA1822 // Mark members as static
6667
/// <summary>
6768
/// Creates a new <see cref="MySqlBatch"/> object.
6869
/// </summary>
@@ -77,6 +78,7 @@ public sealed class MySqlConnectorFactory : DbProviderFactory
7778
/// Returns <c>true</c>.
7879
/// </summary>
7980
public bool CanCreateBatch => true;
81+
#pragma warning restore CA1822 // Mark members as static
8082

8183
private MySqlConnectorFactory()
8284
{

src/MySqlConnector/Protocol/Serialization/CompressedPayloadHandler.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ private ValueTask<int> CompressAndWrite(ArraySegment<byte> remainingUncompressed
225225
CompressAndWrite(remainingUncompressedData, ioBehavior));
226226
}
227227

228-
private uint ComputeAdler32Checksum(byte[] data, int offset, int length)
228+
private static uint ComputeAdler32Checksum(byte[] data, int offset, int length)
229229
{
230230
int s1 = 1, s2 = 0;
231231
for (var i = 0; i < length; i++)

0 commit comments

Comments
 (0)