Skip to content

Commit 1cae060

Browse files
committed
Move conformance tests to a template.
1 parent ec6be14 commit 1cae060

File tree

5 files changed

+40
-25
lines changed

5 files changed

+40
-25
lines changed

.ci/conformance-test-steps.yml

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
parameters:
2+
image: ''
3+
connectionString: ''
4+
5+
steps:
6+
- task: DeleteFiles@1
7+
condition: always()
8+
inputs:
9+
contents: '**/*.trx'
10+
- task: DownloadPipelineArtifact@0
11+
condition: always()
12+
inputs:
13+
artifactName: 'Conformance.Tests-3.0-$(Agent.OS)'
14+
targetPath: '$(Build.BinariesDirectory)/3.0'
15+
- task: DotNetCoreCLI@2
16+
displayName: 'Conformance Tests'
17+
inputs:
18+
command: 'custom'
19+
custom: 'vstest'
20+
arguments: '$(Build.BinariesDirectory)/3.0/Conformance.Tests.dll /logger:trx'
21+
env:
22+
CONNECTION_STRING: ${{ parameters.connectionString }}
23+
- task: PublishTestResults@2
24+
condition: always()
25+
inputs:
26+
testResultsFormat: VSTest
27+
testResultsFiles: '**/*.trx'
28+
testRunTitle: ${{ format('Conformance Tests, {0}, $(Agent.OS)', parameters.image) }}
29+
failTaskOnFailedTests: true

.ci/install-mysql-windows.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ steps:
99
displayName: Install MySQL Server
1010
- script: |
1111
"C:\Program Files\MySQL\MySQL Server 8.0\bin\mysql" -uroot -ptest -e "SET GLOBAL local_infile=1; SET GLOBAL log_bin_trust_function_creators=1;"
12-
"C:\Program Files\MySQL\MySQL Server 8.0\bin\mysql" -uroot -ptest -e "CREATE SCHEMA conformance COLLATE utf8mb4_bin;"
1312
"C:\Program Files\MySQL\MySQL Server 8.0\bin\mysql" -uroot -ptest < $(Build.Repository.LocalPath)\.ci\server\init.sql
1413
"C:\Program Files\MySQL\MySQL Server 8.0\bin\mysql" -uroot -ptest < $(Build.Repository.LocalPath)\.ci\server\init_sha256.sql
1514
"C:\Program Files\MySQL\MySQL Server 8.0\bin\mysql" -uroot -ptest < $(Build.Repository.LocalPath)\.ci\server\init_caching_sha2.sql

.ci/integration-tests-steps.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ parameters:
66
steps:
77
- bash: ${{ format('.ci/docker-run.sh {0} 3300 {1}', parameters.image, parameters.unsupportedFeatures) }}
88
displayName: 'Start Docker container'
9+
- template: 'conformance-test-steps.yml'
10+
parameters:
11+
image: ${{ parameters.image }}
12+
connectionString: 'server=localhost;port=3300;user id=mysqltest;password=test;database=conformance;ssl mode=none;DefaultCommandTimeout=3600'
913
- template: 'sidebyside-test-steps.yml'
1014
parameters:
1115
image: ${{ parameters.image }}

.ci/server/init.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ CREATE USER 'no_password'@'localhost';
33
CREATE USER 'no_password'@'172.17.0.1';
44
CREATE USER 'ssltest'@'%' IDENTIFIED BY 'test' /*!50706 REQUIRE SSL */; GRANT ALL PRIVILEGES ON *.* TO 'ssltest'@'%';
55
SET GLOBAL max_allowed_packet=104857600;
6-
6+
CREATE SCHEMA conformance COLLATE utf8mb4_bin;

azure-pipelines.yml

Lines changed: 6 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -123,37 +123,20 @@ jobs:
123123
displayName: 'Install .NET Core'
124124
inputs:
125125
version: $(DotNetCoreSdkVersion)
126-
- task: DownloadPipelineArtifact@0
127-
condition: always()
128-
inputs:
129-
artifactName: 'Conformance.Tests-3.0-$(Agent.OS)'
130-
targetPath: '$(Build.BinariesDirectory)/3.0'
131-
- task: DotNetCoreCLI@2
132-
displayName: 'Windows Conformance Tests'
133-
inputs:
134-
command: 'custom'
135-
custom: 'vstest'
136-
arguments: '$(Build.BinariesDirectory)/3.0/Conformance.Tests.dll /logger:trx'
137-
env:
138-
CONNECTION_STRING: 'server=localhost;port=3306;user id=mysqltest;password=test;database=conformance;ssl mode=none;DefaultCommandTimeout=3600;AllowPublicKeyRetrieval=True'
139-
TF_BUILD: $(TF_BUILD)
140-
- task: PublishTestResults@2
141-
condition: always()
142-
inputs:
143-
testResultsFormat: VSTest
144-
testResultsFiles: '**/*.trx'
145-
testRunTitle: 'Windows Conformance Tests'
146-
failTaskOnFailedTests: true
126+
- template: '.ci/conformance-test-steps.yml'
127+
parameters:
128+
image: 'mysql:8.0'
129+
connectionString: 'server=localhost;port=3306;user id=mysqltest;password=test;database=conformance;ssl mode=none;DefaultCommandTimeout=3600;AllowPublicKeyRetrieval=True'
147130
- template: '.ci/sidebyside-test-steps.yml'
148131
parameters:
149-
image: 'mysql-8.0.15'
132+
image: 'mysql:8.0'
150133
unsupportedFeatures: 'Ed25519,Tls11,UnixDomainSocket'
151134
connectionString: 'server=localhost;port=3306;user id=mysqltest;password=test;database=mysqltest;ssl mode=none;DefaultCommandTimeout=3600;AllowPublicKeyRetrieval=True'
152135
platform: 'netcoreapp3.0'
153136
description: 'No SSL'
154137
- template: '.ci/sidebyside-test-steps.yml'
155138
parameters:
156-
image: 'mysql-8.0.15'
139+
image: 'mysql:8.0'
157140
unsupportedFeatures: 'Ed25519,Tls11,UnixDomainSocket'
158141
connectionString: 'server=localhost;port=3306;user id=mysqltest;password=test;database=mysqltest;ssl mode=none;UseCompression=True;DefaultCommandTimeout=3600;AllowPublicKeyRetrieval=True'
159142
platform: 'netcoreapp3.0'

0 commit comments

Comments
 (0)