Update baseline tests to MySql.Data 8.0.21.

Author: bgrainger

docs/content/tutorials/migrating-from-connector-net.md

@@ -214,7 +214,7 @@ The following bugs in Connector/NET are fixed by switching to MySqlConnector. (~
 * ~~[#91752](https://bugs.mysql.com/bug.php?id=91752): `00:00:00` is converted to `NULL` with prepared command~~
 * [#91753](https://bugs.mysql.com/bug.php?id=91753): Unnamed parameter not supported by `MySqlCommand.Prepare`
 * [#91754](https://bugs.mysql.com/bug.php?id=91754): Inserting 16MiB `BLOB` shifts it by four bytes when prepared
-* [#91770](https://bugs.mysql.com/bug.php?id=91770): `TIME(n)` column loses microseconds with prepared command
+* ~~[#91770](https://bugs.mysql.com/bug.php?id=91770): `TIME(n)` column loses microseconds with prepared command~~
 * [#92367](https://bugs.mysql.com/bug.php?id=92367): `MySqlDataReader.GetDateTime` and `GetValue` return inconsistent values
 * [#92465](https://bugs.mysql.com/bug.php?id=92465): “There is already an open DataReader” `MySqlException` thrown from `TransactionScope.Dispose`
 * [#92734](https://bugs.mysql.com/bug.php?id=92734): `MySqlParameter.Clone` doesn't copy all property values
@@ -234,18 +234,19 @@ The following bugs in Connector/NET are fixed by switching to MySqlConnector. (~
 * ~~[#95984](https://bugs.mysql.com/bug.php?id=95984): “Incorrect arguments to mysqld_stmt_execute” using prepared statement with `MySqlDbType.JSON`~~
 * [#95986](https://bugs.mysql.com/bug.php?id=95986): “Incorrect integer value” using prepared statement with `MySqlDbType.Int24`
 * ~~[#96355](https://bugs.mysql.com/bug.php?id=96355), [#96614](https://bugs.mysql.com/bug.php?id=96614): `Could not load file or assembly 'Renci.SshNet'` when opening connection~~
-* [#96498](https://bugs.mysql.com/bug.php?id=96498): `WHERE` clause using `MySqlGeometry` as parameter finds no rows
-* [#96499](https://bugs.mysql.com/bug.php?id=96499): `MySqlException` when inserting a `MySqlGeometry` value
+* ~~[#96498](https://bugs.mysql.com/bug.php?id=96498): `WHERE` clause using `MySqlGeometry` as parameter finds no rows~~
+* ~~[#96499](https://bugs.mysql.com/bug.php?id=96499): `MySqlException` when inserting a `MySqlGeometry` value~~
 * [#96500](https://bugs.mysql.com/bug.php?id=96500): `MySqlDataReader.GetFieldValue<MySqlGeometry>` throws `InvalidCastException`
 * [#96636](https://bugs.mysql.com/bug.php?id=96636): `MySqlConnection.Open()` slow under load when using SSL
 * [#96717](https://bugs.mysql.com/bug.php?id=96717): Not compatible with MySQL Server 5.0
 * [#97067](https://bugs.mysql.com/bug.php?id=97067): Aggregate functions on BIT(n) columns return wrong result
-* [#97300](https://bugs.mysql.com/bug.php?id=97300): `GetSchemaTable()` returns table for stored procedure with output parameters
+* ~~[#97300](https://bugs.mysql.com/bug.php?id=97300): `GetSchemaTable()` returns table for stored procedure with output parameters~~
 * ~~[#97448](https://bugs.mysql.com/bug.php?id=97448): Connecting fails if more than one IP is found in DNS for a named host~~
 * [#97473](https://bugs.mysql.com/bug.php?id=97473): `MySqlConnection.Clone` discloses connection password
 * [#97738](https://bugs.mysql.com/bug.php?id=97738): Cannot use PEM files when account uses `require subject`
 * [#97872](https://bugs.mysql.com/bug.php?id=97872): `KeepAlive` in connection string throws exception on .NET Core
-* [#98322](https://bugs.mysql.com/bug.php?id=98322): `new MySqlConnection(null)` throws `NullReferenceException`
+* ~~[#98322](https://bugs.mysql.com/bug.php?id=98322): `new MySqlConnection(null)` throws `NullReferenceException`~~
 * [#99091](https://bugs.mysql.com/bug.php?id=99091): Unexpected return value getting integer for `TINYINT(1)` column
 * [#99793](https://bugs.mysql.com/bug.php?id=99793): Prepared stored procedure command doesn't verify parameter types
 * [#100159](https://bugs.mysql.com/bug.php?id=100159): SQL with DateTime parameter returns String value
+* [#100208](https://bugs.mysql.com/bug.php?id=100208): `GetSchema("Procedures")` returns `ROUTINE_DEFINITION` of `"System.Byte[]"`

tests/SideBySide/ConnectionTests.cs

@@ -72,7 +72,7 @@ public void DefaultConnectionStringIsEmpty()
 			Assert.Equal("", connection.ConnectionString);
 		}
 
-		[SkippableFact(Baseline = "https://bugs.mysql.com/bug.php?id=98322")]
+		[Fact]
 		public void InitializeWithNullConnectionString()
 		{
 			using var connection = new MySqlConnection(default(string));

tests/SideBySide/PreparedCommandTests.cs

@@ -386,10 +386,10 @@ public static IEnumerable<object[]> GetInsertAndQueryData()
 				yield return new object[] { isPrepared, "BOOL", true, MySqlDbType.Int32 };
 #endif
 
-#if !BASELINE
 				// https://bugs.mysql.com/bug.php?id=91770
 				yield return new object[] { isPrepared, "TIME(3)", TimeSpan.Zero.Subtract(new TimeSpan(15, 10, 34, 56, 789)), MySqlDbType.Time };
 
+#if !BASELINE
 				// https://bugs.mysql.com/bug.php?id=91751
 				yield return new object[] { isPrepared, "YEAR", 2134, MySqlDbType.Year };
 #endif

tests/SideBySide/SideBySide.csproj

@@ -42,7 +42,7 @@
   </ItemGroup>
 
   <ItemGroup Condition=" '$(Configuration)' == 'Baseline' ">
-    <PackageReference Include="MySql.Data" Version="8.0.20" />
+    <PackageReference Include="MySql.Data" Version="8.0.21" />
   </ItemGroup>
 
   <ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.1.2' ">

tests/SideBySide/StoredProcedureTests.cs

@@ -143,7 +143,7 @@ public async Task StoredProcedureNoResultSet(bool ignorePrepare)
 			Assert.Equal("test value", cmd.Parameters[0].Value);
 		}
 
-		[SkippableTheory(Baseline = "https://bugs.mysql.com/bug.php?id=97300")]
+		[Theory]
 		[InlineData(true)]
 		[InlineData(false)]
 		public async Task FieldCountForNoResultSet(bool ignorePrepare)
@@ -173,7 +173,7 @@ public async Task FieldCountForNoResultSet(bool ignorePrepare)
 		}
 
 #if !NETCOREAPP1_1_2
-		[SkippableTheory(Baseline = "https://bugs.mysql.com/bug.php?id=97300")]
+		[Theory]
 		[InlineData(true)]
 		[InlineData(false)]
 		public async Task GetSchemaTableForNoResultSet(bool ignorePrepare)
@@ -193,9 +193,13 @@ public async Task GetSchemaTableForNoResultSet(bool ignorePrepare)
 			using var reader = await cmd.ExecuteReaderAsync();
 			Assert.False(await reader.ReadAsync());
 			var table = reader.GetSchemaTable();
+#if BASELINE
+			Assert.Null(table);
+#else
 			Assert.NotNull(table);
 			Assert.Empty(table.Rows);
 			Assert.Empty(table.Columns);
+#endif
 			Assert.False(await reader.NextResultAsync());
 		}
 #endif
@@ -699,7 +703,12 @@ public void ProceduresSchema(string procedureName, string procedureType, string
 				Assert.Equal(DBNull.Value, row["DTD_IDENTIFIER"]);
 			else
 				Assert.Equal(dtdIdentifier, ((string) row["DTD_IDENTIFIER"]).Split(' ')[0]);
+#if BASELINE
+			// https://bugs.mysql.com/bug.php?id=100208
+			Assert.NotEmpty(routineDefinition);
+#else
 			Assert.Equal(routineDefinition, NormalizeSpaces((string) row["ROUTINE_DEFINITION"]));
+#endif
 			Assert.Equal(isDeterministic, row["IS_DETERMINISTIC"]);
 			Assert.Equal(dataAccess, ((string) row["SQL_DATA_ACCESS"]).Replace('_', ' '));
 		}