Convert output TIME parameters. Fixes #680

Author: bgrainger

src/MySqlConnector/Core/TypeMapper.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Data;
 using System.Linq;
+using System.Text;
 using MySql.Data.MySqlClient;
 using MySqlConnector.Protocol;
 using MySqlConnector.Protocol.Payloads;
@@ -94,7 +95,7 @@ private TypeMapper()
 			var typeDate = AddDbTypeMapping(new DbTypeMapping(typeof(DateTime), new[] { DbType.Date }));
 			var typeDateTime = AddDbTypeMapping(new DbTypeMapping(typeof(DateTime), new[] { DbType.DateTime, DbType.DateTime2, DbType.DateTimeOffset }));
 			AddDbTypeMapping(new DbTypeMapping(typeof(DateTimeOffset), new[] { DbType.DateTimeOffset }));
-			var typeTime = AddDbTypeMapping(new DbTypeMapping(typeof(TimeSpan), new[] { DbType.Time }));
+			var typeTime = AddDbTypeMapping(new DbTypeMapping(typeof(TimeSpan), new[] { DbType.Time }, convert: o => o is string s ? Utility.ParseTimeSpan(Encoding.UTF8.GetBytes(s)) : Convert.ChangeType(o, typeof(TimeSpan))));
 			AddColumnTypeMetadata(new ColumnTypeMetadata("DATETIME", typeDateTime, MySqlDbType.DateTime));
 			AddColumnTypeMetadata(new ColumnTypeMetadata("DATE", typeDate, MySqlDbType.Date));
 			AddColumnTypeMetadata(new ColumnTypeMetadata("DATE", typeDate, MySqlDbType.Newdate));

tests/SideBySide/StoredProcedureFixture.cs

@@ -109,6 +109,11 @@ create procedure number_lister (inout high int)
 				begin
 					select 1, 2, 3;
 				end;");
+			Connection.Execute(@"DROP PROCEDURE IF EXISTS `GetTime`;
+				CREATE PROCEDURE `GetTime`(OUT OutTime TIME)
+				BEGIN
+					SET OutTime = CURTIME();
+				END");
 
 			if (AppConfig.SupportsJson)
 			{

tests/SideBySide/StoredProcedureTests.cs

@@ -590,6 +590,22 @@ public void CallNonExistentStoredProcedure()
 			}
 		}
 
+		[Fact]
+		public void OutputTimeParameter()
+		{
+			using (var command = new MySqlCommand("GetTime", m_database.Connection))
+			{
+				command.CommandType = CommandType.StoredProcedure;
+				var parameter = command.CreateParameter();
+				parameter.ParameterName = "OutTime";
+				parameter.Direction = ParameterDirection.Output;
+				command.Parameters.Add(parameter);
+
+				command.ExecuteNonQuery();
+				Assert.IsType<TimeSpan>(parameter.Value);
+			}
+		}
+
 		private static string NormalizeSpaces(string input)
 		{
 			input = input.Replace('\r', ' ');