Add support for AllowPublicKeyRetrieval.

Author: bgrainger

tests/MySqlConnector.Tests/MySqlConnectionStringBuilderTests.cs

@@ -10,9 +10,7 @@ public class MySqlConnectionStringBuilderTests
 		public void Defaults()
 		{
 			var csb = new MySqlConnectionStringBuilder();
-#if !BASELINE
 			Assert.False(csb.AllowPublicKeyRetrieval);
-#endif
 			Assert.False(csb.AllowUserVariables);
 			Assert.True(csb.AutoEnlist);
 			Assert.Null(csb.CertificateFile);
@@ -73,6 +71,7 @@ public void ParseConnectionString()
 			{
 				ConnectionString = "Data Source=db-server;" +
 					"Initial Catalog=schema_name;" +
+					"allowpublickeyretrieval = true;" +
 					"Allow User Variables=true;" +
 					"auto enlist=False;" +
 					"certificate file=file.pfx;" +
@@ -93,7 +92,6 @@ public void ParseConnectionString()
 					"forcesynchronous=true;" +
 					"ignore command transaction=true;" +
 					"ca certificate file=ca.pem;" +
-					"allow public key retrieval = true;" +
 					"server rsa public key file=rsa.pem;" +
 					"load balance=random;" +
 #endif
@@ -110,6 +108,7 @@ public void ParseConnectionString()
 					"Uid=username;" +
 					"useaffectedrows=false"
 			};
+			Assert.True(csb.AllowPublicKeyRetrieval);
 			Assert.True(csb.AllowUserVariables);
 			Assert.False(csb.AutoEnlist);
 			Assert.Equal("file.pfx", csb.CertificateFile);
@@ -130,7 +129,6 @@ public void ParseConnectionString()
 			Assert.True(csb.ForceSynchronous);
 			Assert.True(csb.IgnoreCommandTransaction);
 			Assert.Equal("ca.pem", csb.CACertificateFile);
-			Assert.True(csb.AllowPublicKeyRetrieval);
 			Assert.Equal("rsa.pem", csb.ServerRsaPublicKeyFile);
 			Assert.Equal(MySqlLoadBalance.Random, csb.LoadBalance);
 #endif

tests/SideBySide/ConnectAsync.cs

@@ -270,19 +270,13 @@ public async Task Sha256WithoutSecureConnection()
 		{
 			var csb = AppConfig.CreateSha256ConnectionStringBuilder();
 			csb.SslMode = MySqlSslMode.None;
-#if !BASELINE
 			csb.AllowPublicKeyRetrieval = true;
-#endif
 			using (var connection = new MySqlConnection(csb.ConnectionString))
 			{
-#if BASELINE
-				await Assert.ThrowsAsync<NotImplementedException>(() => connection.OpenAsync());
-#else
 				if (AppConfig.SupportedFeatures.HasFlag(ServerFeatures.RsaEncryption))
 					await connection.OpenAsync();
 				else
 					await Assert.ThrowsAsync<MySqlException>(() => connection.OpenAsync());
-#endif
 			}
 		}
 
@@ -299,16 +293,10 @@ public async Task CachingSha2WithoutSecureConnection()
 		{
 			var csb = AppConfig.CreateCachingSha2ConnectionStringBuilder();
 			csb.SslMode = MySqlSslMode.None;
-#if !BASELINE
 			csb.AllowPublicKeyRetrieval = true;
-#endif
 			using (var connection = new MySqlConnection(csb.ConnectionString))
 			{
-#if BASELINE
-				await Assert.ThrowsAsync<NotImplementedException>(() => connection.OpenAsync());
-#else
 				await connection.OpenAsync();
-#endif
 			}
 		}
 

tests/SideBySide/ConnectSync.cs

@@ -367,12 +367,10 @@ public void Sha256WithoutSecureConnection()
 		{
 			var csb = AppConfig.CreateSha256ConnectionStringBuilder();
 			csb.SslMode = MySqlSslMode.None;
-#if !BASELINE
 			csb.AllowPublicKeyRetrieval = true;
-#endif
 			using (var connection = new MySqlConnection(csb.ConnectionString))
 			{
-#if BASELINE || NET45
+#if NET45
 				Assert.Throws<NotImplementedException>(() => connection.Open());
 #else
 				if (AppConfig.SupportedFeatures.HasFlag(ServerFeatures.RsaEncryption))