Merge pull request #365 from dgilbert/duane/fixAuroraTimeStampIssue

bgrainger · web-flow · commit 3c6b5b7619a8 · 2017-10-22T07:21:04.000-07:00
Fix Issue Comparing DateTime in Amazon Aurora.
diff --git a/src/MySqlConnector/MySqlClient/MySqlParameter.cs b/src/MySqlConnector/MySqlClient/MySqlParameter.cs
@@ -172,12 +172,12 @@ internal void AppendSqlString(BinaryWriter writer, StatementPreparerOptions opti
 			}
 			else if (Value is DateTime)
 			{
-				writer.WriteUtf8("timestamp '{0:yyyy'-'MM'-'dd' 'HH':'mm':'ss'.'ffffff}'".FormatInvariant(Value));
+				writer.WriteUtf8("timestamp('{0:yyyy'-'MM'-'dd' 'HH':'mm':'ss'.'ffffff}')".FormatInvariant(Value));
 			}
 			else if (Value is DateTimeOffset dateTimeOffsetValue)
 			{
 				// store as UTC as it will be read as such when deserialized from a timespan column
-				writer.WriteUtf8("timestamp '{0:yyyy'-'MM'-'dd' 'HH':'mm':'ss'.'ffffff}'".FormatInvariant(dateTimeOffsetValue.UtcDateTime));
+				writer.WriteUtf8("timestamp('{0:yyyy'-'MM'-'dd' 'HH':'mm':'ss'.'ffffff}')".FormatInvariant(dateTimeOffsetValue.UtcDateTime));
 			}
 			else if (Value is TimeSpan ts)
 			{

Original file line number	Diff line number	Diff line change
`@@ -172,12 +172,12 @@ internal void AppendSqlString(BinaryWriter writer, StatementPreparerOptions opti`
`172`	`172`	`}`
`173`	`173`	`else if (Value is DateTime)`
`174`	`174`	`{`
`175`		`- writer.WriteUtf8("timestamp '{0:yyyy'-'MM'-'dd' 'HH':'mm':'ss'.'ffffff}'".FormatInvariant(Value));`
	`175`	`+ writer.WriteUtf8("timestamp('{0:yyyy'-'MM'-'dd' 'HH':'mm':'ss'.'ffffff}')".FormatInvariant(Value));`
`176`	`176`	`}`
`177`	`177`	`else if (Value is DateTimeOffset dateTimeOffsetValue)`
`178`	`178`	`{`
`179`	`179`	`// store as UTC as it will be read as such when deserialized from a timespan column`
`180`		`- writer.WriteUtf8("timestamp '{0:yyyy'-'MM'-'dd' 'HH':'mm':'ss'.'ffffff}'".FormatInvariant(dateTimeOffsetValue.UtcDateTime));`
	`180`	`+ writer.WriteUtf8("timestamp('{0:yyyy'-'MM'-'dd' 'HH':'mm':'ss'.'ffffff}')".FormatInvariant(dateTimeOffsetValue.UtcDateTime));`
`181`	`181`	`}`
`182`	`182`	`else if (Value is TimeSpan ts)`
`183`	`183`	`{`