Skip to content

Commit 4153227

Browse files
committed
Add tests for MySQL bug 88660.
1 parent 3a0e353 commit 4153227

File tree

2 files changed

+48
-0
lines changed

2 files changed

+48
-0
lines changed

docs/content/tutorials/migrating-from-connector-net.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ The following bugs in Connector/NET are fixed by switching to MySqlConnector.
122122
* [#88058](https://bugs.mysql.com/bug.php?id=88058): `decimal(n, 0)` has wrong `NumericPrecision`
123123
* [#88124](https://bugs.mysql.com/bug.php?id=88124): CommandTimeout isn’t reset when calling Read/NextResult
124124
* [#88611](https://bugs.mysql.com/bug.php?id=88611): `MySqlCommand` can be executed even if it has "wrong" transaction
125+
* [#88660](https://bugs.mysql.com/bug.php?id=88660): `MySqlClientFactory.Instance.CreateDataAdapter()` and `CreateCommandBuilder` return `null`
125126
* [#89085](https://bugs.mysql.com/bug.php?id=89085): `MySqlConnection.Database` not updated after `USE database;`
126127
* [#89159](https://bugs.mysql.com/bug.php?id=89159): `MySqlDataReader` cannot outlive `MySqlCommand`
127128
* [#89335](https://bugs.mysql.com/bug.php?id=89335): `MySqlCommandBuilder.DeriveParameters` fails for `JSON` type
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
using MySql.Data.MySqlClient;
2+
using Xunit;
3+
4+
namespace SideBySide
5+
{
6+
public class ClientFactoryTests
7+
{
8+
[Fact]
9+
public void CreateCommand()
10+
{
11+
Assert.IsType<MySqlCommand>(MySqlClientFactory.Instance.CreateCommand());
12+
}
13+
14+
[Fact]
15+
public void CreateConnection()
16+
{
17+
Assert.IsType<MySqlConnection>(MySqlClientFactory.Instance.CreateConnection());
18+
}
19+
20+
[Fact]
21+
public void CreateConnectionStringBuilder()
22+
{
23+
Assert.IsType<MySqlConnectionStringBuilder>(MySqlClientFactory.Instance.CreateConnectionStringBuilder());
24+
}
25+
26+
27+
[Fact]
28+
public void CreateParameter()
29+
{
30+
Assert.IsType<MySqlParameter>(MySqlClientFactory.Instance.CreateParameter());
31+
}
32+
33+
#if !NETCOREAPP1_1_2
34+
[SkippableFact(Baseline = "https://bugs.mysql.com/bug.php?id=88660")]
35+
public void CreateCommandBuilder()
36+
{
37+
Assert.IsType<MySqlCommandBuilder>(MySqlClientFactory.Instance.CreateCommandBuilder());
38+
}
39+
40+
[SkippableFact(Baseline = "https://bugs.mysql.com/bug.php?id=88660")]
41+
public void CreateDataAdapter()
42+
{
43+
Assert.IsType<MySqlDataAdapter>(MySqlClientFactory.Instance.CreateDataAdapter());
44+
}
45+
#endif
46+
}
47+
}

0 commit comments

Comments
 (0)