Initialize ChunkStream with the data to read.

This will let us test if the blob is stored and retrieved exactly as-is.

Signed-off-by: Bradley Grainger <[email protected]>

Author: bgrainger

tests/IntegrationTests/ChunkStream.cs

@@ -2,17 +2,22 @@ namespace IntegrationTests;
 
 internal sealed class ChunkStream : Stream
 {
-	public ChunkStream(int dataLength, int chunkLength)
+	public ChunkStream(byte[] data, int chunkLength)
 	{
-		m_dataLength = dataLength;
+		if (data is null)
+			throw new ArgumentNullException(nameof(data));
+		if (chunkLength <= 0)
+			throw new ArgumentOutOfRangeException(nameof(chunkLength));
+
+		m_data = data;
 		m_chunkLength = chunkLength;
 		m_position = 0;
 	}
 
 	public override bool CanRead => true;
 	public override bool CanSeek => false;
 	public override bool CanWrite => false;
-	public override long Length => m_dataLength;
+	public override long Length => m_data.Length;
 	public override long Position
 	{
 		get => m_position;
@@ -37,17 +42,14 @@ public override int Read(byte[] buffer, int offset, int count)
 #endif
 		int Read(Span<byte> buffer)
 	{
-		if (m_position >= m_dataLength)
+		if (m_position >= m_data.Length)
 			return 0;
 
 		// Read at most chunkLength bytes
-		var bytesToRead = Math.Min(buffer.Length, Math.Min(m_chunkLength, m_dataLength - m_position));
+		var bytesToRead = Math.Min(buffer.Length, Math.Min(m_chunkLength, m_data.Length - m_position));
 
-		// Fill with dummy data (repeating pattern based on position)
-		for (var i = 0; i < bytesToRead; i++)
-		{
-			buffer[i] = (byte) ((m_position + i) % 256);
-		}
+		// Copy data from the actual data array
+		m_data.AsSpan(m_position, bytesToRead).CopyTo(buffer);
 
 		m_position += bytesToRead;
 		return bytesToRead;
@@ -122,7 +124,7 @@ public override void Flush() =>
 	public override Task FlushAsync(CancellationToken cancellationToken) =>
 		throw new NotSupportedException();
 
-	private readonly int m_dataLength;
+	private readonly byte[] m_data;
 	private readonly int m_chunkLength;
 	private int m_position;
 }

tests/IntegrationTests/InsertTests.cs

@@ -515,7 +515,11 @@ public async Task SendLongData(int dataLength, int chunkLength, bool isAsync)
 			create table insert_mysql_long_data(rowid integer not null primary key auto_increment, value longblob);
 			""");
 
-		using var chunkStream = new ChunkStream(dataLength, chunkLength);
+		var random = new Random(dataLength);
+		var data = new byte[dataLength];
+		random.NextBytes(data);
+
+		using var chunkStream = new ChunkStream(data, chunkLength);
 
 		using var writeCommand = new MySqlCommand("insert into insert_mysql_long_data(value) values(@value);", connection);
 		writeCommand.Parameters.AddWithValue("@value", chunkStream);
@@ -525,10 +529,20 @@ public async Task SendLongData(int dataLength, int chunkLength, bool isAsync)
 		else
 			writeCommand.ExecuteNonQuery();
 
-		using var readLengthCommand = new MySqlCommand("select length(value) from insert_mysql_long_data order by rowid;", connection);
-		using var reader = readLengthCommand.ExecuteReader();
-		Assert.True(reader.Read());
-		Assert.Equal(chunkStream.Length, reader.GetInt32(0));
+		using var readCommand = new MySqlCommand("select length(value) from insert_mysql_long_data order by rowid;", connection);
+		using (var reader = readCommand.ExecuteReader())
+		{
+			Assert.True(reader.Read());
+			Assert.Equal(chunkStream.Length, reader.GetInt32(0));
+		}
+
+		readCommand.CommandText = "select value from insert_mysql_long_data order by rowid;";
+		using (var reader = readCommand.ExecuteReader())
+		{
+			Assert.True(reader.Read());
+			var readData = (byte[]) reader.GetValue(0);
+			Assert.True(data.AsSpan().SequenceEqual(readData)); // much faster than Assert.Equal
+		}
 	}
 
 	[Theory]