Remove CommandTimeoutExpired as transient. Fixes #940

Author: bgrainger

src/MySqlConnector/MySqlException.cs

@@ -126,13 +126,12 @@ internal MySqlException(MySqlErrorCode errorCode, string? sqlState, string messa
 		internal static MySqlException CreateForTimeout(Exception? innerException) =>
 			new(MySqlErrorCode.CommandTimeoutExpired, "The Command Timeout expired before the operation completed.", innerException);
 
-		private static bool IsErrorTransient(MySqlErrorCode errorCode) =>
-			errorCode is MySqlErrorCode.CommandTimeoutExpired
-				or MySqlErrorCode.ConnectionCountError
-				or MySqlErrorCode.LockDeadlock
-				or MySqlErrorCode.LockWaitTimeout
-				or MySqlErrorCode.UnableToConnectToHost
-				or MySqlErrorCode.XARBDeadlock;
+		private static bool IsErrorTransient(MySqlErrorCode errorCode) => errorCode
+			is MySqlErrorCode.ConnectionCountError
+			or MySqlErrorCode.LockDeadlock
+			or MySqlErrorCode.LockWaitTimeout
+			or MySqlErrorCode.UnableToConnectToHost
+			or MySqlErrorCode.XARBDeadlock;
 
 		IDictionary? m_data;
 	}

tests/MySqlConnector.Tests/CancellationTests.cs

@@ -224,7 +224,6 @@ public void Test(int step, int method)
 				var ex = Assert.Throws<MySqlException>(() => s_executeMethods[method](command));
 				Assert.InRange(stopwatch.ElapsedMilliseconds, 2900, 3500);
 				Assert.Equal(MySqlErrorCode.CommandTimeoutExpired, ex.ErrorCode);
-				Assert.True(ex.IsTransient);
 				Assert.Null(ex.InnerException);
 
 				// connection is unusable