Update to .NET Core 3.0.0-preview8.

Author: bgrainger

.travis.yml

@@ -35,8 +35,8 @@ before_install:
 - tar zxf dotnet-runtime-2.1.12-linux-x64.tar.gz -C $HOME/dotnet
 - wget -q https://download.microsoft.com/download/3/a/3/3a3bda26-560d-4d8e-922e-6f6bc4553a84/dotnet-runtime-2.0.9-linux-x64.tar.gz
 - tar zxf dotnet-runtime-2.0.9-linux-x64.tar.gz -C $HOME/dotnet
-- wget -q https://download.visualstudio.microsoft.com/download/pr/c624c5d6-0e9c-4dd9-9506-6b197ef44dc8/ad61b332f3abcc7dec3a49434e4766e1/dotnet-sdk-3.0.100-preview7-012821-linux-x64.tar.gz
-- tar zxf dotnet-sdk-3.0.100-preview7-012821-linux-x64.tar.gz -C $HOME/dotnet
+- wget -q https://download.visualstudio.microsoft.com/download/pr/a0e368ac-7161-4bde-a139-1a3ef5a82bbe/439cdbb58950916d3718771c5d986c35/dotnet-sdk-3.0.100-preview8-013656-linux-x64.tar.gz
+- tar zxf dotnet-sdk-3.0.100-preview8-013656-linux-x64.tar.gz -C $HOME/dotnet
 - export DOTNET_ROOT=$HOME/dotnet
 - export PATH=$HOME/dotnet:$PATH
 - dotnet --info

appveyor.yml

@@ -10,7 +10,7 @@ cache:
 install:
   # The following can be used to install a custom version of .NET Core
   - ps: Invoke-WebRequest -Uri "https://raw.githubusercontent.com/dotnet/cli/master/scripts/obtain/dotnet-install.ps1" -OutFile "install-dotnet.ps1"
-  - ps: .\install-dotnet.ps1 -Version 3.0.100-preview7-012821 -InstallDir "dotnetcli"
+  - ps: .\install-dotnet.ps1 -Version 3.0.100-preview8-013656 -InstallDir "dotnetcli"
 build_script:
 - dotnet --info
 before_test:

azure-pipelines.yml

@@ -1,5 +1,5 @@
 variables:
-  DotNetCoreSdkVersion: '3.0.100-preview7-012821'
+  DotNetCoreSdkVersion: '3.0.100-preview8-013656'
   NUGET_PACKAGES: '$(Pipeline.Workspace)/.nuget/packages'
 
 jobs:

src/MySqlConnector/Core/ConnectionPool.cs

@@ -536,7 +536,7 @@ static ConnectionPool()
 		static readonly ConcurrentDictionary<string, ConnectionPool?> s_pools = new ConcurrentDictionary<string, ConnectionPool?>();
 
 		static int s_poolId;
-		static ConnectionStringPool s_mruCache;
+		static ConnectionStringPool? s_mruCache;
 
 		int m_generation;
 		readonly SemaphoreSlim m_cleanSemaphore;

src/MySqlConnector/MySql.Data.MySqlClient/MySqlException.cs

@@ -39,7 +39,7 @@ public override IDictionary Data
 				{
 					m_data = base.Data;
 					m_data["Server Error Code"] = Number;
-					m_data["SqlState"] = SqlState!; // BUG? Should be safe for value to be null
+					m_data["SqlState"] = SqlState;
 				}
 				return m_data;
 			}

src/MySqlConnector/MySqlConnector.csproj

@@ -1,8 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks Condition=" '$(NETCoreSdkVersion)' != '3.0.100-preview7-012821' ">net45;net461;net471;netstandard1.3;netstandard2.0;netcoreapp2.1</TargetFrameworks>
-    <TargetFrameworks Condition=" '$(NETCoreSdkVersion)' == '3.0.100-preview7-012821' ">net45;net461;net471;netstandard1.3;netstandard2.0;netstandard2.1;netcoreapp2.1;netcoreapp3.0</TargetFrameworks>
+    <TargetFrameworks Condition=" '$(NETCoreSdkVersion)' != '3.0.100-preview8-013656' ">net45;net461;net471;netstandard1.3;netstandard2.0;netcoreapp2.1</TargetFrameworks>
+    <TargetFrameworks Condition=" '$(NETCoreSdkVersion)' == '3.0.100-preview8-013656' ">net45;net461;net471;netstandard1.3;netstandard2.0;netstandard2.1;netcoreapp2.1;netcoreapp3.0</TargetFrameworks>
     <Title>Async MySQL ADO.NET Connector</Title>
     <Description>A truly async MySQL ADO.NET provider, supporting MySQL Server, MariaDB, Percona Server, Amazon Aurora, Azure Database for MySQL and more.</Description>
     <Copyright>Copyright 2016–2019 Bradley Grainger</Copyright>

src/MySqlConnector/Utilities/NullableAttributes.cs

@@ -1,7 +1,7 @@
 // Supports using nullable attributes on older frameworks.
 // Copied from https://github.com/dotnet/corefx/blob/master/src/Common/src/CoreLib/System/Diagnostics/CodeAnalysis/NullableAttributes.cs
 
-#if NET45 || NET461 || NET471 || NETSTANDARD1_3 || NETSTANDARD2_0 || NETSTANDARD2_1 || NETCOREAPP2_1
+#if NET45 || NET461 || NET471 || NETSTANDARD1_3 || NETSTANDARD2_0 || NETCOREAPP2_1
 namespace System.Diagnostics.CodeAnalysis
 {
 	/// <summary>Specifies that an output will not be null even if the corresponding type allows it.</summary>

src/MySqlConnector/Utilities/Utility.cs

@@ -338,7 +338,7 @@ public static Task CompletedTask
 				return s_completedTask;
 			}
 		}
-		static Task s_completedTask;
+		static Task? s_completedTask;
 
 		public static Task TaskFromException(Exception exception) => TaskFromException<object>(exception);
 		public static Task<T> TaskFromException<T>(Exception exception)

tests/SideBySide/SideBySide.csproj

@@ -1,8 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup Condition=" '$(Configuration)' != 'Baseline' ">
-    <TargetFrameworks Condition=" '$(NETCoreSdkVersion)' != '3.0.100-preview7-012821' ">net452;net461;net472;netcoreapp1.1.2;netcoreapp2.0;netcoreapp2.1</TargetFrameworks>
-    <TargetFrameworks Condition=" '$(NETCoreSdkVersion)' == '3.0.100-preview7-012821' ">net452;net461;net472;netcoreapp1.1.2;netcoreapp2.0;netcoreapp2.1;netcoreapp3.0</TargetFrameworks>
+    <TargetFrameworks Condition=" '$(NETCoreSdkVersion)' != '3.0.100-preview8-013656' ">net452;net461;net472;netcoreapp1.1.2;netcoreapp2.0;netcoreapp2.1</TargetFrameworks>
+    <TargetFrameworks Condition=" '$(NETCoreSdkVersion)' == '3.0.100-preview8-013656' ">net452;net461;net472;netcoreapp1.1.2;netcoreapp2.0;netcoreapp2.1;netcoreapp3.0</TargetFrameworks>
   </PropertyGroup>
 
   <PropertyGroup Condition=" '$(Configuration)' == 'Baseline' ">