Remove unnecessary null-forgiving operator in tests.

bgrainger · bgrainger · commit 569524889203 · 2024-01-14T16:03:39.000-08:00
diff --git a/tests/MySqlConnector.Tests/Metrics/IConnectionCreator.cs b/tests/MySqlConnector.Tests/Metrics/IConnectionCreator.cs
@@ -17,12 +17,12 @@ public DataSourceConnectionCreator(bool usePooling, string? poolName, string? ap
 		m_dataSource = new MySqlDataSourceBuilder(connectionStringBuilder.ConnectionString)
 			.UseName(poolName)
 			.Build();
-		PoolName = poolName ?? applicationName ?? connectionStringBuilder!.GetConnectionString(includePassword: false);
+		PoolName = poolName ?? applicationName ?? connectionStringBuilder.GetConnectionString(includePassword: false);
 	}
 
-	public MySqlConnection OpenConnection() => m_dataSource!.OpenConnection();
+	public MySqlConnection OpenConnection() => m_dataSource.OpenConnection();
 	public string PoolName { get; }
-	public void Dispose() => m_dataSource!.Dispose();
+	public void Dispose() => m_dataSource.Dispose();
 
 	private readonly MySqlDataSource m_dataSource;
 }

Original file line number	Diff line number	Diff line change
`@@ -17,12 +17,12 @@ public DataSourceConnectionCreator(bool usePooling, string? poolName, string? ap`
`17`	`17`	`m_dataSource = new MySqlDataSourceBuilder(connectionStringBuilder.ConnectionString)`
`18`	`18`	`.UseName(poolName)`
`19`	`19`	`.Build();`
`20`		`- PoolName = poolName ?? applicationName ?? connectionStringBuilder!.GetConnectionString(includePassword: false);`
	`20`	`+ PoolName = poolName ?? applicationName ?? connectionStringBuilder.GetConnectionString(includePassword: false);`
`21`	`21`	`}`
`22`	`22`
`23`		`- public MySqlConnection OpenConnection() => m_dataSource!.OpenConnection();`
	`23`	`+ public MySqlConnection OpenConnection() => m_dataSource.OpenConnection();`
`24`	`24`	`public string PoolName { get; }`
`25`		`- public void Dispose() => m_dataSource!.Dispose();`
	`25`	`+ public void Dispose() => m_dataSource.Dispose();`
`26`	`26`
`27`	`27`	`private readonly MySqlDataSource m_dataSource;`
`28`	`28`	`}`