Use static local functions.

Author: bgrainger

src/MySqlConnector/Core/ServerSession.cs

@@ -1299,7 +1299,7 @@ private async Task GetRealServerDetailsAsync(IOBehavior ioBehavior, Cancellation
 
 				// first (and only) row
 				payload = await ReceiveReplyAsync(ioBehavior, CancellationToken.None).ConfigureAwait(false);
-				void ReadRow(ReadOnlySpan<byte> span, out int? connectionId_, out byte[] serverVersion_)
+				static void ReadRow(ReadOnlySpan<byte> span, out int? connectionId_, out byte[] serverVersion_)
 				{
 					var reader = new ByteArrayReader(span);
 					var length = reader.ReadLengthEncodedIntegerOrNull();

src/MySqlConnector/Protocol/Serialization/ProtocolUtility.cs

@@ -409,8 +409,7 @@ private static ValueTask<Packet> ReadPacketAsync(BufferedByteReader bufferedByte
 				return ReadPacketAfterHeader(headerBytesTask.Result, bufferedByteReader, byteHandler, getNextSequenceNumber, protocolErrorBehavior, ioBehavior);
 			return AddContinuation(headerBytesTask, bufferedByteReader, byteHandler, getNextSequenceNumber, protocolErrorBehavior, ioBehavior);
 
-			// NOTE: use a local function (with no captures) to defer creation of lambda objects
-			ValueTask<Packet> AddContinuation(ValueTask<ArraySegment<byte>> headerBytes_, BufferedByteReader bufferedByteReader_, IByteHandler byteHandler_, Func<int> getNextSequenceNumber_, ProtocolErrorBehavior protocolErrorBehavior_, IOBehavior ioBehavior_) =>
+			static ValueTask<Packet> AddContinuation(ValueTask<ArraySegment<byte>> headerBytes_, BufferedByteReader bufferedByteReader_, IByteHandler byteHandler_, Func<int> getNextSequenceNumber_, ProtocolErrorBehavior protocolErrorBehavior_, IOBehavior ioBehavior_) =>
 				headerBytes_.ContinueWith(x => ReadPacketAfterHeader(x, bufferedByteReader_, byteHandler_, getNextSequenceNumber_, protocolErrorBehavior_, ioBehavior_));
 		}
 
@@ -435,8 +434,7 @@ private static ValueTask<Packet> ReadPacketAfterHeader(ArraySegment<byte> header
 				return CreatePacketFromPayload(payloadBytesTask.Result, payloadLength, protocolErrorBehavior, packetOutOfOrderException);
 			return AddContinuation(payloadBytesTask, payloadLength, protocolErrorBehavior, packetOutOfOrderException);
 
-			// NOTE: use a local function (with no captures) to defer creation of lambda objects
-			ValueTask<Packet> AddContinuation(ValueTask<ArraySegment<byte>> payloadBytesTask_, int payloadLength_, ProtocolErrorBehavior protocolErrorBehavior_, Exception packetOutOfOrderException_)
+			static ValueTask<Packet> AddContinuation(ValueTask<ArraySegment<byte>> payloadBytesTask_, int payloadLength_, ProtocolErrorBehavior protocolErrorBehavior_, Exception packetOutOfOrderException_)
 				=> payloadBytesTask_.ContinueWith(x => CreatePacketFromPayload(x, payloadLength_, protocolErrorBehavior_, packetOutOfOrderException_));
 		}
 
@@ -477,8 +475,7 @@ private static ValueTask<ArraySegment<byte>> DoReadPayloadAsync(BufferedByteRead
 
 			return AddContinuation(readPacketTask, bufferedByteReader, byteHandler, getNextSequenceNumber, previousPayloads, protocolErrorBehavior, ioBehavior);
 
-			// NOTE: use a local function (with no captures) to defer creation of lambda objects
-			ValueTask<ArraySegment<byte>> AddContinuation(ValueTask<Packet> readPacketTask_, BufferedByteReader bufferedByteReader_, IByteHandler byteHandler_, Func<int> getNextSequenceNumber_, ArraySegmentHolder<byte> previousPayloads_, ProtocolErrorBehavior protocolErrorBehavior_, IOBehavior ioBehavior_)
+			static ValueTask<ArraySegment<byte>> AddContinuation(ValueTask<Packet> readPacketTask_, BufferedByteReader bufferedByteReader_, IByteHandler byteHandler_, Func<int> getNextSequenceNumber_, ArraySegmentHolder<byte> previousPayloads_, ProtocolErrorBehavior protocolErrorBehavior_, IOBehavior ioBehavior_)
 			{
 				return readPacketTask_.ContinueWith(packet =>
 					HasReadPayload(previousPayloads_, packet, protocolErrorBehavior_, out var result_) ? result_ :
@@ -518,8 +515,7 @@ public static ValueTask<int> WritePayloadAsync(IByteHandler byteHandler, Func<in
 			return payload.Count <= MaxPacketSize ? WritePacketAsync(byteHandler, getNextSequenceNumber(), payload, ioBehavior) :
 				CreateTask(byteHandler, getNextSequenceNumber, payload, ioBehavior);
 
-			// NOTE: use a local function (with no captures) to defer creation of lambda objects
-			ValueTask<int> CreateTask(IByteHandler byteHandler_, Func<int> getNextSequenceNumber_, ArraySegment<byte> payload_, IOBehavior ioBehavior_)
+			static ValueTask<int> CreateTask(IByteHandler byteHandler_, Func<int> getNextSequenceNumber_, ArraySegment<byte> payload_, IOBehavior ioBehavior_)
 			{
 				var writeTask = default(ValueTask<int>);
 				for (var bytesSent = 0; bytesSent < payload_.Count; bytesSent += MaxPacketSize)
@@ -546,8 +542,7 @@ private static ValueTask<int> WritePacketAsync(IByteHandler byteHandler, int seq
 			}
 			return AddContinuation(task, buffer);
 
-			// NOTE: use a local function (with no captures) to defer creation of lambda objects
-			ValueTask<int> AddContinuation(ValueTask<int> task_, byte[] buffer_)
+			static ValueTask<int> AddContinuation(ValueTask<int> task_, byte[] buffer_)
 			{
 				return task_.ContinueWith(x =>
 				{