Skip to content

Commit 63a6368

Browse files
committed
Rewrite overloads without using default parameters.
1 parent a9b9455 commit 63a6368

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

src/MySqlConnector/MySql.Data.MySqlClient/MySqlTransaction.cs

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,11 @@ namespace MySql.Data.MySqlClient
99
{
1010
public sealed class MySqlTransaction : DbTransaction
1111
{
12-
public override void Commit() =>
13-
CommitAsync(IOBehavior.Synchronous, CancellationToken.None).GetAwaiter().GetResult();
12+
public override void Commit() => CommitAsync(IOBehavior.Synchronous, default).GetAwaiter().GetResult();
13+
public Task CommitAsync() => CommitAsync(Connection?.AsyncIOBehavior ?? IOBehavior.Asynchronous, default);
14+
public Task CommitAsync(CancellationToken cancellationToken) => CommitAsync(Connection?.AsyncIOBehavior ?? IOBehavior.Asynchronous, cancellationToken);
1415

15-
public Task CommitAsync(CancellationToken cancellationToken = default) =>
16-
CommitAsync(Connection?.AsyncIOBehavior ?? IOBehavior.Asynchronous, cancellationToken);
17-
18-
internal async Task CommitAsync(IOBehavior ioBehavior, CancellationToken cancellationToken)
16+
private async Task CommitAsync(IOBehavior ioBehavior, CancellationToken cancellationToken)
1917
{
2018
VerifyNotDisposed();
2119
if (Connection == null)
@@ -38,13 +36,11 @@ internal async Task CommitAsync(IOBehavior ioBehavior, CancellationToken cancell
3836
}
3937
}
4038

41-
public override void Rollback() =>
42-
RollbackAsync(IOBehavior.Synchronous, CancellationToken.None).GetAwaiter().GetResult();
43-
44-
public Task RollbackAsync(CancellationToken cancellationToken = default) =>
45-
RollbackAsync(Connection?.AsyncIOBehavior ?? IOBehavior.Asynchronous, cancellationToken);
39+
public override void Rollback() => RollbackAsync(IOBehavior.Synchronous, default).GetAwaiter().GetResult();
40+
public Task RollbackAsync() => RollbackAsync(Connection?.AsyncIOBehavior ?? IOBehavior.Asynchronous, default);
41+
public Task RollbackAsync(CancellationToken cancellationToken) => RollbackAsync(Connection?.AsyncIOBehavior ?? IOBehavior.Asynchronous, cancellationToken);
4642

47-
internal async Task RollbackAsync(IOBehavior ioBehavior, CancellationToken cancellationToken)
43+
private async Task RollbackAsync(IOBehavior ioBehavior, CancellationToken cancellationToken)
4844
{
4945
VerifyNotDisposed();
5046
if (Connection == null)

0 commit comments

Comments
 (0)