Skip to content

Commit 6c5f42f

Browse files
committed
Rename TypeMapper.Mapper to TypeMapper.Instance.
1 parent b018614 commit 6c5f42f

File tree

8 files changed

+75
-70
lines changed

8 files changed

+75
-70
lines changed

src/MySqlConnector/MySqlClient/Caches/CachedParameter.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System.Data;
1+
using System.Data;
22
using System.Linq;
33
using MySql.Data.MySqlClient.Types;
44

@@ -29,7 +29,7 @@ public CachedParameter(int ordinalPosition, string mode, string name, string dat
2929
}
3030
}
3131
Name = name;
32-
DbType = TypeMapper.Mapper.GetDbTypeMapping(dataType, unsigned).DbTypes?.First() ?? DbType.Object;
32+
DbType = TypeMapper.Instance.GetDbTypeMapping(dataType, unsigned).DbTypes?.First() ?? DbType.Object;
3333
}
3434

3535
internal readonly int Position;

src/MySqlConnector/MySqlClient/CommandExecutors/StoredProcedureCommandExecutor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ internal void SetParams()
104104
var param = m_outParams[i];
105105
if (param.HasSetDbType)
106106
{
107-
var dbTypeMapping = TypeMapper.Mapper.GetDbTypeMapping(param.DbType);
107+
var dbTypeMapping = TypeMapper.Instance.GetDbTypeMapping(param.DbType);
108108
if (dbTypeMapping != null)
109109
{
110110
param.Value = dbTypeMapping.DoConversion(reader.GetValue(i));

src/MySqlConnector/MySqlClient/MySqlConnection.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ public override System.Data.DataTable GetSchema(string collectionName, string[]
250250
});
251251

252252
// Column type mappings:
253-
var colTypes = Types.TypeMapper.Mapper.GetColumnMappings();
253+
var colTypes = Types.TypeMapper.Instance.GetColumnMappings();
254254
foreach (var map in colTypes)
255255
{
256256
var dbTypeMap = map.DbTypeMapping;
@@ -267,8 +267,8 @@ public override System.Data.DataTable GetSchema(string collectionName, string[]
267267
foreach (MySqlDbType mapItem in Enum.GetValues(typeof(MySqlDbType)))
268268
{
269269
var typeName = Enum.GetName(typeof(MySqlDbType), mapItem);
270-
var dbType = Types.TypeMapper.Mapper.GetDbTypeForMySqlDbType(mapItem);
271-
var map = Types.TypeMapper.Mapper.GetDbTypeMapping(dbType);
270+
var dbType = Types.TypeMapper.Instance.GetDbTypeForMySqlDbType(mapItem);
271+
var map = Types.TypeMapper.Instance.GetDbTypeMapping(dbType);
272272
if (map != null) // MySqlDbType.Set is not supported by the mapper.
273273
{
274274
dt.Rows.Add(new object[] {

src/MySqlConnector/MySqlClient/MySqlDbColumn.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public sealed class MySqlDbColumn : System.Data.Common.DbColumn
4242
{
4343
internal MySqlDbColumn(int ordinal, ColumnDefinitionPayload column, MySqlDbType mySqlDbType)
4444
{
45-
var columnTypeMetadata = TypeMapper.Mapper.GetColumnTypeMetadata(mySqlDbType);
45+
var columnTypeMetadata = TypeMapper.Instance.GetColumnTypeMetadata(mySqlDbType);
4646

4747
var type = columnTypeMetadata.DbTypeMapping.ClrType;
4848
var columnSize = type == typeof(string) || type == typeof(Guid) ?

src/MySqlConnector/MySqlClient/MySqlParameter.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public override DbType DbType
2626
set
2727
{
2828
m_dbType = value;
29-
m_mySqlDbType = TypeMapper.Mapper.GetMySqlDbTypeForDbType(value);
29+
m_mySqlDbType = TypeMapper.Instance.GetMySqlDbTypeForDbType(value);
3030
HasSetDbType = true;
3131
}
3232
}
@@ -36,7 +36,7 @@ public MySqlDbType MySqlDbType
3636
get => m_mySqlDbType;
3737
set
3838
{
39-
m_dbType = TypeMapper.Mapper.GetDbTypeForMySqlDbType(value);
39+
m_dbType = TypeMapper.Instance.GetDbTypeForMySqlDbType(value);
4040
m_mySqlDbType = value;
4141
HasSetDbType = true;
4242
}

src/MySqlConnector/MySqlClient/Results/ResultSet.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,15 +278,15 @@ public string GetDataTypeName(int ordinal)
278278
var mySqlDbType = ColumnTypes[ordinal];
279279
if (mySqlDbType == MySqlDbType.String)
280280
return string.Format(CultureInfo.InvariantCulture, "CHAR({0})", ColumnDefinitions[ordinal].ColumnLength / SerializationUtility.GetBytesPerCharacter(ColumnDefinitions[ordinal].CharacterSet));
281-
return TypeMapper.Mapper.GetColumnTypeMetadata(mySqlDbType).SimpleDataTypeName;
281+
return TypeMapper.Instance.GetColumnTypeMetadata(mySqlDbType).SimpleDataTypeName;
282282
}
283283

284284
public Type GetFieldType(int ordinal)
285285
{
286286
if (ordinal < 0 || ordinal > ColumnDefinitions.Length)
287287
throw new ArgumentOutOfRangeException(nameof(ordinal), "value must be between 0 and {0}.".FormatInvariant(ColumnDefinitions.Length));
288288

289-
return TypeMapper.Mapper.GetColumnTypeMetadata(ColumnTypes[ordinal]).DbTypeMapping.ClrType;
289+
return TypeMapper.Instance.GetColumnTypeMetadata(ColumnTypes[ordinal]).DbTypeMapping.ClrType;
290290
}
291291

292292
public int FieldCount => ColumnDefinitions?.Length ?? 0;

src/MySqlConnector/MySqlClient/Types/TypeMapper.cs

Lines changed: 59 additions & 54 deletions
Large diffs are not rendered by default.

tests/MySqlConnector.Tests/TypeMapperTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ public class TypeMapperTests
3131
[InlineData(typeof(Guid), DbType.Guid)]
3232
public void DbTypeMappingTest(Type clrType, DbType dbType)
3333
{
34-
Assert.Equal(clrType, TypeMapper.Mapper.GetDbTypeMapping(dbType).ClrType);
35-
Assert.Contains(dbType, TypeMapper.Mapper.GetDbTypeMapping(clrType).DbTypes);
34+
Assert.Equal(clrType, TypeMapper.Instance.GetDbTypeMapping(dbType).ClrType);
35+
Assert.Contains(dbType, TypeMapper.Instance.GetDbTypeMapping(clrType).DbTypes);
3636
}
3737

3838
[Theory]
@@ -51,7 +51,7 @@ public void DbTypeMappingTest(Type clrType, DbType dbType)
5151
[InlineData((ulong)1, DbType.AnsiStringFixedLength, "1")]
5252
public void ConversionTest(object original, DbType dbType, object expected)
5353
{
54-
Assert.Equal(expected, TypeMapper.Mapper.GetDbTypeMapping(dbType).DoConversion(original));
54+
Assert.Equal(expected, TypeMapper.Instance.GetDbTypeMapping(dbType).DoConversion(original));
5555
}
5656

5757
[Theory]
@@ -100,8 +100,8 @@ public void ConversionTest(object original, DbType dbType, object expected)
100100
[InlineData("year", false, 0, DbType.Int32)]
101101
public void ColumnTypeMetadataTest(string columnTypeName, bool unsigned, int length, DbType dbType)
102102
{
103-
Assert.Equal(dbType, TypeMapper.Mapper.GetDbTypeMapping(columnTypeName, unsigned, length).DbTypes.FirstOrDefault());
104-
Assert.Equal(dbType, TypeMapper.Mapper.GetDbTypeMapping(columnTypeName.ToUpperInvariant(), unsigned, length).DbTypes.FirstOrDefault());
103+
Assert.Equal(dbType, TypeMapper.Instance.GetDbTypeMapping(columnTypeName, unsigned, length).DbTypes.FirstOrDefault());
104+
Assert.Equal(dbType, TypeMapper.Instance.GetDbTypeMapping(columnTypeName.ToUpperInvariant(), unsigned, length).DbTypes.FirstOrDefault());
105105
}
106106
}
107107
}

0 commit comments

Comments
 (0)