Skip to content

Commit 74544b3

Browse files
committed
Update specification tests.
1 parent 2de0e04 commit 74544b3

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

tests/Conformance.Tests/Conformance.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
</PropertyGroup>
1111

1212
<ItemGroup>
13-
<PackageReference Include="AdoNet.Specification.Tests" Version="2.0.0-alpha3" />
13+
<PackageReference Include="AdoNet.Specification.Tests" Version="2.0.0-alpha4" />
1414
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />
1515
<PackageReference Include="xunit" Version="2.4.1" />
1616
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" />

tests/Conformance.Tests/DataReaderTests.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using AdoNet.Specification.Tests;
2+
using Xunit;
23

34
namespace Conformance.Tests
45
{
@@ -8,5 +9,11 @@ public DataReaderTests(SelectValueFixture fixture)
89
: base(fixture)
910
{
1011
}
12+
13+
[Fact(Skip = "Deliberately throws InvalidCastException")]
14+
public override void GetTextReader_returns_empty_for_null_String() { }
15+
16+
[Fact(Skip = "https://github.com/mysql-net/MySqlConnector/issues/678")]
17+
public override void GetSchemaTable_throws_after_Delete() { }
1118
}
1219
}

tests/Conformance.Tests/SelectValueFixture.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
namespace Conformance.Tests
88
{
9-
public class SelectValueFixture : ISelectValueFixture
9+
public class SelectValueFixture : ISelectValueFixture, IDeleteFixture
1010
{
1111
public SelectValueFixture()
1212
{
@@ -59,6 +59,8 @@ insert into select_value values
5959

6060
public string SelectNoRows => "SELECT * FROM mysql.user WHERE 0 = 1;";
6161

62+
public string DeleteNoRows => "DELETE FROM select_value WHERE 0 = 1;";
63+
6264
public IReadOnlyCollection<DbType> SupportedDbTypes { get; } = new[]
6365
{
6466
DbType.Binary,
@@ -81,6 +83,8 @@ insert into select_value values
8183
DbType.UInt64,
8284
};
8385

86+
public Type NullValueExceptionType => typeof(InvalidCastException);
87+
8488
private void ExecuteNonQuery(string sql)
8589
{
8690
using (var connection = Factory.CreateConnection())

0 commit comments

Comments
 (0)