Rename method to ReadByteArray.

This better describes the behaviour and side-effects (allocating a new array) of the method.

Author: bgrainger

src/MySqlConnector/Core/ServerSession.cs

@@ -924,10 +924,10 @@ private async Task GetRealServerDetailsAsync(IOBehavior ioBehavior, Cancellation
 				var reader = new ByteArrayReader(payload.ArraySegment);
 				var length = reader.ReadLengthEncodedIntegerOrNull();
 				if (length != -1)
-					connectionId = int.Parse(Encoding.UTF8.GetString(reader.ReadByteString(length)), CultureInfo.InvariantCulture);
+					connectionId = int.Parse(Encoding.UTF8.GetString(reader.ReadByteArray(length)), CultureInfo.InvariantCulture);
 				length = reader.ReadLengthEncodedIntegerOrNull();
 				if (length != -1)
-					serverVersion = Encoding.UTF8.GetString(reader.ReadByteString(length));
+					serverVersion = Encoding.UTF8.GetString(reader.ReadByteArray(length));
 
 				// OK/EOF payload
 				payload = await ReceiveReplyAsync(ioBehavior, CancellationToken.None).ConfigureAwait(false);

src/MySqlConnector/Protocol/Payloads/AuthenticationMethodSwitchRequestPayload.cs

@@ -26,7 +26,7 @@ public static AuthenticationMethodSwitchRequestPayload Create(PayloadData payloa
 			else
 			{
 				name = Encoding.UTF8.GetString(reader.ReadNullTerminatedByteString());
-				data = reader.ReadByteString(reader.BytesRemaining);
+				data = reader.ReadByteArray(reader.BytesRemaining);
 			}
 			return new AuthenticationMethodSwitchRequestPayload(name, data);
 		}

src/MySqlConnector/Protocol/Payloads/AuthenticationMoreDataPayload.cs

@@ -12,7 +12,7 @@ public static AuthenticationMoreDataPayload Create(PayloadData payload)
 		{
 			var reader = new ByteArrayReader(payload.ArraySegment);
 			reader.ReadByte(Signature);
-			return new AuthenticationMoreDataPayload(reader.ReadByteString(reader.BytesRemaining));
+			return new AuthenticationMoreDataPayload(reader.ReadByteArray(reader.BytesRemaining));
 		}
 
 		private AuthenticationMoreDataPayload(byte[] data) => Data = data;

src/MySqlConnector/Protocol/Payloads/ErrorPayload.cs

@@ -19,17 +19,17 @@ public static ErrorPayload Create(PayloadData payload)
 			reader.ReadByte(Signature);
 
 			var errorCode = reader.ReadUInt16();
-			var stateMarker = Encoding.ASCII.GetString(reader.ReadByteString(1));
+			var stateMarker = Encoding.ASCII.GetString(reader.ReadByteArray(1));
 			string state, message;
 			if (stateMarker == "#")
 			{
-				state = Encoding.ASCII.GetString(reader.ReadByteString(5));
-				message = Encoding.UTF8.GetString(reader.ReadByteString(payload.ArraySegment.Count - 9));
+				state = Encoding.ASCII.GetString(reader.ReadByteArray(5));
+				message = Encoding.UTF8.GetString(reader.ReadByteArray(payload.ArraySegment.Count - 9));
 			}
 			else
 			{
 				state = "HY000";
-				message = stateMarker + Encoding.UTF8.GetString(reader.ReadByteString(payload.ArraySegment.Count - 4));
+				message = stateMarker + Encoding.UTF8.GetString(reader.ReadByteArray(payload.ArraySegment.Count - 4));
 			}
 			return new ErrorPayload(errorCode, state, message);
 		}

src/MySqlConnector/Protocol/Payloads/InitialHandshakePayload.cs

@@ -18,7 +18,7 @@ public static InitialHandshakePayload Create(PayloadData payload)
 			reader.ReadByte(c_protocolVersion);
 			var serverVersion = reader.ReadNullTerminatedByteString();
 			var connectionId = reader.ReadInt32();
-			var authPluginData = reader.ReadByteString(8);
+			var authPluginData = reader.ReadByteArray(8);
 			string authPluginName = null;
 			reader.ReadByte(0);
 			var protocolCapabilities = (ProtocolCapabilities) reader.ReadUInt16();
@@ -29,10 +29,10 @@ public static InitialHandshakePayload Create(PayloadData payload)
 				var capabilityFlagsHigh = reader.ReadUInt16();
 				protocolCapabilities |= (ProtocolCapabilities) (capabilityFlagsHigh << 16);
 				var authPluginDataLength = reader.ReadByte();
-				var unused = reader.ReadByteString(10);
+				var unused = reader.ReadByteArray(10);
 				if ((protocolCapabilities & ProtocolCapabilities.SecureConnection) != 0)
 				{
-					var authPluginData2 = reader.ReadByteString(Math.Max(13, authPluginDataLength - 8));
+					var authPluginData2 = reader.ReadByteArray(Math.Max(13, authPluginDataLength - 8));
 					var concatenated = new byte[authPluginData.Length + authPluginData2.Length];
 					Buffer.BlockCopy(authPluginData, 0, concatenated, 0, authPluginData.Length);
 					Buffer.BlockCopy(authPluginData2, 0, concatenated,authPluginData.Length, authPluginData2.Length);

src/MySqlConnector/Protocol/Payloads/LocalInfilePayload.cs

@@ -14,7 +14,7 @@ public static LocalInfilePayload Create(PayloadData payload)
 		{
 			var reader = new ByteArrayReader(payload.ArraySegment);
 			reader.ReadByte(Signature);
-			var fileName = Encoding.UTF8.GetString(reader.ReadByteString(reader.BytesRemaining));
+			var fileName = Encoding.UTF8.GetString(reader.ReadByteArray(reader.BytesRemaining));
 			return new LocalInfilePayload(fileName);
 		}
 

src/MySqlConnector/Protocol/Serialization/ByteArrayReader.cs

@@ -118,7 +118,7 @@ public byte[] ReadNullOrEofTerminatedByteString()
 			return substring;
 		}
 
-		public byte[] ReadByteString(int length)
+		public byte[] ReadByteArray(int length)
 		{
 			VerifyRead(length);
 			var result = new byte[length];