Enable SA1519: require braces for multi-line child statements.

Author: bgrainger

.editorconfig

@@ -89,7 +89,6 @@ dotnet_diagnostic.SA1500.severity = none # Braces for multi-line statements shou
 dotnet_diagnostic.SA1503.severity = none # Braces should not be omitted.
 dotnet_diagnostic.SA1513.severity = none # Closing brace should be followed by blank line.
 dotnet_diagnostic.SA1516.severity = none # Elements should be separated by blank line.
-dotnet_diagnostic.SA1519.severity = silent # Braces should not be omitted from multi-line child statements.
 dotnet_diagnostic.SA1600.severity = none # Elements should be documented.
 dotnet_diagnostic.SA1602.severity = none # Enumeration items should be documented.
 dotnet_diagnostic.SA1611.severity = none # Element parameters should be documented.

src/MySqlConnector/Core/ConnectionPool.cs

@@ -259,9 +259,13 @@ private async Task CleanPoolAsync(IOBehavior ioBehavior, Func<ServerSession, boo
 			{
 				// if respectMinPoolSize is true, return if (leased sessions + waiting sessions <= minPoolSize)
 				if (respectMinPoolSize)
+				{
 					lock (m_sessions)
+					{
 						if (ConnectionSettings.MaximumPoolSize - m_sessionSemaphore.CurrentCount + m_sessions.Count <= ConnectionSettings.MinimumPoolSize)
 							return;
+					}
+				}
 
 				// try to get an open slot; if this fails, connection pool is full and sessions will be disposed when returned to pool
 				if (ioBehavior == IOBehavior.Asynchronous)

src/MySqlConnector/Core/TypeMapper.cs

@@ -136,8 +136,10 @@ private DbTypeMapping AddDbTypeMapping(DbTypeMapping dbTypeMapping)
 		m_dbTypeMappingsByClrType[dbTypeMapping.ClrType] = dbTypeMapping;
 
 		if (dbTypeMapping.DbTypes is not null)
+		{
 			foreach (var dbType in dbTypeMapping.DbTypes)
 				m_dbTypeMappingsByDbType[dbType] = dbTypeMapping;
+		}
 
 		return dbTypeMapping;
 	}

src/MySqlConnector/MySqlAttributeCollection.cs

@@ -23,8 +23,10 @@ public void Add(MySqlAttribute attribute)
 			if (string.IsNullOrEmpty((attribute ?? throw new ArgumentNullException(nameof(attribute))).AttributeName))
 				throw new ArgumentException("Attribute name must not be empty", nameof(attribute));
 			foreach (var existingAttribute in m_attributes)
+			{
 				if (existingAttribute.AttributeName == attribute.AttributeName)
 					throw new ArgumentException("An attribute with the name {0} already exists in the collection".FormatInvariant(attribute.AttributeName), nameof(attribute));
+			}
 			m_attributes.Add(attribute);
 		}
 

src/MySqlConnector/MySqlConnectionStringBuilder.cs

@@ -839,9 +839,13 @@ internal string GetConnectionString(bool includePassword)
 		{
 			var csb = new MySqlConnectionStringBuilder(connectionString);
 			foreach (string? key in Keys)
+			{
 				foreach (var passwordKey in MySqlConnectionStringOption.Password.Keys)
+				{
 					if (string.Equals(key, passwordKey, StringComparison.OrdinalIgnoreCase))
 						csb.Remove(key!);
+				}
+			}
 			m_cachedConnectionStringWithoutPassword = csb.ConnectionString;
 			m_cachedConnectionString = connectionString;
 		}

src/MySqlConnector/Utilities/Adler32.cs

@@ -80,8 +80,7 @@ private static unsafe uint CalculateSse(ReadOnlySpan<byte> buffer)
 		length -= blocks * BLOCK_SIZE;
 
 		int index = 0;
-		fixed (byte* bufferPtr = buffer)
-		fixed (byte* tapPtr = Tap1Tap2)
+		fixed (byte* bufferPtr = buffer, tapPtr = Tap1Tap2)
 		{
 			index += (int)blocks * BLOCK_SIZE;
 			var localBufferPtr = bufferPtr;

src/MySqlConnector/Utilities/Utility.cs

@@ -56,9 +56,11 @@ public static unsafe int GetByteCount(this Encoding encoding, ReadOnlySpan<char>
 	public static unsafe int GetBytes(this Encoding encoding, ReadOnlySpan<char> chars, Span<byte> bytes)
 	{
 		fixed (char* charsPtr = &MemoryMarshal.GetReference(chars))
-		fixed (byte* bytesPtr = &MemoryMarshal.GetReference(bytes))
 		{
-			return encoding.GetBytes(charsPtr, chars.Length, bytesPtr, bytes.Length);
+			fixed (byte* bytesPtr = &MemoryMarshal.GetReference(bytes))
+			{
+				return encoding.GetBytes(charsPtr, chars.Length, bytesPtr, bytes.Length);
+			}
 		}
 	}
 #endif
@@ -67,11 +69,13 @@ public static unsafe int GetBytes(this Encoding encoding, ReadOnlySpan<char> cha
 	public static unsafe void Convert(this Encoder encoder, ReadOnlySpan<char> chars, Span<byte> bytes, bool flush, out int charsUsed, out int bytesUsed, out bool completed)
 	{
 		fixed (char* charsPtr = &MemoryMarshal.GetReference(chars))
-		fixed (byte* bytesPtr = &MemoryMarshal.GetReference(bytes))
 		{
-			// MemoryMarshal.GetNonNullPinnableReference is internal, so fake it by using an invalid but non-null pointer; this
-			// prevents Convert from throwing an exception when the output buffer is empty
-			encoder.Convert(charsPtr, chars.Length, bytesPtr is null ? (byte*) 1 : bytesPtr, bytes.Length, flush, out charsUsed, out bytesUsed, out completed);
+			fixed (byte* bytesPtr = &MemoryMarshal.GetReference(bytes))
+			{
+				// MemoryMarshal.GetNonNullPinnableReference is internal, so fake it by using an invalid but non-null pointer; this
+				// prevents Convert from throwing an exception when the output buffer is empty
+				encoder.Convert(charsPtr, chars.Length, bytesPtr is null ? (byte*) 1 : bytesPtr, bytes.Length, flush, out charsUsed, out bytesUsed, out completed);
+			}
 		}
 	}