Rename Boolean property to begin with 'Is'.

Author: bgrainger

src/MySqlConnector/Core/CachedProcedure.cs

@@ -11,7 +11,7 @@ internal sealed class CachedProcedure
 	public static async Task<CachedProcedure?> FillAsync(IOBehavior ioBehavior, MySqlConnection connection, string schema, string component, CancellationToken cancellationToken)
 	{
 		// try to use mysql.proc first, as it is much faster
-		if (!connection.Session.ServerVersion.MariaDb
+		if (!connection.Session.ServerVersion.IsMariaDb
 		    && connection.Session.ServerVersion.Version < ServerVersions.RemovesMySqlProcTable
 		    && !connection.Session.ProcAccessDenied)
 		{

src/MySqlConnector/Core/ServerSession.cs

@@ -614,8 +614,8 @@ public async Task<bool> TryResetConnectionAsync(ConnectionSettings cs, MySqlConn
 
 			PayloadData payload;
 			if (DatabaseOverride is null
-			    && ((!ServerVersion.MariaDb && ServerVersion.Version.CompareTo(ServerVersions.SupportsResetConnection) >= 0)
-			    || (ServerVersion.MariaDb && ServerVersion.Version.CompareTo(ServerVersions.MariaDbSupportsResetConnection) >= 0)))
+			    && ((!ServerVersion.IsMariaDb && ServerVersion.Version.CompareTo(ServerVersions.SupportsResetConnection) >= 0)
+			    || (ServerVersion.IsMariaDb && ServerVersion.Version.CompareTo(ServerVersions.MariaDbSupportsResetConnection) >= 0)))
 			{
 				m_logArguments[1] = ServerVersion.OriginalString;
 

src/MySqlConnector/Core/ServerVersion.cs

@@ -13,19 +13,19 @@ public ServerVersion(ReadOnlySpan<byte> versionString)
 		{
 			// for MariaDB < 11.0.1
 			versionString = versionString[6..];
-			MariaDb = true;
+			IsMariaDb = true;
 		}
 		else if (versionString.IndexOf("MariaDB"u8) != -1)
 		{
-			MariaDb = true;
+			IsMariaDb = true;
 		}
 
 		var minor = 0;
 		var build = 0;
 		if (Utf8Parser.TryParse(versionString, out int major, out var bytesConsumed))
 		{
 			versionString = versionString[bytesConsumed..];
-			if (versionString is [ 0x2E, ..])
+			if (versionString is [ 0x2E, .. ])
 			{
 				versionString = versionString[1..];
 				if (Utf8Parser.TryParse(versionString, out minor, out bytesConsumed))
@@ -46,9 +46,9 @@ public ServerVersion(ReadOnlySpan<byte> versionString)
 		Version = new Version(major, minor, build);
 	}
 
-	public bool MariaDb { get; }
 	public string OriginalString { get; }
 	public Version Version { get; }
+	public bool IsMariaDb { get; }
 
 	public static ServerVersion Empty { get; } = new();
 

tests/MySqlConnector.Tests/ServerVersionTests.cs

@@ -34,6 +34,6 @@ public void ParseServerVersion(string input, string expectedString, bool expecte
 		var serverVersion = new ServerVersion(Encoding.UTF8.GetBytes(input));
 		var expected = Version.Parse(expectedString);
 		Assert.Equal(expected, serverVersion.Version);
-		Assert.Equal(expectedMariaDb, serverVersion.MariaDb);
+		Assert.Equal(expectedMariaDb, serverVersion.IsMariaDb);
 	}
 }