Rename FewestConnections to LeastConnections.

"Least Connections" is the more widely used term.

Author: bgrainger

docs/content/connection-options.md

@@ -203,7 +203,7 @@ These are the other options that MySqlConnector supports. They are set to sensib
         <dd>Each new connection tries the hosts in order, starting with the first one. This is the default if <code>Pooling=False</code>.</dd>
         <dt>Random</dt>
         <dd>Servers are tried in a random order.</dd>
-        <dt>FewestConnections</dt>
+        <dt>LeastConnections</dt>
         <dd>Servers are tried in ascending order of number of currently-open connections in this connection pool. Requires <code>Pooling=True</code>.
       </dl>
   </tr>

src/MySqlConnector/Core/ConnectionPool.cs

@@ -150,7 +150,7 @@ public async Task ReapAsync(IOBehavior ioBehavior, CancellationToken cancellatio
 
 		/// <summary>
 		/// Examines all the <see cref="ServerSession"/> objects in <see cref="m_leasedSessions"/> to determine if any
-		/// have an owning <see cref="MySqlConnection"/> that has been garbage-collected. If so, assumes that the connection 
+		/// have an owning <see cref="MySqlConnection"/> that has been garbage-collected. If so, assumes that the connection
 		/// was not properly disposed and returns the session to the pool.
 		/// </summary>
 		private void RecoverLeakedSessions()
@@ -344,7 +344,7 @@ private ConnectionPool(ConnectionSettings cs)
 			m_sessionSemaphore = new SemaphoreSlim(cs.MaximumPoolSize);
 			m_sessions = new LinkedList<ServerSession>();
 			m_leasedSessions = new Dictionary<int, ServerSession>();
-			if (cs.LoadBalance == MySqlLoadBalance.FewestConnections)
+			if (cs.LoadBalance == MySqlLoadBalance.LeastConnections)
 			{
 				m_hostSessions = new Dictionary<string, int>();
 				foreach (var hostName in cs.HostNames)
@@ -353,7 +353,7 @@ private ConnectionPool(ConnectionSettings cs)
 			m_loadBalancer = cs.ConnectionType != ConnectionType.Tcp ? null :
 				cs.HostNames.Count == 1 || cs.LoadBalance == MySqlLoadBalance.InOrder ? InOrderLoadBalancer.Instance :
 				cs.LoadBalance == MySqlLoadBalance.Random ? RandomLoadBalancer.Instance :
-				cs.LoadBalance == MySqlLoadBalance.FewestConnections ? new FewestConnectionsLoadBalancer(this) :
+				cs.LoadBalance == MySqlLoadBalance.LeastConnections ? new LeastConnectionsLoadBalancer(this) :
 				(ILoadBalancer) new RoundRobinLoadBalancer();
 		}
 
@@ -366,9 +366,9 @@ private void AdjustHostConnectionCount(ServerSession session, int delta)
 			}
 		}
 
-		private sealed class FewestConnectionsLoadBalancer : ILoadBalancer
+		private sealed class LeastConnectionsLoadBalancer : ILoadBalancer
 		{
-			public FewestConnectionsLoadBalancer(ConnectionPool pool) => m_pool = pool;
+			public LeastConnectionsLoadBalancer(ConnectionPool pool) => m_pool = pool;
 
 			public IEnumerable<string> LoadBalance(IReadOnlyList<string> hosts)
 			{

src/MySqlConnector/MySql.Data.MySqlClient/MySqlLoadBalance.cs

@@ -20,6 +20,6 @@ public enum MySqlLoadBalance
 		/// <summary>
 		/// Servers are tried in ascending order of number of currently-open connections.
 		/// </summary>
-		FewestConnections,
+		LeastConnections,
 	}
 }