Skip to content

Commit 8cf99bd

Browse files
committed
Update baseline tests to v8.0.12.
1 parent 27464f1 commit 8cf99bd

File tree

5 files changed

+15
-12
lines changed

5 files changed

+15
-12
lines changed

docs/content/tutorials/migrating-from-connector-net.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,14 +91,14 @@ for various precondition checks that indicate misuse of the API (and not a probl
9191

9292
### Fixed Bugs
9393

94-
The following bugs in Connector/NET are fixed by switching to MySqlConnector.
94+
The following bugs in Connector/NET are fixed by switching to MySqlConnector. (~~Strikethrough~~ indicates bugs that have since been fixed in a newer version of Connector/NET, but were fixed first in MySqlConnector.)
9595

9696
* [#37283](https://bugs.mysql.com/bug.php?id=37283), [#70587](https://bugs.mysql.com/bug.php?id=70587): Distributed transactions are not supported
9797
* [#50773](https://bugs.mysql.com/bug.php?id=50773): Can’t use multiple connections within one TransactionScope
9898
* [#61477](https://bugs.mysql.com/bug.php?id=61477): `ColumnOrdinal` in schema table is 1-based
9999
* [#66476](https://bugs.mysql.com/bug.php?id=66476): Connection pool uses queue instead of stack
100100
* [#70111](https://bugs.mysql.com/bug.php?id=70111): `Async` methods execute synchronously
101-
* [#70686](https://bugs.mysql.com/bug.php?id=70686): `TIME(3)` and `TIME(6)` fields serialize milliseconds incorrectly
101+
* ~~[#70686](https://bugs.mysql.com/bug.php?id=70686): `TIME(3)` and `TIME(6)` fields serialize milliseconds incorrectly~~
102102
* [#72494](https://bugs.mysql.com/bug.php?id=72494), [#83330](https://bugs.mysql.com/bug.php?id=83330): EndOfStreamException inserting large blob with UseCompression=True
103103
* [#73610](https://bugs.mysql.com/bug.php?id=73610): Invalid password exception has wrong number
104104
* [#73788](https://bugs.mysql.com/bug.php?id=73788): Can’t use `DateTimeOffset`
@@ -107,7 +107,7 @@ The following bugs in Connector/NET are fixed by switching to MySqlConnector.
107107
* [#77421](https://bugs.mysql.com/bug.php?id=77421): Connection is not reset when pulled from the connection pool
108108
* [#78426](https://bugs.mysql.com/bug.php?id=78426): Unknown database exception has wrong number
109109
* [#78760](https://bugs.mysql.com/bug.php?id=78760): Error when using tabs and newlines in SQL statements
110-
* [#78917](https://bugs.mysql.com/bug.php?id=78917), [#79196](https://bugs.mysql.com/bug.php?id=79196), [#82292](https://bugs.mysql.com/bug.php?id=82292), [#89040](https://bugs.mysql.com/bug.php?id=89040): `TINYINT(1)` values start being returned as `sbyte` after `NULL`
110+
* ~~[#78917](https://bugs.mysql.com/bug.php?id=78917), [#79196](https://bugs.mysql.com/bug.php?id=79196), [#82292](https://bugs.mysql.com/bug.php?id=82292), [#89040](https://bugs.mysql.com/bug.php?id=89040): `TINYINT(1)` values start being returned as `sbyte` after `NULL`~~
111111
* [#80030](https://bugs.mysql.com/bug.php?id=80030): Slow to connect with pooling disabled
112112
* [#81650](https://bugs.mysql.com/bug.php?id=81650), [#88962](https://bugs.mysql.com/bug.php?id=88962): `Server` connection string option may now contain multiple, comma separated hosts that will be tried in order until a connection succeeds
113113
* [#83229](https://bugs.mysql.com/bug.php?id=83329): "Unknown command" exception inserting large blob with UseCompression=True
@@ -119,8 +119,9 @@ The following bugs in Connector/NET are fixed by switching to MySqlConnector.
119119
* [#87316](https://bugs.mysql.com/bug.php?id=87316): MySqlCommand.CommandTimeout can be set to a negative value
120120
* [#87868](https://bugs.mysql.com/bug.php?id=87868): `ColumnSize` in schema table is incorrect for `CHAR(36)` and `BLOB` columns
121121
* [#87876](https://bugs.mysql.com/bug.php?id=87876): `IsLong` is schema table is incorrect for `LONGTEXT` and `LONGBLOB` columns
122-
* [#88058](https://bugs.mysql.com/bug.php?id=88058): `decimal(n, 0)` has wrong `NumericPrecision`
122+
* ~~[#88058](https://bugs.mysql.com/bug.php?id=88058): `decimal(n, 0)` has wrong `NumericPrecision`~~
123123
* [#88124](https://bugs.mysql.com/bug.php?id=88124): CommandTimeout isn’t reset when calling Read/NextResult
124+
* ~~[#88472](https://bugs.mysql.com/bug.php?id=88472): `TINYINT(1)` is not returned as `bool` if `MySqlCommand.Prepare` is called~~
124125
* [#88611](https://bugs.mysql.com/bug.php?id=88611): `MySqlCommand` can be executed even if it has "wrong" transaction
125126
* [#88660](https://bugs.mysql.com/bug.php?id=88660): `MySqlClientFactory.Instance.CreateDataAdapter()` and `CreateCommandBuilder` return `null`
126127
* [#89085](https://bugs.mysql.com/bug.php?id=89085): `MySqlConnection.Database` not updated after `USE database;`

tests/SideBySide/DataTypes.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,12 +202,16 @@ public void QuerySet(string column, string dataTypeName, object[] expected)
202202
DoQuery("set", column, dataTypeName, expected, reader => reader.GetString(column));
203203
}
204204

205-
[SkippableTheory(Baseline = "https://bugs.mysql.com/bug.php?id=78917")]
205+
[Theory]
206206
[InlineData("Boolean", "BOOL", new object[] { null, false, true, false, true, true, true })]
207207
[InlineData("TinyInt1", "BOOL", new object[] { null, false, true, false, true, true, true })]
208208
public void QueryBoolean(string column, string dataTypeName, object[] expected)
209209
{
210-
DoQuery("bools", column, dataTypeName, expected, reader => reader.GetBoolean(0));
210+
#if BASELINE
211+
// Connector/NET returns "TINYINT" for "BOOL"
212+
dataTypeName = "TINYINT";
213+
#endif
214+
DoQuery<InvalidCastException>("bools", column, dataTypeName, expected, reader => reader.GetBoolean(0));
211215
}
212216

213217
[Theory]

tests/SideBySide/InsertTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ public void InsertWithDapper()
135135
Assert.Equal(1L, rowid);
136136
}
137137

138-
[SkippableTheory(Baseline = "http://bugs.mysql.com/bug.php?id=70686")]
138+
[Theory]
139139
[InlineData(3)]
140140
[InlineData(6)]
141141
public void InsertTime(int precision)

tests/SideBySide/PreparedCommandTests.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,11 +159,9 @@ public static IEnumerable<object[]> GetInsertAndQueryData()
159159
yield return new object[] { isPrepared, "DATETIME(3)", new DateTime(2018, 7, 23, 20, 46, 52, 123) };
160160
yield return new object[] { isPrepared, "ENUM('small', 'medium', 'large')", "medium" };
161161
yield return new object[] { isPrepared, "SET('one','two','four','eight')", "two,eight" };
162-
163-
#if !BASELINE
164-
// https://bugs.mysql.com/bug.php?id=78917
165162
yield return new object[] { isPrepared, "BOOL", true };
166163

164+
#if !BASELINE
167165
// https://bugs.mysql.com/bug.php?id=91770
168166
yield return new object[] { isPrepared, "TIME(3)", TimeSpan.Zero.Subtract(new TimeSpan(15, 10, 34, 56, 789)) };
169167

tests/SideBySide/SideBySide.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup Condition=" '$(Configuration)' != 'Baseline' ">
44
<TargetFrameworks>net452;net461;netcoreapp1.1.2;netcoreapp2.0;netcoreapp2.1</TargetFrameworks>
@@ -39,7 +39,7 @@
3939
</ItemGroup>
4040

4141
<ItemGroup Condition=" '$(Configuration)' == 'Baseline' ">
42-
<PackageReference Include="MySql.Data" Version="8.0.11" />
42+
<PackageReference Include="MySql.Data" Version="8.0.12" />
4343
</ItemGroup>
4444

4545
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.1.2' ">

0 commit comments

Comments
 (0)