Use type patterns.

Author: bgrainger

src/MySqlConnector/MySqlClient/MySqlConnectionStringBuilder.cs

@@ -397,19 +397,19 @@ public override object GetObject(MySqlConnectionStringBuilder builder)
 
 		private static T ChangeType(object objectValue)
 		{
-			if (typeof(T) == typeof(bool) && objectValue is string)
+			if (typeof(T) == typeof(bool) && objectValue is string booleanString)
 			{
-				if (string.Equals((string) objectValue, "yes", StringComparison.OrdinalIgnoreCase))
+				if (string.Equals(booleanString, "yes", StringComparison.OrdinalIgnoreCase))
 					return (T) (object) true;
-				if (string.Equals((string) objectValue, "no", StringComparison.OrdinalIgnoreCase))
+				if (string.Equals(booleanString, "no", StringComparison.OrdinalIgnoreCase))
 					return (T) (object) false;
 			}
 
-			if (typeof(T) == typeof(MySqlSslMode) && objectValue is string)
+			if (typeof(T) == typeof(MySqlSslMode) && objectValue is string sslModeString)
 			{
 				foreach (var val in Enum.GetValues(typeof(T)))
 				{
-					if (string.Equals((string) objectValue, val.ToString(), StringComparison.OrdinalIgnoreCase))
+					if (string.Equals(sslModeString, val.ToString(), StringComparison.OrdinalIgnoreCase))
 						return (T) val;
 				}
 				throw new InvalidOperationException("Value '{0}' not supported for option '{1}'.".FormatInvariant(objectValue, typeof(T).Name));

src/MySqlConnector/MySqlClient/MySqlParameter.cs

@@ -83,30 +83,30 @@ internal void AppendSqlString(BinaryWriter writer, StatementPreparerOptions opti
 			{
 				writer.WriteUtf8("NULL");
 			}
-			else if (Value is string)
+			else if (Value is string stringValue)
 			{
 				writer.Write((byte) '\'');
-				writer.WriteUtf8(((string) Value).Replace("\\", "\\\\").Replace("'", "\\'"));
+				writer.WriteUtf8(stringValue.Replace("\\", "\\\\").Replace("'", "\\'"));
 				writer.Write((byte) '\'');
 			}
 			else if (Value is byte || Value is sbyte || Value is short || Value is int || Value is long || Value is ushort || Value is uint || Value is ulong || Value is decimal)
 			{
 				writer.WriteUtf8("{0}".FormatInvariant(Value));
 			}
-			else if (Value is byte[])
+			else if (Value is byte[] byteArrayValue)
 			{
 				writer.WriteUtf8("_binary'");
-				foreach (var by in (byte[]) Value)
+				foreach (var by in byteArrayValue)
 				{
 					if (by == 0x27 || by == 0x5C)
 						writer.Write((byte) 0x5C);
 					writer.Write(by);
 				}
 				writer.Write((byte) '\'');
 			}
-			else if (Value is bool)
+			else if (Value is bool boolValue)
 			{
-				writer.WriteUtf8(((bool) Value) ? "true" : "false");
+				writer.WriteUtf8(boolValue ? "true" : "false");
 			}
 			else if (Value is float || Value is double)
 			{
@@ -116,33 +116,32 @@ internal void AppendSqlString(BinaryWriter writer, StatementPreparerOptions opti
 			{
 				writer.WriteUtf8("timestamp '{0:yyyy'-'MM'-'dd' 'HH':'mm':'ss'.'ffffff}'".FormatInvariant(Value));
 			}
-			else if (Value is DateTimeOffset)
+			else if (Value is DateTimeOffset dateTimeOffsetValue)
 			{
 				// store as UTC as it will be read as such when deserialized from a timespan column
-				writer.WriteUtf8("timestamp '{0:yyyy'-'MM'-'dd' 'HH':'mm':'ss'.'ffffff}'".FormatInvariant(((DateTimeOffset)Value).UtcDateTime));
+				writer.WriteUtf8("timestamp '{0:yyyy'-'MM'-'dd' 'HH':'mm':'ss'.'ffffff}'".FormatInvariant(dateTimeOffsetValue.UtcDateTime));
 			}
-			else if (Value is TimeSpan)
+			else if (Value is TimeSpan ts)
 			{
 				writer.WriteUtf8("time '");
-				var ts = (TimeSpan) Value;
 				if (ts.Ticks < 0)
 				{
 					writer.Write((byte) '-');
 					ts = TimeSpan.FromTicks(-ts.Ticks);
 				}
 				writer.WriteUtf8("{0}:{1:mm':'ss'.'ffffff}'".FormatInvariant(ts.Days * 24 + ts.Hours, ts));
 			}
-			else if (Value is Guid)
+			else if (Value is Guid guidValue)
 			{
 				if ((options & StatementPreparerOptions.OldGuids) != 0)
 				{
 					writer.WriteUtf8("_binary'");
-					writer.Write(((Guid) Value).ToByteArray());
+					writer.Write(guidValue.ToByteArray());
 					writer.Write((byte) '\'');
 				}
 				else
 				{
-					writer.WriteUtf8("'{0:D}'".FormatInvariant(Value));
+					writer.WriteUtf8("'{0:D}'".FormatInvariant(guidValue));
 				}
 			}
 			else if (DbType == DbType.Int16)

src/MySqlConnector/MySqlClient/Results/Row.cs

@@ -133,14 +133,13 @@ public char GetChar(int ordinal)
 		public Guid GetGuid(int ordinal)
 		{
 			var value = GetValue(ordinal);
-			if (value is Guid)
-				return (Guid) value;
+			if (value is Guid guid)
+				return guid;
 
-			if (Guid.TryParse(value as string, out var guid))
+			if (value is string stringValue && Guid.TryParse(stringValue, out guid))
 				return guid;
 
-			byte[] bytes = value as byte[];
-			if (bytes != null && bytes.Length == 16)
+			if (value is byte[] bytes && bytes.Length == 16)
 				return new Guid(bytes);
 
 			throw new MySqlException("The value could not be converted to a GUID: {0}".FormatInvariant(value));
@@ -244,9 +243,7 @@ public decimal GetDecimal(int ordinal)
 		public double GetDouble(int ordinal)
 		{
 			object value = GetValue(ordinal);
-			if (value is float)
-				return (float) value;
-			return (double) value;
+			return value is float floatValue ? floatValue : (double) value;
 		}
 
 		public float GetFloat(int ordinal)