Handle "packet received out-of-order" for large payloads.

Author: bgrainger

src/MySqlConnector/MySqlClient/CommandExecutors/TextCommandExecutor.cs

@@ -63,7 +63,7 @@ public virtual async Task<DbDataReader> ExecuteReaderAsync(string commandText, M
 				await m_command.Connection.Session.SendAsync(payload, ioBehavior, cancellationToken).ConfigureAwait(false);
 				return await MySqlDataReader.CreateAsync(m_command, behavior, ioBehavior, cancellationToken).ConfigureAwait(false);
 			}
-			catch (Exception ex) when (payload.ArraySegment.Count > 4194304 && (ex is SocketException || ex is IOException))
+			catch (Exception ex) when (payload.ArraySegment.Count > 4194304 && (ex is SocketException || ex is IOException || ex is MySqlProtocolException))
 			{
 				// the default MySQL Server value for max_allowed_packet (in MySQL 5.7) is 4MiB: https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_max_allowed_packet
 				// use "decimal megabytes" (to round up) when creating the exception message

src/MySqlConnector/MySqlClient/MySqlProtocolException.cs

@@ -0,0 +1,17 @@
+using System;
+
+namespace MySql.Data.MySqlClient
+{
+	public sealed class MySqlProtocolException : InvalidOperationException
+	{
+		internal static MySqlProtocolException CreateForPacketOutOfOrder(int expectedSequenceNumber, int packetSequenceNumber)
+		{
+			return new MySqlProtocolException("Packet received out-of-order. Expected {0}; got {1}.".FormatInvariant(expectedSequenceNumber, packetSequenceNumber));
+		}
+
+		private MySqlProtocolException(string message)
+			: base(message)
+		{
+		}
+	}
+}

src/MySqlConnector/Protocol/Serialization/CompressedPayloadHandler.cs

@@ -2,6 +2,7 @@
 using System.IO;
 using System.IO.Compression;
 using System.Threading.Tasks;
+using MySql.Data.MySqlClient;
 using MySql.Data.Serialization;
 
 namespace MySql.Data.Protocol.Serialization
@@ -87,7 +88,7 @@ private ValueTask<int> ReadBytesAsync(ArraySegment<byte> buffer, ProtocolErrorBe
 						if (protocolErrorBehavior == ProtocolErrorBehavior.Ignore)
 							return default(ValueTask<int>);
 
-						var exception = new InvalidOperationException("Packet received out-of-order. Expected {0}; got {1}.".FormatInvariant(expectedSequenceNumber, packetSequenceNumber));
+						var exception = MySqlProtocolException.CreateForPacketOutOfOrder(expectedSequenceNumber, packetSequenceNumber);
 						return ValueTaskExtensions.FromException<int>(exception);
 					}
 

src/MySqlConnector/Protocol/Serialization/ProtocolUtility.cs

@@ -2,6 +2,7 @@
 using System.Buffers;
 using System.IO;
 using System.Threading.Tasks;
+using MySql.Data.MySqlClient;
 using MySql.Data.Serialization;
 
 namespace MySql.Data.Protocol.Serialization
@@ -29,7 +30,7 @@ public static ValueTask<Packet> ReadPacketAsync(BufferedByteReader bufferedByteR
 						if (protocolErrorBehavior == ProtocolErrorBehavior.Ignore)
 							return default(ValueTask<Packet>);
 
-						var exception = new InvalidOperationException("Packet received out-of-order. Expected {0}; got {1}.".FormatInvariant(expectedSequenceNumber.Value, packetSequenceNumber));
+						var exception = MySqlProtocolException.CreateForPacketOutOfOrder(expectedSequenceNumber.Value, packetSequenceNumber);
 						return ValueTaskExtensions.FromException<Packet>(exception);
 					}