Fix crash in MySqlConnection.Database before connection is opened. Fixes #205

Author: bgrainger

src/MySqlConnector/MySqlClient/MySqlConnection.cs

@@ -157,7 +157,7 @@ public override string ConnectionString
 			}
 		}
 
-		public override string Database => m_session.DatabaseOverride ?? m_connectionSettings.Database;
+		public override string Database => m_session?.DatabaseOverride ?? m_connectionSettings.Database;
 
 		public override ConnectionState State => m_connectionState;
 

tests/SideBySide/ConnectAsync.cs

@@ -179,6 +179,21 @@ public async Task ConnectSslBadClientCertificate()
 			}
 		}
 
+		[Fact]
+		public async Task ConnectionDatabase()
+		{
+			var csb = AppConfig.CreateConnectionStringBuilder();
+			using (var connection = new MySqlConnection(csb.ConnectionString))
+			{
+				Assert.Equal(csb.Database, connection.Database);
+
+				await connection.OpenAsync();
+
+				Assert.Equal(csb.Database, connection.Database);
+				Assert.Equal(csb.Database, await QueryCurrentDatabaseAsync(connection));
+			}
+		}
+
 		[SecondaryDatabaseRequiredFact]
 		public async Task ChangeDatabase()
 		{

tests/SideBySide/ConnectSync.cs

@@ -184,6 +184,21 @@ public void ConnectTimeout()
 			}
 		}
 
+		[Fact]
+		public void ConnectionDatabase()
+		{
+			var csb = AppConfig.CreateConnectionStringBuilder();
+			using (var connection = new MySqlConnection(csb.ConnectionString))
+			{
+				Assert.Equal(csb.Database, connection.Database);
+
+				connection.Open();
+
+				Assert.Equal(csb.Database, connection.Database);
+				Assert.Equal(csb.Database, QueryCurrentDatabase(connection));
+			}
+		}
+
 		[SecondaryDatabaseRequiredFact]
 		public void ChangeDatabase()
 		{