Use pattern matching for nullable Boolean tests.

Author: bgrainger

src/MySqlConnector/Core/ServerSession.cs

@@ -486,7 +486,7 @@ public async Task DisposeAsync(IOBehavior ioBehavior, CancellationToken cancella
 				else
 				{
 					// pipelining is not currently compatible with compression
-					m_supportsPipelining = !cs.UseCompression && (cs.Pipelining ?? true);
+					m_supportsPipelining = !cs.UseCompression && cs.Pipelining is not false;
 
 					// for pipelining, concatenate reset connection and SET NAMES query into one buffer
 					if (m_supportsPipelining)
@@ -1764,13 +1764,13 @@ private void VerifyState(State state1, State state2, State state3, State state4,
 		}
 	}
 
-	internal bool SslIsEncrypted => m_sslStream?.IsEncrypted ?? false;
+	internal bool SslIsEncrypted => m_sslStream?.IsEncrypted is true;
 
-	internal bool SslIsSigned => m_sslStream?.IsSigned ?? false;
+	internal bool SslIsSigned => m_sslStream?.IsSigned is true;
 
-	internal bool SslIsAuthenticated => m_sslStream?.IsAuthenticated ?? false;
+	internal bool SslIsAuthenticated => m_sslStream?.IsAuthenticated is true;
 
-	internal bool SslIsMutuallyAuthenticated => m_sslStream?.IsMutuallyAuthenticated ?? false;
+	internal bool SslIsMutuallyAuthenticated => m_sslStream?.IsMutuallyAuthenticated is true;
 
 	internal SslProtocols SslProtocol => m_sslStream?.SslProtocol ?? SslProtocols.None;
 

src/MySqlConnector/MySqlBulkCopy.cs

@@ -426,7 +426,7 @@ await m_valuesEnumerator.MoveNextAsync().ConfigureAwait(false) :
 				}
 			}
 
-			if (outputIndex != 0 && !(eventArgs?.Abort ?? false))
+			if (outputIndex != 0 && eventArgs?.Abort is not true)
 			{
 				var payload2 = new PayloadData(new ArraySegment<byte>(buffer, 0, outputIndex));
 				await m_connection.Session.SendReplyAsync(payload2, ioBehavior, cancellationToken).ConfigureAwait(false);
@@ -435,7 +435,7 @@ await m_valuesEnumerator.MoveNextAsync().ConfigureAwait(false) :
 		finally
 		{
 			ArrayPool<byte>.Shared.Return(buffer);
-			m_wasAborted = eventArgs?.Abort ?? false;
+			m_wasAborted = eventArgs?.Abort is true;
 		}
 
 		static bool WriteValue(MySqlConnection connection, object value, ref int inputIndex, ref Encoder? utf8Encoder, Span<byte> output, out int bytesWritten)

src/MySqlConnector/MySqlCommand.cs

@@ -174,7 +174,7 @@ private bool NeedsPrepare(out Exception? exception)
 			exception = new InvalidOperationException("Connection must be Open; current state is {0}".FormatInvariant(Connection.State));
 		else if (string.IsNullOrWhiteSpace(CommandText))
 			exception = new InvalidOperationException("CommandText must be specified");
-		else if (Connection?.HasActiveReader ?? false)
+		else if (Connection?.HasActiveReader is true)
 			exception = new InvalidOperationException("Cannot call Prepare when there is an open DataReader for this command's connection; it must be closed first.");
 
 		if (exception is not null || Connection!.IgnorePrepare)

src/MySqlConnector/MySqlConnection.cs

@@ -181,7 +181,7 @@ public override void EnlistTransaction(System.Transactions.Transaction? transact
 			throw new InvalidOperationException("Connection is not open.");
 
 		// ignore reenlistment of same connection in same transaction
-		if (m_enlistedTransaction?.Transaction.Equals(transaction) ?? false)
+		if (m_enlistedTransaction?.Transaction.Equals(transaction) is true)
 			return;
 
 		if (m_enlistedTransaction is not null)
@@ -858,7 +858,7 @@ internal void Cancel(ICancellableCommand command, int commandId, bool isCancel)
 	internal IOBehavior AsyncIOBehavior => GetConnectionSettings().ForceSynchronous ? IOBehavior.Synchronous : IOBehavior.Asynchronous;
 
 	// Defaults to IOBehavior.Synchronous if the connection hasn't been opened yet; only use if it's a no-op for a closed connection.
-	internal IOBehavior SimpleAsyncIOBehavior => (m_connectionSettings?.ForceSynchronous ?? false) ? IOBehavior.Synchronous : IOBehavior.Asynchronous;
+	internal IOBehavior SimpleAsyncIOBehavior => (m_connectionSettings?.ForceSynchronous is true) ? IOBehavior.Synchronous : IOBehavior.Asynchronous;
 
 	internal MySqlSslMode SslMode => GetInitializedConnectionSettings().SslMode;
 
@@ -931,12 +931,12 @@ private async ValueTask<ServerSession> CreateSessionAsync(ConnectionPool? pool,
 				return session;
 			}
 		}
-		catch (OperationCanceledException) when (timeoutSource?.IsCancellationRequested ?? false)
+		catch (OperationCanceledException) when (timeoutSource?.IsCancellationRequested is true)
 		{
-			var messageSuffix = (pool?.IsEmpty ?? false) ? " All pooled connections are in use." : "";
+			var messageSuffix = (pool?.IsEmpty is true) ? " All pooled connections are in use." : "";
 			throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "Connect Timeout expired." + messageSuffix);
 		}
-		catch (MySqlException ex) when ((timeoutSource?.IsCancellationRequested ?? false) || (ex.ErrorCode == MySqlErrorCode.CommandTimeoutExpired))
+		catch (MySqlException ex) when ((timeoutSource?.IsCancellationRequested is true) || (ex.ErrorCode == MySqlErrorCode.CommandTimeoutExpired))
 		{
 			throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "Connect Timeout expired.", ex);
 		}
@@ -990,7 +990,7 @@ private async Task CloseAsync(bool changeState, IOBehavior ioBehavior)
 		if (m_activeReader is null &&
 			CurrentTransaction is null &&
 			m_enlistedTransaction is null &&
-			(m_connectionSettings?.Pooling ?? false))
+			(m_connectionSettings?.Pooling is true))
 		{
 			m_cachedProcedures = null;
 			if (m_session is not null)

tests/SideBySide/TestUtilities.cs

@@ -82,7 +82,7 @@ public static string GetSkipReason(ServerFeatures serverFeatures, ConfigSettings
 
 		if (configSettings.HasFlag(ConfigSettings.KnownClientCertificate))
 		{
-			if (!((csb.CertificateFile?.EndsWith("ssl-client.pfx", StringComparison.OrdinalIgnoreCase) ?? false) || (csb.SslKey?.EndsWith("ssl-client-key.pem", StringComparison.OrdinalIgnoreCase) ?? false)))
+			if (!((csb.CertificateFile?.EndsWith("ssl-client.pfx", StringComparison.OrdinalIgnoreCase) is true) || (csb.SslKey?.EndsWith("ssl-client-key.pem", StringComparison.OrdinalIgnoreCase) is true)))
 				return "Requires CertificateFile=client.pfx in connection string";
 		}